Re: [dpdk-dev] [PATCH v8 0/4] optimized Toeplitz hash implementation

[Thomas Monjalon <thomas@monjalon.net>]

02/11/2021 19:38, Vladimir Medvedkin:
> This patch series adds a new optimized implementation for the Toeplitz hash
> function using Galois Fields New instruction (GFNI).
> The main use case of this function is to calculate the hash value for a single
> data, so there is no bulk implementation.
> For performance reasons, the implementation was placed in a public header.
> It is the responsibility of the user to ensure the platform supports GFNI
> (by doing runtime checks of rte_thash_gfni_supported variable) before calling
> these functions.
> 
> v8:
> - rebased on the latest main
> - fixed buffer overflow reported by ASAN
> 
> v7:
> - reworked performance tests code
> 
> v6:
> - addressed Thomas and Stephen's comments
> - squash the doc and test commith with the relevant code addition
> - split for 2 patches, each per implementation - single and bulk
> 
> v5:
> - rebase on the latest main
> - fix spelling
> 
> v4:
> - included rte_log.h inside the rte_thash_gfni.h
> 
> v3:
> - implementation moved to x86 specific header
> - added rte_thash_gfni_supported() instead of the variable
> - removed RTE_INIT section, due to adding rte_thash_gfni_supported()
> - reworked rte_thash_complete_matrix() to make it easier tor read
> 
> v2:
> - fixed typos
> - made big_rss_key static const and indented
> - addressed Konstantin's comments
> 
> Vladimir Medvedkin (4):
>   hash: add new toeplitz hash implementation
>   hash: add bulk toeplitz hash implementation
>   hash: enable gfni thash implementation
>   test/thash: add performance tests for the Toeplitz hash

Applied, thanks.