From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93EE1A0548; Thu, 4 Nov 2021 11:20:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7C8DD411B2; Thu, 4 Nov 2021 11:20:39 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 8FD3840DFD for ; Thu, 4 Nov 2021 11:20:38 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 122AF5C011B; Thu, 4 Nov 2021 06:20:38 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 04 Nov 2021 06:20:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 21L14mS/y+2tjIEILCtfVkz1j+MQl+LQ4CYRAkoZpgo=; b=DP4MT+55kBBNIjHk l2MVNccDoULzrAeH0ThtjIItgLSAKq0XL1ISx1+UdH6ckbIPuGRGcny9s2nlvLst Lvbidw8+FrOgn+/M6W+SNamFyCI3MiDbZRMScrxeS40adRxZXqMTlDc245HAXTS+ 2nHt4ur46BNtIXfre3t5DwE4qVZWkD+7Z2bUXXGy2m/wPC/pcRYEGwGgZgYFssJE k+qQmHqWuMCqIu3S6yArwOh6NbXga68DtJEKJyZjYz5jbC0WxYn4OdOFR/NR6mle vsUYERkFHxqt3nfDPca1u0XiuQI9Vn2RKIbUN2bF+gMH9zFnmWWMxIvtbREg4RKp KnKclw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=21L14mS/y+2tjIEILCtfVkz1j+MQl+LQ4CYRAkoZp go=; b=kSjjldfaH+jtNyY6QW4tvlGnfSObufRUk1u6q9eNOA8UOlgl0f2RHHc0A nBgLxs5gnH55dT34NiMx4YV6fZrWqOdDyrVnT/oMZdtjFsA1isL8URgR38MXCSV8 tsmMVF7QqWdfAw8Ek9c5kQIg8td+8e//TimVMNg4sEObFx8jn81TP9xPhqwf7WGw JdkWy+7cx+YKfMJSFuktbQ/vJrjpdje6Tbe3CCoe+viU8iutxaebPpuDANwiihDY QrS8hrvcXPkAvhhQQVhsHmiJT1QDcSn+Tw/VYokGfuXTP+aEL5qNfI122xpkMKZ3 R5sD1iFsIb2GA0F0vATBKAhq5WLjg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrtdeggdduudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 4 Nov 2021 06:20:36 -0400 (EDT) From: Thomas Monjalon To: Vladimir Medvedkin Cc: dev@dpdk.org, yipeng1.wang@intel.com, sameh.gobriel@intel.com, bruce.richardson@intel.com, konstantin.ananyev@intel.com, stephen@networkplumber.org Date: Thu, 04 Nov 2021 11:20:34 +0100 Message-ID: <3558648.LSSd2TODQV@thomas> In-Reply-To: <1635878305-102888-1-git-send-email-vladimir.medvedkin@intel.com> References: <1630944239-363648-1-git-send-email-vladimir.medvedkin@intel.com> <1635878305-102888-1-git-send-email-vladimir.medvedkin@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v8 0/4] optimized Toeplitz hash implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/11/2021 19:38, Vladimir Medvedkin: > This patch series adds a new optimized implementation for the Toeplitz hash > function using Galois Fields New instruction (GFNI). > The main use case of this function is to calculate the hash value for a single > data, so there is no bulk implementation. > For performance reasons, the implementation was placed in a public header. > It is the responsibility of the user to ensure the platform supports GFNI > (by doing runtime checks of rte_thash_gfni_supported variable) before calling > these functions. > > v8: > - rebased on the latest main > - fixed buffer overflow reported by ASAN > > v7: > - reworked performance tests code > > v6: > - addressed Thomas and Stephen's comments > - squash the doc and test commith with the relevant code addition > - split for 2 patches, each per implementation - single and bulk > > v5: > - rebase on the latest main > - fix spelling > > v4: > - included rte_log.h inside the rte_thash_gfni.h > > v3: > - implementation moved to x86 specific header > - added rte_thash_gfni_supported() instead of the variable > - removed RTE_INIT section, due to adding rte_thash_gfni_supported() > - reworked rte_thash_complete_matrix() to make it easier tor read > > v2: > - fixed typos > - made big_rss_key static const and indented > - addressed Konstantin's comments > > Vladimir Medvedkin (4): > hash: add new toeplitz hash implementation > hash: add bulk toeplitz hash implementation > hash: enable gfni thash implementation > test/thash: add performance tests for the Toeplitz hash Applied, thanks.