From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id C4BF42BA1 for ; Thu, 10 Mar 2016 00:23:42 +0100 (CET) Received: by mail-wm0-f46.google.com with SMTP id l68so6763017wml.0 for ; Wed, 09 Mar 2016 15:23:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=l6NA/O7mTDPggYVwQ+aMvRvjABtaU19EJta92uQn/VY=; b=0YwJqH6oAthSC1zUqWm2/7yIGC2aGMUNt6pNNZXHtcAE91GwGmmSdxyvvrA1pjHPoR GVZJVrGnvD5RICl4mVmhGR+9/3sASvXzW6vRgzM5YtQMHIqCTlZJblTbC6lfQcaxIGnX HuqWzuwDZ0ytKlw/QDS+VaIif3f4MvFeZgcE0OGNuMRAsbgHpLYVV8sdtobVt+hJBmw7 DjXMk/+emsJIGv0bx9+jZz4I0412V/LP+g+/GfykWlHc3PZUzNcwl9K/c5Porgl9vmSH 3qjydCmZq3nC5RJqLUvgLnzPEKRUyuP3DSlhOtufJBbda9FeUQ3EPA1l+1S40mEAvh4r auRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=l6NA/O7mTDPggYVwQ+aMvRvjABtaU19EJta92uQn/VY=; b=hoi78SO+FwS7gNabq1WCyzDzD/Gio0Sp4j4gYibjYyKupJd9w0O4rfI+pVQtiiRjr1 dsBSSubShu7bxHWcqqYS3OKDMy8QExVpGTHYtWXKk9/T7bNPGlvIJTF+ZKYlWBSFO2IW l12s5xI16ff/H3fMQ83FiJcw5nk+N8Bm3ifTJYEC0Bup1msPK880jcT+F72bi5mOVhFF zpm2gnClyTq2Y7Vmlc33+86kmHQDD+s5AotXA/pXjhi3uactFtfUn4f18YLNDWNdden4 JTY9KAswonNqeM18iPvrTIsaChmWh2vd4CjlXHN+YnxySOLKfofHVyA9r6QPYLTz7va9 KEGA== X-Gm-Message-State: AD7BkJJAThQlp8vxxaT1JEzuBWkQaGPnSfMSRSh8j6+ygeXdLNEuH4kD8FloqiHUleUgp6ml X-Received: by 10.28.111.92 with SMTP id k89mr307507wmc.36.1457565822627; Wed, 09 Mar 2016 15:23:42 -0800 (PST) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id o128sm753654wmb.19.2016.03.09.15.23.41 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 09 Mar 2016 15:23:41 -0800 (PST) Date: Wed, 09 Mar 2016 15:23:41 -0800 (PST) X-Google-Original-Date: Thu, 10 Mar 2016 00:22 +0100 From: Thomas Monjalon To: Huawei Xie Message-ID: <3562231.jlqsJmrYNZ@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1457451223-82306-7-git-send-email-huawei.xie@intel.com> References: <20151222035041.GA7532@pxdev.xzpeter.org> <1457451223-82306-1-git-send-email-huawei.xie@intel.com> <1457451223-82306-7-git-send-email-huawei.xie@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, nikita.troitsky@intel.com Subject: Re: [dpdk-dev] [PATCH v5 6/6] virtio: return 1 to tell the upper layer we don't take over this device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Mar 2016 23:23:42 -0000 2016-03-08 23:33, Huawei Xie: > PMD_INIT_LOG(INFO, "trying with legacy virtio pci."); > - if (legacy_virtio_resource_init(dev, hw) < 0) > + if (legacy_virtio_resource_init(dev, hw) < 0) { > + if (dev->kdrv == RTE_KDRV_UNKNOWN && > + dev->devargs->type != RTE_DEVTYPE_WHITELISTED_PCI) { I still think you should add && dev->devargs->type != RTE_DEVTYPE_BLACKLISTED_PCI) Not a big deal. > + PMD_INIT_LOG(INFO, > + "skip kernel managed virtio device."); > + return 1; > + } > return -1;