From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id CF4458D3D for ; Tue, 27 Oct 2015 18:35:21 +0100 (CET) Received: by wijp11 with SMTP id p11so224957594wij.0 for ; Tue, 27 Oct 2015 10:35:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=WyjFVPebUfGufeiEVYkWBBq2rE9e/qff4vONu/X8MEg=; b=2ImCFgsoe4kbBBbvU8+NyAcqUS2akEIo5gXxI9HLMZzkoDrp4Iu6LPIL1sG3vsOFfa lZabCX6SpKCOd43zYWKQDEL9FINvg6G9C1jr1AdNNPuPnO5w3JH4bYr4Wp5F9/dbuGuz U1XaI1AoyxbJPPaoktDdwSoedNpedv2Hxkw1Cbcbt4svcGZH8RN0Cz1bd7PQAlayAtkk O0DzsgQoVdhtpAunu7cUYrQggMmSEaUT9jfk5xpoZhid2vfWUTk+wCu996R64XdOPRND sk7kb5aQwmHwGJybzU5Yq3X7z99TNo7oz4PAjQQ3AZu5m5CuUQmPktI/UXt3g6a0djMJ SCyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=WyjFVPebUfGufeiEVYkWBBq2rE9e/qff4vONu/X8MEg=; b=EpdQxpC9jwk6elYc5rDfCdXUYat+Rd1MB88rTg7QFYAliGhnaW2+BqADwoae1Z3ki7 BS9F0i/CEJQsvbi4ubyG16+9+EX0ddC4VmKbMlViQvtgQcaaOtwNmcWmegPwD5KH2baT DJuW90VC8hr4l46YINYqz9sWH9chO6zi88M4sLo4XltrS/znDdm4AnPpAqXN6Q2GSBYt k7TihOh9UYeZ7mosvbOkdfc2S7RfMmimj2FI1XbbRWy5Zdq2tsRQnsX+4aZQeyZgexji o6d1z5gbxIiUWe1iGZTNpRxg/OXJNiSeYdgnl5ex57XN7HqtyCBpoIgrdg0yPXiWmwAo UaRg== X-Gm-Message-State: ALoCoQnml1urPVLIs3mhMSEqCf49xQgRwyu3So0xNqc2Wm60TO3WB2AljW5p1ccNc5ThryCaL6WN X-Received: by 10.180.211.101 with SMTP id nb5mr15378233wic.0.1445967321680; Tue, 27 Oct 2015 10:35:21 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id o3sm18501676wif.22.2015.10.27.10.35.20 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 27 Oct 2015 10:35:21 -0700 (PDT) From: Thomas Monjalon To: Tomasz Kulasek Date: Tue, 27 Oct 2015 18:34:11 +0100 Message-ID: <3564070.kbSGEXeQ4h@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1444989651-6236-7-git-send-email-tomaszx.kulasek@intel.com> References: <1443621905-7872-1-git-send-email-tomaszx.kulasek@intel.com> <1444989651-6236-1-git-send-email-tomaszx.kulasek@intel.com> <1444989651-6236-7-git-send-email-tomaszx.kulasek@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v6 6/9] test: dynamic rss configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Oct 2015 17:35:22 -0000 This new test depends on null PMD. The dependency should be checked gracefully, see below. 2015-10-16 12:00, Tomasz Kulasek: > --- a/app/test/Makefile > +++ b/app/test/Makefile > @@ -138,6 +138,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_ACL) += test_acl.c > ifeq ($(CONFIG_RTE_LIBRTE_PMD_RING),y) > SRCS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += test_link_bonding.c > SRCS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += test_link_bonding_mode4.c Why not enclose in ifeq ($(CONFIG_RTE_LIBRTE_PMD_NULL),y)? > +SRCS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += test_link_bonding_rssconf.c > endif > > SRCS-$(CONFIG_RTE_LIBRTE_PMD_RING) += test_pmd_ring.c > @@ -168,6 +169,13 @@ ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) > LDLIBS += -lrte_pmd_ring > endif > endif > +ifneq ($(CONFIG_RTE_LIBRTE_PMD_NULL),y) > +$(error Link bonding rssconf tests require CONFIG_RTE_LIBRTE_PMD_NULL=y) Not needed if handled as suggested above. The build should not fail because a module is disabled. > +else > +ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) > +LDLIBS += -lrte_pmd_null > +endif > +endif