From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 43433A0553; Sun, 26 Jun 2022 10:35:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D3F4041144; Sun, 26 Jun 2022 10:35:48 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 58AFC41141 for ; Sun, 26 Jun 2022 10:35:47 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 300413200904; Sun, 26 Jun 2022 04:35:46 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 26 Jun 2022 04:35:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1656232545; x= 1656318945; bh=+mu0s5fBnrrOp8rYN0eYryXEj4CogRfJYQ2jxAfLkvY=; b=N WXqRt8txa8Ggnj0Vuay0JhmD/xteRH2CHdNRNxPN4LpbrhGxBKhMHrwDBuE8edbI ZVpK20vU53N/IodU7zUPdxoWqJePWdlZJOZjZZ7nR8rHd4tRjUpdLN1d2gL/+wVO 1dDoxdB5dhMwDvZlIwp3seHowqYOnDIYBNuwi/lZlR1oCXkNVcYn6Gelg2H+CrFN VeCHwVkxzs0m4VvkeLKFNusr4mgYYVG/SYVsP0ZP2PIsvdnp836W94gltjQOvVWE AGGWlygg1ixkkUnDxQ6n2dRyWo8ma3i1+eJ4+vwbDAwtORlsP/dzXcO3LE7V87cv cFWpnudw9cNY77SBm/ZyQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1656232545; x= 1656318945; bh=+mu0s5fBnrrOp8rYN0eYryXEj4CogRfJYQ2jxAfLkvY=; b=S 3NODcZdJJ8WNVHVEefaOtj0Nj9/L8DRGSdXI0C9lqyjmReVDbipFyWBJ855xq9Bm e483FT8ounZEp3ozd4X1kgcgHjmzAa5Mb7NwmHth5sFqEbahnC2x2ID9KiK+X6vZ +C0yp+YYLzoMULqmkXpctBRWXRTFg2cvuMHfywYa9AhH/qBoW54QsNZ+Z9wK2ymU XngJjpTCItYVTLXREzEwQ4OC2kxxQS9oCNU0ciP+ymsh/POGIR+iDI4L7SCRbUZZ SHZSKCG1hOba3sRMVb+iuPRvt52qe8r9i2MB++YHyJzdR781Ls+QzXNi0+sLZKNK ShXK4v80cZglZ/K/kaEAA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudegfedgtdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 26 Jun 2022 04:35:45 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org Subject: Re: [PATCH v2 1/2] examples/l3fwd: add include for macro definition Date: Sun, 26 Jun 2022 10:35:43 +0200 Message-ID: <3566664.22IY78Rhhi@thomas> In-Reply-To: <20220615171013.36426-2-bruce.richardson@intel.com> References: <20220614122904.159946-1-bruce.richardson@intel.com> <20220615171013.36426-1-bruce.richardson@intel.com> <20220615171013.36426-2-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 15/06/2022 19:10, Bruce Richardson: > The header files "l3fwd_em.h" and "l3fwd_em_sequential.h" use the > "__rte_always_inline" macro but don't directly include "rte_common.h" to > get the definition of it. This inclusion is not necessary for > compilation, but the lack of it can confuse some indexers - such as > those in eclipse, which reports the lines: > > "static __rte_always_inline uint16_t" > > as possible definitions of a variable called "uint16_t". This confusion > leads to uint16_t being flagged as an unknown type in all other parts of > the project being indexed, e.g. across all of DPDK code. > > Adding in the include of rte_common.h makes it clear to the indexer that > those lines are part of a function definition, and that allows eclipse > to correctly recognise uint16_t as a type from stdint.h > > Signed-off-by: Bruce Richardson Applied, thanks.