Re: [dpdk-dev] [PATCH] doc: scheduler API deprecation notice

[Thomas Monjalon <thomas@monjalon.net>]

10/08/2020 13:49, Trahe, Fiona:
> Sorry about that Thomas, Akhil, we should have chased up acks sooner. 
> 
> Given the proposed content of the patch, and the similar changes that are recommended and agreed
> throughout DPDK do you think an exception can be made and that this change can get into 20.11 even
> without the deprecation notice being in 20.08?

That's a question for techboard.

PS: please avoid top-posting



> From: Thomas Monjalon <thomas@monjalon.net>
> > 10/08/2020 11:47, Dybkowski, AdamX:
> > > I see there are 3 ACKs: original (see the commit message) from Fan, then Thomas and Akhil.
> > > This page: http://patches.dpdk.org/project/dpdk/list/?series=11317
> > > also shows it has 3 ACKs.
> > 
> > Sorry I missed initial ack.
> > 
> > > Can I ask why it didn't go into 20.08 then?
> > 
> > Because it was completed late, I missed and nobody replied.
> > 
> > In general, I would like more support in last days of release,
> > to avoid such miss.
> > 
> > 
> > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > 06/08/2020 19:18, Akhil Goyal:
> > > > > > 27/07/2020 11:41, Adam Dybkowski:
> > > > > > > This patch adds a deprecation notice about upcoming changes in
> > > > > > > public API of the Scheduler PMD.
> > > > > > >
> > > > > > > Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> > > > > > > Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
> > > > > > > ---
> > > > > > > +* scheduler: The functions
> > > > > > > +``rte_cryptodev_scheduler_slave_attach``,
> > > > > > > +  ``rte_cryptodev_scheduler_slave_detach`` and
> > > > > > > +  ``rte_cryptodev_scheduler_slaves_get`` will be replaced in
> > > > > > > +20.11 by
> > > > > > > +  ``rte_cryptodev_scheduler_worker_attach``,
> > > > > > > +  ``rte_cryptodev_scheduler_worker_detach`` and
> > > > > > > +  ``rte_cryptodev_scheduler_workers_get`` accordingly.
> > > > > >
> > > > > > Acked-by: Thomas Monjalon <thomas@monjalon.net>
> > > > > >
> > > > > I wonder how this patch got missed.
> > > > >
> > > > > Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
> > > >
> > > > Sorry it is missing an ack.
> > 
> > 
> 
>