From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id B637858D8 for ; Fri, 14 Oct 2016 16:20:01 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id c78so560071wme.0 for ; Fri, 14 Oct 2016 07:20:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=SLqqErri1DHf/1S5yKD7sjtBUUZaKaMCg9itOIl2/k4=; b=rO5uf94Pk+ZgcVVRAOk4UOco8aPFTL02mmI2GV7KsZGULmt+K/HM2NMAcnr0J5NMou 3NBixqL4S8chl4MtP1nr9qFukFXR3t/NBktMlePSspUIWVV4BkSGn2Y553C5DWuVKKxC Mc/VBrCW3dN942VqAn8vxJ8Z3jSYuH48/uHDM3NM4kDY8NT2hH1QOs0s5h2eJ4Qj9py0 05RGBUxoaj9xrf9hEVtLUxGJAjXra2n9AThxXlw4Pnut482iRMYrsgWmFlbmo0b11haB RCG0G6gYP1C6r0afTLrlsT+6aN4VAVUnxF1I6+gRoT1m0M7f5+gvtJz7R+PLHB3iootM wi+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=SLqqErri1DHf/1S5yKD7sjtBUUZaKaMCg9itOIl2/k4=; b=ApXxGsr0ril+tmAFx3Z5Qf3ja5vE3552lR+YCLBlOXMRaDkXav83SV0T2tW1ukfNsG ldYrs1n5xZNBeRaBmfXoVw4sDGd2ZiqMnmalqrHOHbJH35g9UHpjajcASfrKaMYUW9d2 xpKW0Sm2eIFBq9X8kjBSOUH5JmRi8oheszL54U9fabMNKQQwhiz0vv3Cjh9lhtqEn0I3 HW3Xod8M0D4LdjoSaK4eAbNGv+RfGKFxt7OSB6Td32VXugtry3fEPZYBuKV2Nqf2E64D ZfvgJky8XS9vdtR72yBFcT53AnE/n2Nqk5P5AAhYroTKfLazNNL9kzkX936ORUH4ze6O HvFw== X-Gm-Message-State: AA6/9Rk/Oci7l1Te+Sb5gdfLOhOZRKySN+qWrNMUNdR+VLwsq1d5TYBr4ZNKtIVKLktxveiv X-Received: by 10.28.156.10 with SMTP id f10mr5827713wme.57.1476454801498; Fri, 14 Oct 2016 07:20:01 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id d13sm48511wmd.15.2016.10.14.07.20.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Oct 2016 07:20:00 -0700 (PDT) Date: Fri, 14 Oct 2016 07:20:00 -0700 (PDT) X-Google-Original-Date: Fri, 14 Oct 2016 16:20 +0200 From: Thomas Monjalon To: "Kulasek, TomaszX" Cc: dev@dpdk.org, "Ananyev, Konstantin" , olivier.matz@6wind.com Message-ID: <3567043.JXAYMJHPG7@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <3042915272161B4EB253DA4D77EB373A14F35FFC@IRSMSX102.ger.corp.intel.com> References: <20160930090039.10164-1-tomaszx.kulasek@intel.com> <8024593.WaNfoiub2G@xps13> <3042915272161B4EB253DA4D77EB373A14F35FFC@IRSMSX102.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 1/6] ethdev: add Tx preparation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Oct 2016 14:20:02 -0000 2016-10-14 14:02, Kulasek, TomaszX: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2016-10-13 19:36, Tomasz Kulasek: > > > +/** > > > + * Fix pseudo header checksum for TSO and non-TSO tcp/udp packets > > before > > > + * hardware tx checksum. > > > + * For non-TSO tcp/udp packets full pseudo-header checksum is counted > > and set. > > > + * For TSO the IP payload length is not included. > > > + */ > > > +static inline int > > > +rte_phdr_cksum_fix(struct rte_mbuf *m) > > > > You probably don't need this function since the recent improvements from > > Olivier. > > Do you mean this improvement: "net: add function to calculate a checksum in a mbuf" > http://dpdk.org/dev/patchwork/patch/16542/ > > I see only full raw checksum computation on mbuf in Olivier patches, while this function counts only pseudo-header checksum to be used with tx offload. OK. Please check what exists already in librte_net (especially rte_ip.h) and try to re-use code if possible. Thanks