* [dpdk-dev] [PATCH] net/i40e: fix hierarchy commit check
@ 2017-07-26 14:43 Wenzhuo Lu
2017-07-26 15:17 ` Dumitrescu, Cristian
0 siblings, 1 reply; 3+ messages in thread
From: Wenzhuo Lu @ 2017-07-26 14:43 UTC (permalink / raw)
To: dev; +Cc: Wenzhuo Lu
If there's no Traffic Management node added. Not
necessary to check if TM is committed.
Fixes: cac29c3c00a4 ("net/i40e: support committing TM hierarchy")
Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 9fcccda..042bcc1 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -2033,7 +2033,7 @@ static inline void i40e_GLQF_reg_init(struct i40e_hw *hw)
i40e_filter_restore(pf);
- if (!pf->tm_conf.committed)
+ if (pf->tm_conf.root && !pf->tm_conf.committed)
PMD_DRV_LOG(WARNING,
"please call hierarchy_commit() "
"before starting the port");
--
1.9.3
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/i40e: fix hierarchy commit check
2017-07-26 14:43 [dpdk-dev] [PATCH] net/i40e: fix hierarchy commit check Wenzhuo Lu
@ 2017-07-26 15:17 ` Dumitrescu, Cristian
2017-07-31 17:11 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Dumitrescu, Cristian @ 2017-07-26 15:17 UTC (permalink / raw)
To: Lu, Wenzhuo, dev; +Cc: Lu, Wenzhuo
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu
> Sent: Wednesday, July 26, 2017 3:44 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Subject: [dpdk-dev] [PATCH] net/i40e: fix hierarchy commit check
>
> If there's no Traffic Management node added. Not
> necessary to check if TM is committed.
>
> Fixes: cac29c3c00a4 ("net/i40e: support committing TM hierarchy")
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> ---
> drivers/net/i40e/i40e_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 9fcccda..042bcc1 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -2033,7 +2033,7 @@ static inline void i40e_GLQF_reg_init(struct
> i40e_hw *hw)
>
> i40e_filter_restore(pf);
>
> - if (!pf->tm_conf.committed)
> + if (pf->tm_conf.root && !pf->tm_conf.committed)
> PMD_DRV_LOG(WARNING,
> "please call hierarchy_commit() "
> "before starting the port");
> --
> 1.9.3
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/i40e: fix hierarchy commit check
2017-07-26 15:17 ` Dumitrescu, Cristian
@ 2017-07-31 17:11 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2017-07-31 17:11 UTC (permalink / raw)
To: Lu, Wenzhuo; +Cc: dev, Dumitrescu, Cristian
> > If there's no Traffic Management node added. Not
> > necessary to check if TM is committed.
> >
> > Fixes: cac29c3c00a4 ("net/i40e: support committing TM hierarchy")
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Added TM in the title and applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-31 17:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-26 14:43 [dpdk-dev] [PATCH] net/i40e: fix hierarchy commit check Wenzhuo Lu
2017-07-26 15:17 ` Dumitrescu, Cristian
2017-07-31 17:11 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).