From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id A174F2946 for ; Mon, 3 Oct 2016 16:28:02 +0200 (CEST) Received: by mail-wm0-f51.google.com with SMTP id p138so154484939wmb.1 for ; Mon, 03 Oct 2016 07:28:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=ez/ZfSwq+I7gHnVF4eFMEaipnLqNLvL782LcXot6sRQ=; b=V6EXjqyEFcfBs+flXE1HqaRR1Fyzj/cpIg6+QeurH73nQl/8EZVibmhOZ1NfNG7H5s rpyWv0ECsFJvX4p4hmKjlig/5xxJc4ygjZvrc8TFLLorWNRo0xhsqYnirvdL24cSz1uz PgTSpzyvOvdRW8u6MVs0s2Pk2pX0ca+yeFY/hHNmEzpLeAR62r7uGIyRCN3uvGj8ybIZ mqa22vx4sRO2t2A8Yr+zLVF/zUcSRJr3clbXjRN4HYuPmDi/3CX6/rOaf6qD61UqPhxr eAbX76O49B0Iu3WKdxYdmvVVtFsZudVQzGOxS6r9AFsolqcExxmE6jh5bF8GRnZ2q8Pc cCyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=ez/ZfSwq+I7gHnVF4eFMEaipnLqNLvL782LcXot6sRQ=; b=Keyu19XYAcECRLFiJFyz8iR7OpGFbpm/XvVbw+3fZ2t0bYtd0tHSsuiSnDVHMeDNep 1Ge/lgTK5OBSWSlYGt7XHbM9rm7mFUlvPjKJ0lKMSS8LldG+SxuyDU7LAEGvfn5UR9dW n8Yt62zhGlysIbx3vVamsOAdM9PuvoXhogsYQAstNGATKwwgcWq6O76ktl1D3zqMHCij ExqIpLeCWrJHEVyCBFr6hnHC9UDwKqRB6hMlopS4QSJa6QVKNhoMAqstsYw6JPg/GIeF B2FwFIuSqW7k9DgrHB9Enfs1mTohcYJHVkYqNSXXx75rWn8DbrzOXSG9tWhtI43XwueO EiYA== X-Gm-Message-State: AA6/9RkU0k7lbA96GZ9kM3+73n3MiZXmPolCpyTvP19xlGa0EUkpL+4ce7j1KH5qSz7LwUd9 X-Received: by 10.28.45.135 with SMTP id t129mr2505977wmt.95.1475504882439; Mon, 03 Oct 2016 07:28:02 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id qo8sm7009756wjc.46.2016.10.03.07.28.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Oct 2016 07:28:01 -0700 (PDT) Date: Mon, 03 Oct 2016 07:28:01 -0700 (PDT) X-Google-Original-Date: Mon, 03 Oct 2016 16:28 +0200 From: Thomas Monjalon To: Shreyansh Jain Cc: dev@dpdk.org, viktorin@rehivetech.com, David Marchand , hemant.agrawal@nxp.com Message-ID: <3582057.BR181DtlIn@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1474375296-26078-1-git-send-email-shreyansh.jain@nxp.com> References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1474375296-26078-1-git-send-email-shreyansh.jain@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v11 00/24] Introducing rte_driver/rte_device generalization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Oct 2016 14:28:02 -0000 Applied, thanks everybody for the great (re)work! 2016-09-20 18:11, Shreyansh Jain: > Future Work/Pending: > =================== > - Presently eth_driver, rte_eth_dev are not aligned to the rte_driver/ > rte_device model. eth_driver still is a PCI specific entity. This > has been highlighted by comments from Ferruh in [9]. > - Some variables, like drv_name (as highlighted by Ferruh), are getting > duplicated across rte_xxx_driver/device and rte_driver/device. What about those pending work? I would add more remaining issues: - probe/remove naming could be applied to vdev for consistency - rte_eal_device_insert must be called in vdev - REGISTER macros should be prefixed with RTE_ - Some functions in EAL does not need eal_ in their prefix: rte_eal_pci_ -> rte_pci_ rte_eal_dev_ -> rte_dev_ rte_eal_vdev_ -> rte_vdev_ rte_eal_driver -> rte_drv_ rte_eal_vdrv -> rte_vdrv_