From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2A9445B5F; Thu, 17 Oct 2024 17:50:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C21144025F; Thu, 17 Oct 2024 17:50:26 +0200 (CEST) Received: from fhigh-a6-smtp.messagingengine.com (fhigh-a6-smtp.messagingengine.com [103.168.172.157]) by mails.dpdk.org (Postfix) with ESMTP id ACB9F4021E for ; Thu, 17 Oct 2024 17:50:25 +0200 (CEST) Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfhigh.phl.internal (Postfix) with ESMTP id 6106B11405EF; Thu, 17 Oct 2024 11:50:25 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-11.internal (MEProxy); Thu, 17 Oct 2024 11:50:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1729180225; x=1729266625; bh=KeFIFJ4AcPyJyC7r8Gck7Rywac4DRZnXFAmqiWZ8B+s=; b= gRSQE2NiD5FDliduCJN4dn+QDHabH89QB/cehNzi/pNTsmZzJChLRSmYvqIAncQg bQ8eoM8sMdGgWY03bKXNM2qInZaQwsA3LFU4s8H05n0JC+FAdgOLjCoF2MCfOHOB EPUVPVKFlJUC8FCN1mrxMWD1cFuiH1FawcNryHuNgWkljUc8DwJJdCsYXFirCXMI Ki+fbyyenn4mkOrplUd9ODouWPvggdtY6ATZrIQ3aRDLMrp02V9ZeD92YVFRGFnI txm1cRItA4YZBFDNx0R8J3OBZPTT0ElfCDYgh0qynohKdDzQuN1GT7PHdf+THVfp 7K6xz1W86wArhPAdnkO6uw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1729180225; x= 1729266625; bh=KeFIFJ4AcPyJyC7r8Gck7Rywac4DRZnXFAmqiWZ8B+s=; b=j 0PSB2qMJEUJxNvAzX4b8WZw9yT6C5BWscmYZQ2KxFIgUwgToR5xHIWK69kLUdifY PRn460zi67JUrHrcTKqdFsFP453bbtwZflsP4uO76u8WE9P0fGg8IjsWXEPQQX+Y qSOgqsMJyxrzDlkYMHPacoWeKVxMWhVc6xSc93h61Uky7ePZ6RGIQS+PV5VksGrP CG7NYgyQTf+/FXe+ISu1AHP30R/NwhFpPyApFhdmEd+I4F65UUsr0s5gpMZX0j5d jIzZpQpPA21gqs482y2ncQ6RZhgZ4uNlC3RCKWiPIdM9X1uwFQFWsPRYW6OYcsf9 yzUKEs9xS4ay31XDmwRsA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdehuddgleehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefufffkjghfggfgtgesthfuredttddtjeen ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpeejudevheeiveduuddtveffgfdtgeek ueevjeffjeegtdeggeekgfdvuefgfeekjeenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtpdhn sggprhgtphhtthhopeefpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehgrdhsih hnghhhsehngihprdgtohhmpdhrtghpthhtohepsghruhgtvgdrrhhitghhrghrughsohhn sehinhhtvghlrdgtohhmpdhrtghpthhtohepuggvvhesughpughkrdhorhhg X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 17 Oct 2024 11:50:24 -0400 (EDT) From: Thomas Monjalon To: Gagandeep Singh Cc: Bruce Richardson , dev@dpdk.org Subject: Re: [v1 2/3] meson: add a meson option to install examples source Date: Thu, 17 Oct 2024 17:50:22 +0200 Message-ID: <3583668.cLl3JjQhRp@thomas> In-Reply-To: References: <20240806134218.3619913-1-g.singh@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 07/08/2024 06:08, Gagandeep Singh: > From: Bruce Richardson > > On Tue, Aug 06, 2024 at 07:12:17PM +0530, Gagandeep Singh wrote: > > > Adding a meson option "enable_examples_source_install" > > > to enable or disable installation of examples source code. > > > > > > Default value is true. > > > > > > Signed-off-by: Gagandeep Singh > > > --- > > > meson.build | 7 ++++--- > > > meson_options.txt | 2 ++ > > > 2 files changed, 6 insertions(+), 3 deletions(-) > > > > > Is installing sample code for DPDK a problem that we need to disable it? I > > was expecting that such filtering out of unwanted files could be done via > > packaging rather than us having to add lots of DPDK build options to control > > these things. > > > I understand your point that packaging could handle filtering out unwanted files. > However, adding a build option to disable DPDK examples source code installation provides > more control and flexibility for users who may have specific requirements or constraints. > > While packaging can filter out files, this option allows users to avoid > downloading and compiling the examples altogether, which can be beneficial for: > > - Users with limited disk space or network bandwidth > - Users who only need the core DPDK libraries and binaries and don't want the examples source code. > > By default, the option is set to true, so the behavior remains unchanged. > This option is only for those who need more control over their build process. > I believe this optional flag adds flexibility without imposing unnecessary files on users and is a minor > and useful extension to the build system. Should we extend the option "enable_docs - build documentation" to "enable_docs - build documentation and install examples" ?