From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 048A6A052B; Fri, 31 Jul 2020 00:06:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8BA9C2BB8; Fri, 31 Jul 2020 00:06:27 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id BF1E11023 for ; Fri, 31 Jul 2020 00:06:25 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id E55DC5C01B0; Thu, 30 Jul 2020 18:06:24 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 30 Jul 2020 18:06:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= dcUP67MRsdk/VxPtrSb272DcXRl8rft/LrAIb7YepUg=; b=EzLPzGR/65FTFUSy mwFAOB17cB8Mu8ads1tB1NLZTjvV2iAcw2gQXn6sR7W7KIMX4fm1GKe3EGxyZJVq Qfk1hUC6KJYdqZklDUl6MrrhxUe9N5AnFKJt82UR/2PTqVg4xeQVYEMhESDfWaWY 4xuTRtoLyTk2DgX73nyFMARVnqolB8p8lYOMIQHi0Hab4AtfP0PHgWrKGD5E8NMv T1mKTFIJqfu7q/mSaKAzl1cMsdFy5rGybgB9mWyQszhdb0CFXfYvDzCIcY09U/b6 m3W5bCt0eqlYUQUUGAsoPSbyzNH/+Dz/8y9U705SG45IApfdZN40w7xjxSNunEAz MBtyCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=dcUP67MRsdk/VxPtrSb272DcXRl8rft/LrAIb7Yep Ug=; b=KFowE1o+A3f834JCAbQbRNxcTeSPmQu3GGpyqdA70Hf+Xd+xioHzGySHN EJVjXyi0pm1ywJWxX10BQ5zRYuhyqb+ydljEdoYIF71PbXXzcJQfvjDUAxtH1HNg kGRglaZKQVEWtRAwTbp0L/qDgdl+U0ZkMUrDpGQI1vgryGbtOQ1aJv8w71pEwS+E ZMko4AwJF+cY0a3yRHh/rEe7HR1okQx/VG3zaT8+UmQ4L8AuSGFrMD3rgwgbyHkS ix1WHHM9vLeeB3RWcsiR8FgWlsFYmNvt8S3Hflsis6MIzAmclHhwTZ2XP7dFOeL+ 3JtUAINOl8tKrHqS5URzvT7HqtDHA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrieejgddtiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeelhedtudefgeekgeekgefgtdeggeegffekheehleduudevueekgfdt vdettdeljeenucffohhmrghinhepghhithdrtghinecukfhppeejjedrudefgedrvddtfe drudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhm pehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 502D9328005A; Thu, 30 Jul 2020 18:06:24 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org Date: Fri, 31 Jul 2020 00:06:23 +0200 Message-ID: <3584477.4m1K3HXnfP@thomas> In-Reply-To: <20200714232101.32544-1-stephen@networkplumber.org> References: <20200129155907.20556-1-stephen@networkplumber.org> <20200714232101.32544-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5] devtools: add new SPDX license compliance checker X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 15/07/2020 01:21, Stephen Hemminger: > Simple script to look for drivers and scripts that > are missing requires SPDX header. > > Signed-off-by: Stephen Hemminger [...] > +#! /bin/sh > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright 2020 Microsoft Corporation > +# > +# Produce a list of files with incorrect license tags > + > +errors=0 > +warnings=0 > +quiet=false > +verbose=false > + > +print_usage () { > + echo "usage: $(basename $0) [-q] [-v]" > + exit 1 > +} > + > +check_spdx() { > + if $verbose; then > + echo "Files without SPDX License" > + echo "--------------------------" > + fi > + git grep -L SPDX-License-Identifier -- \ > + ':^.git*' ':^.ci/*' ':^.travis.yml' \ > + ':^README' ':^MAINTAINERS' ':^VERSION' ':^ABI_VERSION' \ > + ':^*/Kbuild' ':^*/README' \ > + ':^license/' ':^config/' ':^buildtools/' \ > + ':^*.cocci' ':^*.abignore' \ > + ':^*.def' ':^*.map' ':^*.ini' ':^*.data' ':^*.cfg' ':^*.txt' \ > + ':^*.svg' ':^*.png'\ I don't agree with this list of files. But I guess we can start with that and be more strict in future. > + > $tmpfile > + > + errors=$(wc -l < $tmpfile) > + $quiet || cat $tmpfile > +} > + > +check_boilerplate() { > + if $verbose ; then > + echo > + echo "Files with redundant license text" > + echo "---------------------------------" > + fi > + > + git grep -l Redistribution -- \ > + ':^license/' ':^/devtools/check-spdx-tag.sh' > $tmpfile > + > + warnings=$(wc -l <$tmpfile) > + $quiet || cat $tmpfile > +} > + > +while getopts qvh ARG ; do > + case $ARG in > + q ) quiet=true ;; > + v ) verbose=true ;; > + h ) print_usage ; exit 0 ;; > + ? ) print_usage ; exit 1 ;; > + esac > +done > +shift $(($OPTIND - 1)) > + > +tmpfile=$(mktemp) Should be mktemp -t dpdk.checkspdx.XXXXXX to keep namespace of our temp files. Will fix. > +trap 'rm -f -- "$tmpfile"' INT TERM HUP EXIT Why catching HUP signal? Applied, thanks