From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21786A0542; Tue, 5 Jul 2022 16:27:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0EB5340E50; Tue, 5 Jul 2022 16:27:46 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id 832DF40223 for ; Tue, 5 Jul 2022 16:27:44 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 3E2275C008C; Tue, 5 Jul 2022 10:27:44 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 05 Jul 2022 10:27:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1657031264; x= 1657117664; bh=KLixH8fV9uFWwHDRx9T3yFrpgxy48sxVQQ3+5+MabHU=; b=P JRBMMVURPh6/ui+lu2qaG/RKWeh2SCNvPbBNHgw/O+2Q+pC6FqTv5z8Weoz/KLg6 MSPlyUgabnOwNMbtm6SVcHkjOq0skNZPHoyg463ZzAv1HX3hDq+pHhgwrySsv9w3 CAPEXAOkI9Eic8q8jj7aJw3b0KfFoOTG+GeMoHXleWAOXoYw1ImypoSIewmJHkfD cEFCPSLCPiuWBVgsELSZaW/i6PIP3wLbQcnDI1Xu0wNRwdHlDDQg7tUBJM8Ez9TA gy+MCG56cIxBJMnPd8ZgTmYB/NYzqAs7OqllzzeRiJ2VgpQ5xvlpQ08xdXMqvGxz 0mdQsbSo6jbzO4m4YJGag== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1657031264; x= 1657117664; bh=KLixH8fV9uFWwHDRx9T3yFrpgxy48sxVQQ3+5+MabHU=; b=E 2ZNJvbUxO7hWbXhxWOzeRgGT+WwsUPo9Pxa8bsb4+SfuwF3WTBnsImcoJoZXUBXr vC+cjE3Vf/31c+vNe8kBx2QBEIHeZjbUIKMSV1En5/tUUTQUsSHBT/7EI1yye7p+ xFEpBJPMAZFq2m+R89JhVoBOvxyMD078c4W8YAMKlGvYG4lRhx+A10xdT/LIQXw2 G6bBwijOug0Yfa+Lhl8TpTOwAWzx7pEeJnkSA/bNJ4GPY5rUcybJmoZTh+uBX5s7 vHo6+dS9kNFa5O7jGLKoAASB2+oJdTKjWSzvGgCWFNxTXNIlpZqJ4CYJbQK8fbi3 YF63mOJIOEMo/+H44f46Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeiuddgjeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 5 Jul 2022 10:27:43 -0400 (EDT) From: Thomas Monjalon To: Harry van Haaren Cc: dev@dpdk.org, "S . V . Naga Harish" Subject: Re: [PATCH] service: debug and fix lingering might_be_active() result Date: Tue, 05 Jul 2022 16:27:42 +0200 Message-ID: <3586411.1SvkZsmPdQ@thomas> In-Reply-To: <20220705133207.2853345-1-harry.van.haaren@intel.com> References: <20220705133207.2853345-1-harry.van.haaren@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 05/07/2022 15:32, Harry van Haaren: > This commit fixes an issue where calling rte_service_lcore_stop() > would result in a service's "active on lcore" status becoming stale. > > The stale status would result in rte_service_may_be_active() always > returning "1", indiciating that the service is not certainly stopped. > > This is fixed by ensuring the "active on lcore" status of each service > is set to 0 when an lcore is stopped. > > Fixes: e30dd31847d2 ("service: add mechanism for quiescing") > Fixes: 8929de043eb4 ("service: retrieve lcore active state") > > Reported-by: S. V. Naga Harish > Signed-off-by: Harry van Haaren Applied, thanks.