From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 9F39232A5 for ; Sun, 20 Jan 2019 22:31:55 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 241672517E; Sun, 20 Jan 2019 16:31:55 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 20 Jan 2019 16:31:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=VQE7IQ6jQelbJiM3NngL48Evv50Y+Y1IQEsTi4x0Gc4=; b=JzqFqL4PWsjF R7NW/qBEBrcwTAqCxPA0vYCunQYO3yaqxydgk5LhM0tFp4rtM7h+UJKWh/jP8vHr CSLyw2co9cmhpzDXC3yRZq5Nq75+KLaQguMeAKBxxWbvONYMEiYk5x6FYpwQv2VU kIwzdd5TcQGOWicb9Be+dOvxMC0H3JE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=VQE7IQ6jQelbJiM3NngL48Evv50Y+Y1IQEsTi4x0G c4=; b=PLOdq5w7M+wKvMnu0KTpdigQfXASd9RvrTHAKicz0Cd33YiNqNVofmps6 QkkPXkWa07LLzb+N6cq1+dvdDVn/SeZZolfpEIalWr4y3fHFm7KjXV7HHjGEaWrP a6RIF8HbuFLKHovrWd3TaSY+Ht0d0xGfv6ulRTMtEiGJq3Dr89AAlDbNr20mOUGP rutr1Y49ZmzFZuM8gELowLWKjVCa3h0T7VAHt2KIyTE4IX3Qx6FhkkyGq8ZH/W1a 2kvJ3PNRytQiGEd4wjhwjQb+VUxH2JMrHKkOrxSNVjRWuTmOOufh9UnkQjT0sSWV zJx5VptMJNcYaPHbVBUQ+44Yvmegw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrheeggdduheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkjg hfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcu oehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtd efrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9EE4D10085; Sun, 20 Jan 2019 16:31:53 -0500 (EST) From: Thomas Monjalon To: Harman Kalra Cc: dev@dpdk.org, "remy.horton@intel.com" , "jerin.jacobkollanukkaran@cavium.com" Date: Sun, 20 Jan 2019 22:31:52 +0100 Message-ID: <3592747.moUssd9yEs@xps> In-Reply-To: <20181210083857.3158-1-hkalra@marvell.com> References: <20181206150106.154090-1-hkalra@marvell.com> <20181210083857.3158-1-hkalra@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] test/metrics: Fixed a negative case to pass X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jan 2019 21:31:55 -0000 10/12/2018 09:39, Harman Kalra: > Negative test case for passing invalid count size to > rte_metrics_update_values() will pass if count value > is any value greater than 1 because set size wrt to > key id 1 is 1 and passing 0 as no of values to be > updated will not hit the ERANGE check. > > Signed-off-by: Harman Kalra Adding comment from Remy: Fixes: cd3804242901 ("test/metrics: add unit tests for metrics library") Acked-by: Remy Horton Applied, thanks