From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7919DA04A3; Tue, 16 Jun 2020 10:29:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4F8AE1BEC7; Tue, 16 Jun 2020 10:29:12 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id D6AF41BEAF for ; Tue, 16 Jun 2020 10:29:10 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id CA2FA580210; Tue, 16 Jun 2020 04:29:09 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Tue, 16 Jun 2020 04:29:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= OuJip8F2SN+UXEIye5bT/e6j6Klic63kyIaBTrtJNAY=; b=aP6r0+f6HiiJgmtd pzKBQ1S3erQMVaaL0iBxdgaQJKkqich5WhAaFkN1+DGwOhLQ8T8IDMsW2LKfmW47 xx+To3BSIt0CZSs8lfTBJwJrMP2Gj+VLusgOL63LD6MvDRWAs7NWPl0qVuRwfKkh CcdDKIEFNqsSMnPZagONDNRULMh3mWSLxACU1mB8j+wfBsKNAVilRvzxUu6vPgZs ezONQyuwUhW9jymBT+ZFSWUeknErSfOwcrWag+fq0KWO37ihuADIYtsAZlczhiN6 7k/jLhP8kaQECmXgybXyPu2ZJl6fsFaL0HLpmo48EKqH8Hk+Qde3QdhPPKcGWbJI PFBdxA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=OuJip8F2SN+UXEIye5bT/e6j6Klic63kyIaBTrtJN AY=; b=vN55aYI8Df9uRHQQpa5Jggz4BU746RQ9gx9+FCgh+nlJctGE2e2MRVyQu 6/7zoMPM0DfUoKFnwE1gBuIEIWKkKQOs8Ih7dnY+umvSxIsJJXPpS1zFqr0Jr+tX o6vvgasAyowlBCjzxMJCKXh7OJq7a+oMNbSybZJYUVlKCzFWeWwIqQqtSwa+Z3CT H6OOyrjgc7OTaWxw8gQfNdTnAMKpX3rjnKNfihM3LFxU5RXDBJ1zut09uByTd7k5 0B/GNtfKW0PNvmQrWk9dOhmDBU1ads5qqjYYZTW0hcp67Z7+0+Pjkq4lFKUZrpkc BDHMIch8jcEP2VxP8ykdx+SYl7BEw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudejtddgtdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkjghfggfgtgesthfure dttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpedugefgvdefudfftdefge elgffhueekgfffhfeujedtteeutdejueeiiedvffegheenucfkphepjeejrddufeegrddv tdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E53073280059; Tue, 16 Jun 2020 04:29:07 -0400 (EDT) From: Thomas Monjalon To: bruce.richardson@intel.com Cc: dev@dpdk.org, pallavi.kadam@intel.com, dmitry.kozliuk@gmail.com, david.marchand@redhat.com, grive@u256.net, ranjit.menon@intel.com, navasile@linux.microsoft.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, anatoly.burakov@intel.com, talshn@mellanox.com Date: Tue, 16 Jun 2020 10:29:06 +0200 Message-ID: <3595548.sAZccUnRld@thomas> In-Reply-To: <20200609103139.22168-7-talshn@mellanox.com> References: <20200609103139.22168-1-talshn@mellanox.com> <20200609103139.22168-7-talshn@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 6/8] drivers: fix incorrect meson import folder for Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Bruce, please could you review this patch? 09/06/2020 12:31, talshn@mellanox.com: > From: Tal Shnaiderman > > import library (/IMPLIB) in meson.build should use > the 'drivers' and not 'libs' folder. > > The error is: fatal error LNK1149: output filename matches input filename. > The fix uses the correct folder. > > Fixes: 5ed3766981 ("drivers: process shared link dependencies as for libs") > > Signed-off-by: Tal Shnaiderman > --- > drivers/meson.build | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/drivers/meson.build b/drivers/meson.build > index a7eac86790..e216011d47 100644 > --- a/drivers/meson.build > +++ b/drivers/meson.build > @@ -153,7 +153,7 @@ foreach class:dpdk_driver_classes > version_map = '@0@/@1@/@2@_version.map'.format( > meson.current_source_dir(), > drv_path, lib_name) > - implib = dir_name + '.dll.a' > + implib = 'lib' + lib_name + '.dll.a' > > def_file = custom_target(lib_name + '_def', > command: [map_to_def_cmd, '@INPUT@', '@OUTPUT@'], > @@ -161,8 +161,12 @@ foreach class:dpdk_driver_classes > output: '@0@_exports.def'.format(lib_name)) > lk_deps = [version_map, def_file] > if is_windows > - lk_args = ['-Wl,/def:' + def_file.full_path(), > - '-Wl,/implib:lib\\' + implib] > + if is_ms_linker > + lk_args = ['-Wl,/def:' + def_file.full_path(), > + '-Wl,/implib:drivers\\' + implib] > + else > + lk_args = [] > + endif > else > lk_args = ['-Wl,--version-script=' + version_map] > # on unix systems check the output of the >