From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Alfredo Cardigliano <cardigliano@ntop.org>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 15/17] net/ionic: add stats
Date: Mon, 20 Jan 2020 12:10:36 +0000 [thread overview]
Message-ID: <35af7c65-ce53-e02a-3b84-f69635f3aa3f@intel.com> (raw)
In-Reply-To: <20200119155356.20403-16-cardigliano@ntop.org>
On 1/19/2020 3:53 PM, Alfredo Cardigliano wrote:
> Add basic, per queue and extended statistics for
> RX and TX, both from the adapter and the driver.
>
> Signed-off-by: Alfredo Cardigliano <cardigliano@ntop.org>
> Reviewed-by: Shannon Nelson <snelson@pensando.io>
<...>
> @@ -84,6 +84,153 @@ ionic_lif_reset(struct ionic_lif *lif)
> ionic_dev_cmd_wait_check(idev, IONIC_DEVCMD_TIMEOUT);
> }
>
> +static void
> +ionic_lif_get_abs_stats(struct ionic_lif *lif, struct rte_eth_stats *stats)
> +{
This is causing build error [1] becaues the provided 'lif' argument by
'ionic_lif_get_stats()' to this fucntion is const. I can fix this while merging
if this is the only issue.
[1]
.../drivers/net/ionic/ionic_lif.c: In function ‘ionic_lif_get_stats’:
.../drivers/net/ionic/ionic_lif.c:184:26: error: passing argument 1 of
‘ionic_lif_get_abs_stats’ discards ‘const’ qualifier from pointer target type
[-Werror=discarded-qualifiers]
184 | ionic_lif_get_abs_stats(lif, stats);
| ^~~
.../drivers/net/ionic/ionic_lif.c:88:43: note: expected ‘struct ionic_lif *’ but
argument is of type ‘const struct ionic_lif *’
88 | ionic_lif_get_abs_stats(struct ionic_lif *lif, struct rte_eth_stats *stats)
| ~~~~~~~~~~~~~~~~~~^~~
next prev parent reply other threads:[~2020-01-20 12:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-19 15:53 [dpdk-dev] [PATCH v5 00/17] Introduces net/ionic PMD Alfredo Cardigliano
2020-01-19 15:53 ` [dpdk-dev] [PATCH v5 01/17] net/ionic: add skeleton Alfredo Cardigliano
2020-01-19 15:53 ` [dpdk-dev] [PATCH v5 02/17] net/ionic: add hardware structures definitions Alfredo Cardigliano
2020-01-19 15:53 ` [dpdk-dev] [PATCH v5 03/17] net/ionic: add log Alfredo Cardigliano
2020-01-19 15:53 ` [dpdk-dev] [PATCH v5 04/17] net/ionic: register and initialize the adapter Alfredo Cardigliano
2020-01-19 15:53 ` [dpdk-dev] [PATCH v5 05/17] net/ionic: add port management commands Alfredo Cardigliano
2020-01-19 15:53 ` [dpdk-dev] [PATCH v5 06/17] net/ionic: add basic lif support Alfredo Cardigliano
2020-01-19 15:53 ` [dpdk-dev] [PATCH v5 07/17] net/ionic: add doorbells Alfredo Cardigliano
2020-01-19 15:53 ` [dpdk-dev] [PATCH v5 08/17] net/ionic: add adminq support Alfredo Cardigliano
2020-01-19 15:53 ` [dpdk-dev] [PATCH v5 09/17] net/ionic: add notifyq support Alfredo Cardigliano
2020-01-19 15:53 ` [dpdk-dev] [PATCH v5 10/17] net/ionic: add basic port operations Alfredo Cardigliano
2020-01-19 15:53 ` [dpdk-dev] [PATCH v5 11/17] net/ionic: add Rx filters support Alfredo Cardigliano
2020-01-20 16:57 ` Ferruh Yigit
2020-01-21 7:43 ` Raslan Darawsheh
2020-01-19 15:53 ` [dpdk-dev] [PATCH v5 12/17] net/ionic: add Flow Control support Alfredo Cardigliano
2020-01-19 15:53 ` [dpdk-dev] [PATCH v5 13/17] net/ionic: add Rx and Tx handling Alfredo Cardigliano
2020-01-19 15:53 ` [dpdk-dev] [PATCH v5 14/17] net/ionic: add RSS support Alfredo Cardigliano
2020-01-19 15:53 ` [dpdk-dev] [PATCH v5 15/17] net/ionic: add stats Alfredo Cardigliano
2020-01-20 12:10 ` Ferruh Yigit [this message]
2020-01-19 15:53 ` [dpdk-dev] [PATCH v5 16/17] net/ionic: add Tx checksum support Alfredo Cardigliano
2020-01-19 15:53 ` [dpdk-dev] [PATCH v5 17/17] net/ionic: read Fw version Alfredo Cardigliano
2020-01-20 13:05 ` [dpdk-dev] [PATCH v5 00/17] Introduces net/ionic PMD Ferruh Yigit
2020-01-20 13:38 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35af7c65-ce53-e02a-3b84-f69635f3aa3f@intel.com \
--to=ferruh.yigit@intel.com \
--cc=cardigliano@ntop.org \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).