From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 353362BAE for ; Mon, 11 Dec 2017 11:44:55 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2017 02:44:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,391,1508828400"; d="scan'208";a="1833345" Received: from dhunt5-mobl1.ger.corp.intel.com (HELO [10.237.220.36]) ([10.237.220.36]) by orsmga008.jf.intel.com with ESMTP; 11 Dec 2017 02:44:53 -0800 To: Marko Kovacevic , dev@dpdk.org References: <20171128132203.43181-1-marko.kovacevic@intel.com> <20171128132203.43181-2-marko.kovacevic@intel.com> From: "Hunt, David" Message-ID: <35d56aa1-3dc6-f6ee-0ab8-5ac02fb6c778@intel.com> Date: Mon, 11 Dec 2017 10:44:53 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20171128132203.43181-2-marko.kovacevic@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v2 2/4] power: clean up of acpi files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Dec 2017 10:44:56 -0000 Hi Marko, On 28/11/2017 1:22 PM, Marko Kovacevic wrote: > Signed-off-by: Marko Kovacevic > --- > lib/librte_power/Makefile | 2 +- > ...e_power_acpi_cpufreq.c => power_acpi_cpufreq.c} | 32 +++++++++++----------- > ...e_power_acpi_cpufreq.h => power_acpi_cpufreq.h} | 28 +++++++++---------- > lib/librte_power/rte_power.c | 28 +++++++++---------- > 4 files changed, 45 insertions(+), 45 deletions(-) > rename lib/librte_power/{rte_power_acpi_cpufreq.c => power_acpi_cpufreq.c} (94%) > rename lib/librte_power/{rte_power_acpi_cpufreq.h => power_acpi_cpufreq.h} (88%) > > diff --git a/lib/librte_power/Makefile b/lib/librte_power/Makefile > index 1b1491d..bf5a55e 100644 > --- a/lib/librte_power/Makefile > +++ b/lib/librte_power/Makefile > @@ -42,7 +42,7 @@ EXPORT_MAP := rte_power_version.map > LIBABIVER := 1 > > # all source are stored in SRCS-y > -SRCS-$(CONFIG_RTE_LIBRTE_POWER) := rte_power.c rte_power_acpi_cpufreq.c > +SRCS-$(CONFIG_RTE_LIBRTE_POWER) := rte_power.c power_acpi_cpufreq.c > SRCS-$(CONFIG_RTE_LIBRTE_POWER) += rte_power_kvm_vm.c guest_channel.c > > # install this header file > diff --git a/lib/librte_power/rte_power_acpi_cpufreq.c b/lib/librte_power/power_acpi_cpufreq.c > similarity index 94% > rename from lib/librte_power/rte_power_acpi_cpufreq.c > rename to lib/librte_power/power_acpi_cpufreq.c --snip-- Could I suggest adding the following to the commit message? "Rename private header file rte_power_acpi_cpufreq.c to power_acpi_cpufreq.c. This prevents the private functions from leaking into the documentation. Change any private functions from rte_ to just . Reserve the rte_ for public functions. " Regards, Dave.