From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6252F438E6; Wed, 17 Jan 2024 08:57:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 42B69402B0; Wed, 17 Jan 2024 08:57:33 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 7A2FA402A6 for ; Wed, 17 Jan 2024 08:57:31 +0100 (CET) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 7533D50; Wed, 17 Jan 2024 10:57:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 7533D50 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1705478250; bh=DpILnhRdQbwLENkJL78OsANuKomcRH8ZQyZucEuYrZ8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=aB/9nqdYxT4OP8fD8XONY6wy0evEXdnTYv9Xah1t469JHhveeDKsJyiRbDO789ZCJ caymsW/DMZ3mKeC8r4lnIhweKOV6p+1s1PqKaPMeDMPsDJ9kI4dnmxl9IF0TkcqFdK vWVlwlIYVU3AsvkcZZHr/9r/I1eCAlcOn3UbDqYM= Message-ID: <35da9efc-50df-4115-934d-50acfef0532e@oktetlabs.ru> Date: Wed, 17 Jan 2024 10:57:30 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/5] net/sfc: fix non-constant expression in RTE_BUILD_BUG_ON() Content-Language: en-US To: Stephen Hemminger , dev@dpdk.org Cc: ivan.malov@oktetlabs.ru, Tyler Retzlaff , Ivan Malov , Thomas Monjalon References: <20231111172153.57461-1-stephen@networkplumber.org> <20240116184307.162882-1-stephen@networkplumber.org> <20240116184307.162882-3-stephen@networkplumber.org> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: <20240116184307.162882-3-stephen@networkplumber.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/16/24 21:41, Stephen Hemminger wrote: > The macro RTE_MIN has some hidden assignments to provide type > safety which means the statement can not be fully evaluated in > first pass of compiler. Replace RTE_MIN() with equivalent macro. > > This will cause errors from checkpatch about multiple evaluations > of same expression in macro but it is ok in this case. > > Fixes: 4f936666d790 ("net/sfc: support TSO for EF100 native datapath") I'm not sure that it is really a fix. > Cc: ivan.malov@oktetlabs.ru > Signed-off-by: Stephen Hemminger > Acked-by: Tyler Retzlaff > --- > drivers/net/sfc/sfc_ef100_tx.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/sfc/sfc_ef100_tx.c b/drivers/net/sfc/sfc_ef100_tx.c > index 1b6374775f07..f4bcadc1e8e0 100644 > --- a/drivers/net/sfc/sfc_ef100_tx.c > +++ b/drivers/net/sfc/sfc_ef100_tx.c > @@ -26,6 +26,10 @@ > #include "sfc_ef100.h" > #include "sfc_nic_dma_dp.h" > > +#ifndef MIN > +/* not typesafe but is a constant */ > +#define MIN(x, y) ((x) < (y) ? (x) : (y)) > +#endif IMHO adding it in specific driver is a wrong direction. I'm afraid it will result in duplication of such macros in code base without clear reason why. May be it is better to add it with a proper name to EAL? > > #define sfc_ef100_tx_err(_txq, ...) \ > SFC_DP_LOG(SFC_KVARG_DATAPATH_EF100, ERR, &(_txq)->dp.dpq, __VA_ARGS__) > @@ -563,8 +567,7 @@ sfc_ef100_tx_pkt_descs_max(const struct rte_mbuf *m) > * (split into many Tx descriptors). > */ > RTE_BUILD_BUG_ON(SFC_EF100_TX_SEND_DESC_LEN_MAX < > - RTE_MIN((unsigned int)EFX_MAC_PDU_MAX, > - SFC_MBUF_SEG_LEN_MAX)); > + MIN((unsigned int)EFX_MAC_PDU_MAX, SFC_MBUF_SEG_LEN_MAX)); > } > > if (m->ol_flags & sfc_dp_mport_override) {