From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30375A00BE; Fri, 18 Feb 2022 17:59:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 06FD14014E; Fri, 18 Feb 2022 17:59:03 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 32E3240141 for ; Fri, 18 Feb 2022 17:59:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645203541; x=1676739541; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=FLi9vnWCk+4v5UETIOVXDSH+BziU0cjz/tpL5tTDfbs=; b=RMFCz38Qzf3RTLfhQEzn2CmTMn4KdiuArVqNLxFwruK3XjKyK+/6huLL cann3OSYsFXlYfmzSmH9HscXYCaO0093iUIOnQl/xVrk8ilaa5LM3Www0 x/76GjiXDwMXr5a4ZSo/D2uA+DmInTXbKImAaHrMXz7vMHySj1saGdR8C dq0YvzrqbhM4RhWB5lKqUIPM+XHW6F5j27427DJQ3UnYL2fxPdhuHzU0E fFYmK3NQwclnJgn0eRrIb1mMClEF51MgGwLVRP34y0MXIBudu2ZE9V9MX AoTdRkFLTtMObK0GrtH8XgO37at3Yjvq4cH8F7j4eCygphgz1R+cNCrHp w==; X-IronPort-AV: E=McAfee;i="6200,9189,10262"; a="234697004" X-IronPort-AV: E=Sophos;i="5.88,379,1635231600"; d="scan'208";a="234697004" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2022 08:59:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,379,1635231600"; d="scan'208";a="504059139" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga002.jf.intel.com with ESMTP; 18 Feb 2022 08:59:00 -0800 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 18 Feb 2022 08:58:59 -0800 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 18 Feb 2022 08:58:59 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 18 Feb 2022 08:58:59 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 18 Feb 2022 08:58:59 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CIBkj6OT+jmw4CFm9d6NmG0ZmVAIEQg76xJJvJ0ltn3Be5YIm4U7jbOtLi+F2BnzagZkWQgClBRoHRugRtNJZLKHouKvYJR2ck0Cjq4PABQG+MZXA0hqB11AXtajm/S8p1tukm4DXrE5eJRN+SouQz3X1oTvIpbnp19thDEBIT8jfTewu6o5CsYktV+M/gbU0aON2OBM6Ni2ZeJjt0mct/S23HEAyHkQCyGDIa50PIrV0dc7ycDNwRB36dNhbj55q+XYhV8tzDIErp9GMtTvPo/ZLkCxjAzCUv2q+Jq2BPqCRyZSqV1smnJRg2gvbdq3+u0QZfNIlUbSdx+UwFlFfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rNtp6u9cTfHrJKLoiBh73A5YjdPr5UikVFNuS12BVi8=; b=T5+Hp4TAtW4yVjW/AdNjoztQvRg//jDVgp9ypf/b9vdKuAahYEXI4R30XkyihIDHpwQFrmKSCLxqU0cFg0wh3ouMPSs0flKmEPL1ln8HqkGIVkAqwO6BW6WugEBZh9thmOGVecdfha/8CHgbFIcPy7Qh0emhOdNKGZwByu6EuAz/3XvbYCAE6RTt7h+qcOwPLUYz/WJ0wS4g3oivABrc8le8HZYN0LPL3t5GdJTjT+SE33Ab3TKIC8ZeaAyyo2kSTw/FjX0dGj62o48z8ZKMaC+JS6OWr0zMRuUWzjjYE2atmUDFNxuNINsL2eCM+L+Bb0tf8fcNcqBbRciyj4QyMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BN8PR11MB3618.namprd11.prod.outlook.com (2603:10b6:408:90::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Fri, 18 Feb 2022 16:58:54 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4995.024; Fri, 18 Feb 2022 16:58:54 +0000 Message-ID: <35f1a3db-5575-bb10-ca35-b440e86e4fa8@intel.com> Date: Fri, 18 Feb 2022 16:58:47 +0000 Content-Language: en-US To: , , , , , CC: References: <20220217101428.385751-1-wenxuanx.wu@intel.com> <20220217101428.385751-2-wenxuanx.wu@intel.com> From: Ferruh Yigit Subject: Re: [PATCH 1/2] app/testpmd: fix quit testpmd with vfs and pf X-User: ferruhy In-Reply-To: <20220217101428.385751-2-wenxuanx.wu@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0047.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ac::14) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: eb703223-01c5-456f-501a-08d9f2fff237 X-MS-TrafficTypeDiagnostic: BN8PR11MB3618:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1122; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qprfr6UxGOB4Sjlz7sxETqas4p7q6miHbvI0m8P+txfe7qjWWG+1XhBIYgygDVAj5bFAHwcqIGjjIooR1sBdIxcFFaJ4Ad+nhHDPwGiHi+E4gyBtOg5n601ado6CmqzubxAG+dQf9XTh1DZQToaALiclxXft0z+fgRpyLTLL8JvSLlEn3vv+6VCxy+34s+fIZ4EyADT2TuZH95KuoxHLftRPzjTn+jSADYHUCuT5wnJnZaTsuHwPlR3w0CPsBiicfONEfod42rZQsM/Wr2WFX0UmLE+2B6znEd7x7VUropSAtB/Kmes/p3wR0rLl5k1P4/Idmzx/7vRTl7Zq0DZJjSTLSiP/MoggA555BkOAfoeIN/O8HpCF0wM2rS6HwUDA+Co1tNKp+AogA5dcL9o4f5CFr0Rzx2NUiTHnPyGDJ4iQM57r0dJIxqq4MQnqeBBlEfp6CaiHEHTi3cYlKGTvoHl/bRmwvemanU2/rI6KSo48aqaPadUQZ0fXhO9I0mFrGzSbS19djHBdEt9Vjnd8xKTk0Y2C0gprHmVEAE3OmRsoGR8wI7aSFjukk2yhkVYGTFDSR1ys2zRU2VpcpQx8kwFERcr1O8+mO9FGs1Asxdkk5Y+OJcenIlgiqC0Bm1suD/yjnlgzko/9/T1GduNqQny27j1JJqaJ3OsJuDQuuUwvfFU26iMMcQnlztklIkjWpClVwemodWiP7zFjNoa/vw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(2616005)(186003)(26005)(31686004)(53546011)(6666004)(6512007)(6506007)(508600001)(6636002)(316002)(36756003)(6486002)(8936002)(44832011)(2906002)(66946007)(82960400001)(83380400001)(86362001)(66476007)(66556008)(8676002)(38100700002)(4326008)(31696002)(5660300002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ckNZbDJxaS9oNFhxeVpVNVd2S21wTFdJYS82b1FxUXZzd2VMTHJIZElYLzlU?= =?utf-8?B?SVd3TmNyTVJCaUp3TFdadWxhT284cG1mRWJPdUxYb2RtcEF0VGdQcXBGb1B2?= =?utf-8?B?d2xzdDdMWUN4eU14SnY0a0JMU0dlOCtYVFdTbU54QWRPNUZmUmZFRHNaL0Nx?= =?utf-8?B?c2FzdHovdTdnZUtSZ29HTks3SEtseG5uTlVOZUJVTWREaXVaVUpmbTljY1Br?= =?utf-8?B?TEtmM3lsNjFPTWRPTVdkUkdhQWZjcFgzZUpQNDc4UHJ4M0crL01KN2ZNRXlt?= =?utf-8?B?RmJCdll0ZUZhOTdaK05INGpWWjA0azhiR3ZWS2ZIQkU2T3IzWndSODF5cWQ0?= =?utf-8?B?bVdvdXdnNVdPWXZPU1pGZzJUYzJDRENEc01yUDY3Q2lRWm92Vm1RWWljVnhr?= =?utf-8?B?emZRb0RJOFpiL3NVVnhVVXJkUTJaR1poK3BUQ3pXNFlYZ2RaeHBSUktMS004?= =?utf-8?B?V1R1Ry8yQzhESXNXZVI3Q2t4K096QnNrVnVnYmlsZEZsYVFheHlEMWpQSHMz?= =?utf-8?B?TTFqWGwyY3lsd0RWOWJ5UUloVTdWWTJMMDVOcW1ERlcrZElva05NV0dJNVRC?= =?utf-8?B?TFg1SDlNSlE4clVzUFlVWnZ4cUtwbDdkMVNZSmZWWTZzTmw5RXhXM1EyTGd5?= =?utf-8?B?NzF2NlNZb0xaOTdpb01OQngxTmNVREUyVHordjVsSkEvQlFxVDUrRTVlSXFv?= =?utf-8?B?MklqTFFxNzdlSzBzVWRKcFozWE9jU21yYWJscHVFUGlvTEhEaS9MZ0Q4b1VD?= =?utf-8?B?czcxb05OUUtmT21IeHpKcW5zR3ZlNnZWZHJqTEVBMHBwVTdQVkZYd1d0VU94?= =?utf-8?B?R1Fka2c0RmFLczZJYmV3UU13SFJROWgvTzZ3OW9tcGkwa3hEYktvYmM1b084?= =?utf-8?B?b01hZGc1R01DMlVBcUI2dkZGanIyREVRUmN4eFM1dm1BYnRZejU3ZHQrM1M4?= =?utf-8?B?SWtiUVcxS1RGS3o2bnQveTFwWFFLS1ZsWE5GK0VQWUx6VmdEWVg0NmR2V3FU?= =?utf-8?B?Qmd1Q2JVT0lrenhLSWcyQm5uNGxZRDg3U3pYRWVtZG1tOUFRQ3p3OFlwbU9x?= =?utf-8?B?MUNGMGlCUnMvejNQZkR0bUVhRXJtTGR5aFBxZTNtd3J5TWRSRnR3SFZGL3B4?= =?utf-8?B?Qk5YbkdidlJNZU1EUDhNQmpNa1RCc3VoY1RXa2xGUytMVTlYZHErc1JRaWZ1?= =?utf-8?B?eFlMUGNKNkQ4Z1YrSnBIOElWRTduNzk2T3JLMWc5YTlXcUFRckNBMWk3ZW05?= =?utf-8?B?NGs0L1ZMWXA2M2lxeERSRE1yL3YzUDZFNEtZWDRQbUcydC95YW8vZ2J1bUVM?= =?utf-8?B?c2txTy95SDhGWEFGV2tWTW41UWRDdUl1SVRtRkZsVHI4RkpxTmgzd2Q2MFlC?= =?utf-8?B?ZEFoc0Q4OGZRUFZMemhRUlpOMU1lNisxODJKbjVmTmVIbFZickhoRGoxdkxz?= =?utf-8?B?Wms3a2ZGeU8xOXAzN3JwMTJFM0VCSm1BblQvcFNpZk45WDNoblhVWWZnSTdo?= =?utf-8?B?M0JBdGNKWndQVVN5S3ZiTXZ3L1EyQVIwWWFyRnU2TjVyWm0wY2ZZUFROZ3gw?= =?utf-8?B?dFV2Q0ZKaFREWTJycHRFQUxkZWU0YU9hVnRERWtPWnFzSWpCWVUwWjlMcVVh?= =?utf-8?B?ak5NV05tQmNQTjlvNFV2eDE4MXZXQXhZM2oraWlQR3NrVks1dkVIRW1kWll1?= =?utf-8?B?V2FZaVlQTDgvSGh5QVYrdVlST1BnNWFSTXV6UzJNcDZYa3hTaWdBMHAraHdl?= =?utf-8?B?VmpxZ2htMUNtUHJzVzJGZnlRY0FkVlQ0ZS82QVhlRUl1c052aE1WSEV5QUFC?= =?utf-8?B?S0Yzb0Z6eUhTeEI1aTl6eUcweXVaRlQvU2Y5UmJSN2I4Qm5veUJpdWxzeFln?= =?utf-8?B?RGJZWEFNb3hHZDJWdUpiWGROaXAvRlhyNE5kVVNmTW03ZTMycHRJWnp5dHVF?= =?utf-8?B?VFRXSExsanQyTHQ1bk5ZNldVdUpUb2o3TnJVaHhHOUF2K0RxY1dCdWU4QjJq?= =?utf-8?B?QTBkc0R2Y3FCYWkvajYyd3hNdWNpZkZZcVBiZ1NIVHk4eDhtNTZzZ1kzKzd3?= =?utf-8?B?MWRvOEdTWDZUZHpBUEJsbWNxdmd2S0xOeHlkbysrN0xIMXBOQ2xzdERHRXZ6?= =?utf-8?B?WUQyd05lRVI5NDFYNnp5bDdWRmJYQ1dXWFdtZnVJa0Z1UFNod21sQ08yZ1dh?= =?utf-8?Q?hbIjnDYI+kntj918Uv+xkqY=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: eb703223-01c5-456f-501a-08d9f2fff237 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2022 16:58:54.7211 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Sg7JPcGdLKDcKUabgBlVhcMjoZ2DlrFjV3lVEhiprF2YOdr1b9SXHWzHJ1hRSdoYY18Mm0XogLovDhaRBW4jYA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3618 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/17/2022 10:14 AM, wenxuanx.wu@intel.com wrote: > From: wenxuan wu > > When testpmd startups with pf and vfs,this error occurs when quitting, > results in pf is released before vfs ,so the vf would access an > freed heap memory. > > The solution is that release our allocated ports in reverse > order,add two macros RTE_ETH_FOREACH_DEV_REVERSE_OWNED_BY and > RTE_ETH_FOREACH_DEV_REVERSE,which would be used in quit procedure of > testpmd, error is fixed. > > Fixes: d3a274ce9dee ("app/testpmd: handle SIGINT and SIGTERM") > Cc: stable@dpdk.org > > Signed-off-by: wenxuan wu > --- > app/test-pmd/testpmd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index e1da961311..698b6d8cc4 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -3384,12 +3384,12 @@ pmd_test_exit(void) > #endif > if (ports != NULL) { > no_link_check = 1; > - RTE_ETH_FOREACH_DEV(pt_id) { > + RTE_ETH_FOREACH_DEV_REVERSE(pt_id) { This fix assumes PF is always probed before VFs (so PF has smaller port id than VF). I am not sure if this is guaranteed, ports ported based on scan in the sysfs folder. Instead, what do you think PF port stop/close fail when there are still VFs probed? I think PF driver can know if there are VFs ported. > printf("\nStopping port %d...\n", pt_id); > fflush(stdout); > stop_port(pt_id); > } > - RTE_ETH_FOREACH_DEV(pt_id) { > + RTE_ETH_FOREACH_DEV_REVERSE(pt_id) { > printf("\nShutting down port %d...\n", pt_id); > fflush(stdout); > close_port(pt_id);