From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D57FCA0563; Wed, 15 Apr 2020 23:48:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ADD551DA28; Wed, 15 Apr 2020 23:48:39 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 253681DA0F for ; Wed, 15 Apr 2020 23:48:38 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 4156C5C00C0; Wed, 15 Apr 2020 17:48:37 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 15 Apr 2020 17:48:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=48z3Ln5tSyeuA85Pl9GH+bTBMosKnV0UFgthJD9LEUg=; b=cmRUUb/YDztL yq38NazGDIkIcx76154pmy0wOTjcnH2ahtn3CwlTSiqXfcC1I2aqSsucT6P8Kf2Z h5BQHcesHaKXUbQGO5eg1zC2BAEjr73ZHc0zwrvDYxrBWO2lQ2+YBmYa90kUsaUF IgjzPiV9K3HK4Z4lwLj9RQLl4Bn+5SM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=48z3Ln5tSyeuA85Pl9GH+bTBMosKnV0UFgthJD9LE Ug=; b=VIk9lnAfVmTxvGbSppCG0CM6qNhFwJ1abA4zMOxVJhgGm8MbFCz24klVa yJ2D+MFi6fzNKV359V5n/LkV3jwL0j0gTWuhjmJvaByG6/nSRk0r0ektUzR8hZZL kSbUSj7HVIIdYISK8mHDIUr+sOedb1A1HT4LWaPZOnSnINLjj2foWrCY2gAEMRoU ALHkfaMrJiuOuZK9E+rIWmaSO+tuAiaZbaL0ajRATmq9QsYKuEgouHvCkzZEdXg8 0RVLeDQGX/+dEBG8PufhyxIhtsxAFEYCoKm8JIeSGIf6rwT4GmeAzUlnz/B1qrmz 6JAexWSvJrHr7lWbbwV87YPulqD4A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrfeeggddtvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 78FAB3280063; Wed, 15 Apr 2020 17:48:35 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: dev@dpdk.org, "Dmitry Malloy (MESHCHANINOV)" , Narcisa Ana Maria Vasile , Fady Bader , Tal Shnaiderman , Harini Ramakrishnan , Omar Cardona , Pallavi Kadam , Ranjit Menon Date: Wed, 15 Apr 2020 23:48:33 +0200 Message-ID: <3603845.ECZNHGQPT7@thomas> In-Reply-To: <20200414194426.1640704-6-dmitry.kozliuk@gmail.com> References: <20200410164342.1194634-1-dmitry.kozliuk@gmail.com> <20200414194426.1640704-1-dmitry.kozliuk@gmail.com> <20200414194426.1640704-6-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 05/10] eal: introduce internal wrappers for file operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks for starting the new directory for Unix common implementation. 14/04/2020 21:44, Dmitry Kozlyuk: > --- /dev/null > +++ b/lib/librte_eal/unix/eal.c Please take care of not creating a new file without adding SPDX tag and copyright owner. > @@ -0,0 +1,47 @@ > +#include > +#include > +#include > + > +#include > + > +#include "eal_private.h" > + > +int > +eal_file_truncate(int fd, ssize_t size) [...] > +int > +eal_file_lock(int fd, enum eal_flock_op op, enum eal_flock_mode mode) +1 Adding new abstractions is the way to go in my opinion. Thanks