From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E9E2439A6; Tue, 23 Jan 2024 10:42:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF66C402C5; Tue, 23 Jan 2024 10:42:46 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id B8A9E402BD for ; Tue, 23 Jan 2024 10:42:44 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 54E0D5C0245; Tue, 23 Jan 2024 04:42:44 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 23 Jan 2024 04:42:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1706002964; x=1706089364; bh=ClcWb8HSOTtB2qcwYLnpwxzkmRAUhGZIUHM2Ny46ZwA=; b= SbXCxEBJX3hG7ub0kxnDg0RteILcAG8gLUhrQKH+nf+wVXJq8fOO//E4khSxfg1n OtMvpD9B8DJNBkvck7MtiFuCrhiwi9HbDshkJs/RBjVQfiRAxExRkEWJm0az3SQ7 /88fwjae2x3sCBP0SDuFMbO/onQDYHzQz1OMVG3mT/ibuo7TlSJxVJ9J+OzpRg7s CRtePnLYCkpVbEz0jHv728XByGyCPkfm9AgSHq49kK5Td2Vuw0lN8A0M2CBVKpRe ywkyWBcYETdBpMAHtC8Qf/nSpRZBjMmtKn3hiYBL+hmyFUfkog6MFMs4CLuIamxc Q1wnLhW1EE9O4S8ZHzJywA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1706002964; x= 1706089364; bh=ClcWb8HSOTtB2qcwYLnpwxzkmRAUhGZIUHM2Ny46ZwA=; b=Z xfFd+v3V3N7pjY9OwbjHfsGY/MgCcN8FT5XGufpKVBpGumGVXuPd01b5CxPLEtzb Z6+6iBh+22Tkz2M/CXacyt9hVld847m8iylal62NjhVoKYZPd2gP3fVKit4oLXCD QSI07CGmZATC1oOd0DoBiRHW2fbiJf0k7pYxVS3l7FGSen+c1S8KPieISV3UiQHS CdVDj22Fv4/Z7rQYFTYPf6PpXa+OIt/3AoqaF6bMd4XZCqMEwsBemw1sN8klMtjB uPGGJzXUg9RUAfyawSbzFPNUzlcEasdxBDPWMdndWN/edMDeS3qFnBz1WvWHFmOh vzYd17hQs+H1s/nhtEwog== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdekkedgtdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 23 Jan 2024 04:42:43 -0500 (EST) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, Hemant Agrawal , Sachin Saxena Subject: Re: [PATCH v5 10/10] common/dpaxx: replace zero length array Date: Tue, 23 Jan 2024 10:42:41 +0100 Message-ID: <3605729.LM0AJKV5NW@thomas> In-Reply-To: <20231129024221.57653-11-stephen@networkplumber.org> References: <20230113215205.125767-1-stephen@networkplumber.org> <20231129024221.57653-1-stephen@networkplumber.org> <20231129024221.57653-11-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 29/11/2023 03:39, Stephen Hemminger: > + * Ip header must follow directly after ipsec_encap_pdb [...] > + > + /* ip header if any follows the encap_pdb */ [...] > + /* ip header if any follows the encap_pdb */ I would change "ip" to "IP".