From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7528D42E9D; Mon, 17 Jul 2023 17:07:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B7D340DFD; Mon, 17 Jul 2023 17:07:35 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 8926740A80 for ; Mon, 17 Jul 2023 17:07:33 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 04C195C00BB; Mon, 17 Jul 2023 11:07:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 17 Jul 2023 11:07:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1689606450; x=1689692850; bh=NquiSMaT42Vb9K81FDfLfQS4zsvdSor6yrq caPuKp2I=; b=enS2p5qQK7WUxICdemz48Tva/av0aWbBAZunRlmdgdJMm9/Tl9S wd2draoN1ClEDurDse1IdokEgIEqVGPgONWKO54/BhidVOHPk8HFd9ryGr5ZvKpV 9668Ve/pmsNh6udAqpZB+1ACd+lf5ANnhjTU4aufwAj4g9iCqAqIqMhsivKz+raA ytzxd/UlQsP6mQzbxlLVYQqUw1GJcegYiIb2UFngiFSiafntlT053GWQFBIywNZ+ HQW/Jp43kvh+zmoD8eXX/asGxmWfP85uvcSJfv8qOlWbidlPxG5OkafLqzko9WLF ZA6KZlck99h0oqiyte50OF8zm/l2SPibpWg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1689606450; x=1689692850; bh=NquiSMaT42Vb9K81FDfLfQS4zsvdSor6yrq caPuKp2I=; b=llFXNHtkx03VpfjifE1ytAHAvsCNxbknGnNmOLK5yR2T3Wp0db2 czma6CaeMKhH87OuQlFon+PhPvdG5B6dRVH1/C0bM+45A5TbYSV7NPPq940KvOAG Y0OcSApBZ+zyRNwPxWf64S3oD5IIIX/CyfdEowX7Pgxsvv/B4foIyug9NeP5C68M 62T6G4lQSiuqKu2tUCnkNlmWj0EC8gcXHap3SyB5q6uy+KlDeQdcM+NpXcnLa4Qu Eh+oECuKUMfDhq62anDyKK9K9SxaYurejIP9Par4mHhisCErCEcqndf1S4NrUup7 bxORptqEywm50mNIQg0PsjX65kJlK5YKuPA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrgedvgdekgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 17 Jul 2023 11:07:29 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger , "Varghese, Vipin" Cc: "david.marchand@redhat.com" , "Tummala, Sivaprasad" , "dev@dpdk.org" Subject: Re: [PATCH] usertools: enhance logic to display NUMA Date: Mon, 17 Jul 2023 17:07:27 +0200 Message-ID: <3607087.o0KrE1Onz3@thomas> In-Reply-To: References: <20220326073207.489694-1-vipin.varghese@amd.com> <3292577.7s5MMGUR32@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 14/07/2023 11:14, Varghese, Vipin: > From: Thomas Monjalon > > 11/07/2023 17:42, Stephen Hemminger: > > > On Sat, 26 Mar 2022 00:32:07 -0700 > > > Vipin Varghese wrote: > > > > > > > + > > > > + output = " Socket " + str(socket).ljust(3, ' ') + " Numa " + > > str(numa).zfill(1) + " " > > > > + #output = " Socket " + str(socket).zfill(1) + " Numa " + str(numa).zfill(1) + > > " " > > > > + print(output) > > > > + print(format("-" * len(output))) > > > > + > > > > + for index,coreSibling in enumerate(numa_map[keys]): > > > > + print ("Core " + str(index).ljust(3, ' ') + " " + str(coreSibling)) > > > > + #print ("Core " + str(index).zfill(3) + " " + str(coreSibling)) > > > > +print("") > > > > + > > > > > > Git complains because you added new blank line at end of file. > > > > > > One wording suggestion would be to use the term "Node" instead of > > "Numa" in the table. > > > And fix heading alignment. The new headings don't look right. > > > > > > For the case with only single socket, single node, some of the > > > headings could be dropped as well. > > > > I don't understand why we continue working on this script. > > I thought we agreed it should be removed in favor of lstopo. > > > > Sorry Thomas, I did not follow your ` I don't understand why we continue working on this script. I thought we agreed it should be removed in favor of lstopo.` > > From last email from my end `we should promote and document the changes provided the existing tool is phased out and use lstopo`. > > Note: > 1. This is with assumption that both Linux and Windows `lstopo` is modified and handles `ACPI L3 SRAT NUMA` and `Node per Socket NUMA`. > 2. I have not seen a depreciation notice for cpu_layout.py too. My take is that we should stop working on this script. It is better to contribute to lstopo. Did you try? We probably won't deprecate cpu_layout.py easily. The first step would be to add a message when running the script, recommending to use lstopo. Vipin would you like to write such a patch?