From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com
 [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 6B01DC4C2
 for <dev@dpdk.org>; Wed, 17 Jun 2015 19:03:23 +0200 (CEST)
Received: by wiwd19 with SMTP id d19so139991807wiw.0
 for <dev@dpdk.org>; Wed, 17 Jun 2015 10:03:23 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=iS9IvNQOjNXso+JvmcbCVN6jzp6qRdTjBoT4FlrEHP8=;
 b=IVCcQXakV9tyA1d68KUwTdZKdhvCACPLN0o2jaRj2VulmXOPFhbJuEWKTdQsqqnavX
 gyp/BkzNkel3Eqsjenx57YO2aHoppSD7o1V1EBcBDhE0K8Wv0qv+2RNnVhPLx+rpkwps
 mi4/a4dBv/5+DP6shoiCNiO2LeQQfIPSdvfJRvnDLQ4BuYcgbDZs/tlqK1q+CLIXEQkd
 7gEJAsDTRD/cvUK92hz/9JfNryRcu85KSe0OWnjBEla9Dg0egZkP9GLkR3XOXCQwDHJA
 AOpO5wRASUgWPwJ7gVJdwphAbOvBjJRwdIByj4fK07RPVeO23uaczUuyQ2Pmic9tep7W
 i99g==
X-Gm-Message-State: ALoCoQlLIpBMl1+9XHgHlhIFbnoIuyCLbpXpRzs5PLGEj/JIN4WUdhEgiIn67svYZ77uJYnBBICz
X-Received: by 10.194.121.100 with SMTP id lj4mr7609576wjb.104.1434560603166; 
 Wed, 17 Jun 2015 10:03:23 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id pf4sm7763846wjb.23.2015.06.17.10.03.21
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 17 Jun 2015 10:03:22 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Huawei Xie <huawei.xie@intel.com>, Tommy Long <thomas.long@intel.com>
Date: Wed, 17 Jun 2015 19:02:22 +0200
Message-ID: <3608606.ARMOZ1d8vj@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <4795082.KHkHrmv5EW@xps13>
References: <1432778661-25428-1-git-send-email-huawei.xie@intel.com>
 <1433474005-597-3-git-send-email-huawei.xie@intel.com>
 <4795082.KHkHrmv5EW@xps13>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/2] vhost: realloc virtio_net and virtqueue
	to the same node of vring desc table
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Jun 2015 17:03:23 -0000

2015-06-17 18:47, Thomas Monjalon:
> 2015-06-05 11:13, Huawei Xie:
> > --- a/mk/rte.app.mk
> > +++ b/mk/rte.app.mk
> > @@ -92,6 +92,9 @@ endif # ! CONFIG_RTE_BUILD_COMBINE_LIBS
> > =20
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_PCAP)       +=3D -lpcap
> > =20
> > +ifeq ($(CONFIG_RTE_LIBRTE_VHOST_NUMA),y)
> > +_LDLIBS-$(CONFIG_RTE_LIBRTE_VHOST)          +=3D -lnuma
> > +
> >  ifeq ($(CONFIG_RTE_LIBRTE_VHOST_USER),n)
> >  _LDLIBS-$(CONFIG_RTE_LIBRTE_VHOST)          +=3D -lfuse
> >  endif
>=20
> An endif is missing.

After adding the endif and enabling the NUMA option, these errors appea=
r:

lib/librte_vhost/virtio-net.c:535:21: error: =E2=80=98new_vq=E2=80=99 m=
ay be used uninitialized in this function
lib/librte_vhost/virtio-net.c:547:63: error: =E2=80=98new_ll_dev=E2=80=99=
 may be used uninitialized in this function

Tommy,
I won't review the code, but given it doesn't build, I can guess how it=
 has
been reviewed.
Acked-by line is valuable only if the review is carefully done.

This patch series go back to lowest merge priority.