* [dpdk-dev] [PATCH] bus/vmbus: use SMP memory barrier for signaling read
@ 2020-07-17 20:18 Long Li
2020-07-29 14:11 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Long Li @ 2020-07-17 20:18 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev, Long Li
From: Long Li <longli@microsoft.com>
rte_smp_mb() uses the same locked ADD as the in-kernel vmbus driver,
and it has slightly performance improvement over rte_mb().
Signed-off-by: Long Li <longli@microsoft.com>
---
drivers/bus/vmbus/vmbus_channel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/vmbus/vmbus_channel.c b/drivers/bus/vmbus/vmbus_channel.c
index aaa801d88..c60470332 100644
--- a/drivers/bus/vmbus/vmbus_channel.c
+++ b/drivers/bus/vmbus/vmbus_channel.c
@@ -214,7 +214,7 @@ void rte_vmbus_chan_signal_read(struct vmbus_channel *chan, uint32_t bytes_read)
return;
/* Make sure reading of pending happens after new read index */
- rte_mb();
+ rte_smp_mb();
pending_sz = rbr->vbr->pending_send;
if (!pending_sz)
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] bus/vmbus: use SMP memory barrier for signaling read
2020-07-17 20:18 [dpdk-dev] [PATCH] bus/vmbus: use SMP memory barrier for signaling read Long Li
@ 2020-07-29 14:11 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2020-07-29 14:11 UTC (permalink / raw)
To: Long Li; +Cc: Stephen Hemminger, dev, Long Li
17/07/2020 22:18, Long Li:
> From: Long Li <longli@microsoft.com>
>
> rte_smp_mb() uses the same locked ADD as the in-kernel vmbus driver,
> and it has slightly performance improvement over rte_mb().
>
> Signed-off-by: Long Li <longli@microsoft.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-29 14:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-17 20:18 [dpdk-dev] [PATCH] bus/vmbus: use SMP memory barrier for signaling read Long Li
2020-07-29 14:11 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).