From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id C69315F72 for ; Wed, 25 Apr 2018 12:06:16 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3DFC921B55; Wed, 25 Apr 2018 06:06:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 25 Apr 2018 06:06:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=rCoOD7/yeeZs1rqoZ24MrQci9u NE+YLevKR0F7rpAUY=; b=pyifYyWHevcc0/Wynsggwr2kEqoJZ+OnckdR50PRrN 8b+oceNR2jnJhe2AqGR1drF+mN4cnNWF2LtJwg4c8APZcsdYz4Xz0Yh2JH+bgD98 8r+Oa1EDzGBrELAxIMpl9ncZffrOzBYd7N3lQXaBl6PNi5sXhpHjyGO0+x+lXoKu 4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=rCoOD7 /yeeZs1rqoZ24MrQci9uNE+YLevKR0F7rpAUY=; b=IeWwuSpU2e61LBvpiNAyx9 TMOAaotekHc6tUdwik8cQzxRLAFHg4cEZxk0HPgF70VkBrUXEOq4xO9Mssk0HwSd Gj95exG8N+Ht2b31UYJ5EOte2xQAiKqW1QV8yCiCekd5MZwl0cKZYozOTiwrJCrj mf53S9RvogR+7XNc8/LtQ8+oWi1hAvMuJQ9qsLa/+OffYiJAI8TGuaDqz8OoXJwM nfDOIpdK3jHTnTLydBFZiVTmqFysJSpS+DWLR1VgYLODOBDrGKexaqksaAZJYrfA jsWiLO+1MxAFRKF57evFInq7P4/WaVFpQmpoAfBCw5wTRpRjiNA91RQpfVHDmtsw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4035CE4120; Wed, 25 Apr 2018 06:06:15 -0400 (EDT) From: Thomas Monjalon To: Remy Horton Cc: Declan Doherty , dev@dpdk.org, Adrien Mazarguil , Ferruh Yigit , Shahaf Shuler Date: Wed, 25 Apr 2018 12:06:13 +0200 Message-ID: <3613685.kkaEeRXftQ@xps> In-Reply-To: <76bc7493-f8cf-0d74-961c-800665744ebe@intel.com> References: <20180328135433.20203-1-declan.doherty@intel.com> <1794949.DGStqB9iLD@xps> <76bc7493-f8cf-0d74-961c-800665744ebe@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 6/9] ethdev: add common devargs parser X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 10:06:17 -0000 25/04/2018 11:40, Remy Horton: > > On 24/04/2018 20:53, Thomas Monjalon wrote: > [..] > > But I would like to review the devargs you are standardizing. > > Unfortunately, I cannot find a documentation about it. > > How users are supposed to use it? > > Can you, at least, describe the syntax in the commit log, please? > > The patch follows this pseudo-BNF: > > cfg := pair (',' pair)* > pair := (key '=' value) > key := 'port' | 'representor' > value := range | list > range := int ('-' int)? > int := [0-9]+ > list := '[' range (',' range)* ']' OK Please can you add it as a comment in the parsing code? We will need one or two examples in the commit message too. Can you show a complete command line please? How do you give ethdev properties without the new devargs syntax (in progress by Gaetan)?