From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 3BDD4A09E4;
	Fri, 29 Jan 2021 11:47:06 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id BEF33240134;
	Fri, 29 Jan 2021 11:47:05 +0100 (CET)
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by mails.dpdk.org (Postfix) with ESMTP id A3B6140694;
 Fri, 29 Jan 2021 11:47:03 +0100 (CET)
IronPort-SDR: jg93IhL+1w423qvL6v7C3IHzxcOZY3G8AISk/1Ztt1BR8igHeo5/26WMazF/WqVrxsyu1IFes4
 +ojXZTsgarlQ==
X-IronPort-AV: E=McAfee;i="6000,8403,9878"; a="180479560"
X-IronPort-AV: E=Sophos;i="5.79,385,1602572400"; d="scan'208";a="180479560"
Received: from orsmga008.jf.intel.com ([10.7.209.65])
 by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 29 Jan 2021 02:47:01 -0800
IronPort-SDR: D+iRUlYLGpqWk414IdqaYuQn1l1+yUfXPkILIeYEXnuNw8O3LbEI0SgwEEYzKNVRJ6CcTvsieJ
 /nSOj8doUqIQ==
X-IronPort-AV: E=Sophos;i="5.79,385,1602572400"; d="scan'208";a="389251838"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.197.204])
 ([10.213.197.204])
 by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 29 Jan 2021 02:46:58 -0800
To: "Li, Xiaoyun" <xiaoyun.li@intel.com>, "Yu, DapengX"
 <dapengx.yu@intel.com>, "Xing, Beilei" <beilei.xing@intel.com>,
 "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
 "Iremonger, Bernard" <bernard.iremonger@intel.com>,
 "stephen@networkplumber.org" <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
References: <20201224035748.67012-1-dapengx.yu@intel.com>
 <20210125032953.430840-1-dapengx.yu@intel.com>
 <CY4PR11MB175014EA4024C26925443AD599BC9@CY4PR11MB1750.namprd11.prod.outlook.com>
 <52b41559f08f4344ae0864e3b67eb030@intel.com>
 <CY4PR11MB17502D630BC3A76CC494B3AF99BC9@CY4PR11MB1750.namprd11.prod.outlook.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <36157bf7-1bad-43e3-7b87-d2c0ea0e7e48@intel.com>
Date: Fri, 29 Jan 2021 10:46:55 +0000
MIME-Version: 1.0
In-Reply-To: <CY4PR11MB17502D630BC3A76CC494B3AF99BC9@CY4PR11MB1750.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] app/testpmd: avoid exit
 without terminal restore
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/26/2021 8:24 AM, Li, Xiaoyun wrote:

<...>

>>>
>>> From: Dapeng Yu <dapengx.yu@intel.com>
>>>
>>> In interactive mode, if testpmd exit by calling rte_exit without
>>> restore terminal attributes, terminal will not echo keyboard input.
>>>
>>> register a function with atexit() in prompt(), when exit() in
>>> rte_exit() is called, the registered function restores terminal attributes.
>>>
>>> Fixes: 5a8fb55c48ab ("app/testpmd: support unidirectional
>>> configuration")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>
 >
> Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
> 
Applied to dpdk-next-net/main, thanks.