From: "Ergin, Mesut A" <mesut.a.ergin@intel.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [dpdk-dev] [PATCH 2/3] net/i40e: add runtime option to disable vector rx
Date: Thu, 23 May 2019 17:54:27 +0000 [thread overview]
Message-ID: <3615B82CA151CF42A86EDDD9846A8B38C7A8C36F@ORSMSX112.amr.corp.intel.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB9772580161636EF4@irsmsx105.ger.corp.intel.com>
> > > > > If you plan to use FD mode on your device, why not enable it
> > > > > at setup phase via rte_eth_dev_configure()?
> > > > > Then proper rx function would be selected.
> > > > >
> > > >
> > > > FDIR_MODE was designed to bind late automatically -- it is set when the
> first
> > > > filter rule is parsed, and unset when the last rule is removed.
> > >
> > > Why is that, if you can define it at configuration stage, and RX function
> > > selection is based on it?
> >
> > I don't know why it was designed that way -- maybe maintainers know the
> > historical context.
>
> What I am trying to say - if particular feature (FD) enablement/disablement
> affects RX/TX function selection, then there should be an ability to
> enable/disable
> that feature at configuration state (dev_config/queue_setup).
> Function to change value of that feature at runtime (after
> dev_start/queue_start)
> should return an error if new value can't be supported with already selected
> RX/TX
> function.
> If that's is not the case, then it sounds like a bug/gap in i40e driver that needs to
> be fixed.
Will send a fix for that shortly.
next prev parent reply other threads:[~2019-05-23 17:54 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 4:28 [dpdk-dev] [PATCH 0/3] net/i40e: improve rte_flow offload with MARK + RSS Mesut Ali Ergin
2019-05-16 4:28 ` Mesut Ali Ergin
2019-05-16 4:28 ` [dpdk-dev] [PATCH 1/3] net/i40e: add support for MARK + RSS action in rte_flow Mesut Ali Ergin
2019-05-16 4:28 ` Mesut Ali Ergin
2019-05-22 12:30 ` Zhang, Qi Z
2019-05-16 4:28 ` [dpdk-dev] [PATCH 2/3] net/i40e: add runtime option to disable vector rx Mesut Ali Ergin
2019-05-16 4:28 ` Mesut Ali Ergin
2019-05-16 8:17 ` Maxime Coquelin
2019-05-16 8:17 ` Maxime Coquelin
2019-05-16 21:26 ` Ergin, Mesut A
2019-05-20 8:29 ` Ananyev, Konstantin
2019-05-20 17:53 ` Ergin, Mesut A
2019-05-20 23:11 ` Ananyev, Konstantin
2019-05-21 16:33 ` Ergin, Mesut A
2019-05-21 17:20 ` Ananyev, Konstantin
2019-05-21 20:55 ` Ergin, Mesut A
2019-05-22 11:01 ` Ananyev, Konstantin
2019-05-22 14:05 ` Thomas Monjalon
2019-05-22 14:32 ` Zhang, Qi Z
2019-05-23 13:10 ` Jerin Jacob Kollanukkaran
2019-05-23 17:54 ` Ergin, Mesut A [this message]
2019-05-16 4:28 ` [dpdk-dev] [PATCH 3/3] net/i40e: fix inadvertent override of vector RX allowance Mesut Ali Ergin
2019-05-16 4:28 ` Mesut Ali Ergin
2019-05-16 8:17 ` Maxime Coquelin
2019-05-16 8:17 ` Maxime Coquelin
2019-05-16 20:57 ` Ergin, Mesut A
2019-05-22 12:42 ` Zhang, Qi Z
2019-05-23 18:25 ` Ergin, Mesut A
2019-05-24 2:39 ` Zhang, Qi Z
2019-05-24 18:08 ` Ergin, Mesut A
2019-05-25 11:29 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3615B82CA151CF42A86EDDD9846A8B38C7A8C36F@ORSMSX112.amr.corp.intel.com \
--to=mesut.a.ergin@intel.com \
--cc=arybchenko@solarflare.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).