From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 2F80E1E33 for ; Sun, 14 Jan 2018 23:55:03 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D3B45208A4; Sun, 14 Jan 2018 17:55:02 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Sun, 14 Jan 2018 17:55:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=CFOw4O8sZ7hgsNESKAvbXTHiFB 19RkelSGdIEYN6+C4=; b=ckDscW90mHpZeHXUTAHrdqJKpmDa3jWfjiDleXs0Fr SUcIJsVnG6fK2tk9rAls0fO4kroI7eh+2xJOi+IfIsr26uqC6RqDdOPrVdNEoVGR fKgzDh5Dj1j0qam/VvhaPs66uSCQsXq7WPQQ1H4ABIK6sRCK05ORrsKcGX/0jvLJ Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=CFOw4O 8sZ7hgsNESKAvbXTHiFB19RkelSGdIEYN6+C4=; b=TsHg4EXK5gdRthASwvpt3t nqVjRM5YmmidJDwR7HBE1wOm8+wh6QwjXSB6CtTesEObsyJYd8s27aiPBld+g8cm 5XO0UVFvN+cQyWX4Wgg5R/ZWwcWEzhJvdvzwWTQcNQMg+P6dlwLBiWHgh0C1Olg+ UxyTxJTCG3UO72dv+2XHKIvca6vRwHSJK/6TwKRv4ASC5L35FzNy6lsUgByR23Uo zrhZABoQfdEWfMX2hZPEyyZ/jKfcJN3Pzk4olrmzHAedjjCMoeQZUe2HSdNgikca lPB9MNA8mPUz0blIoAgqv9mu9dXam7Pph0lDx3yDq9ppWB+td9GtBmiI4djvFetg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 87648246CA; Sun, 14 Jan 2018 17:55:02 -0500 (EST) From: Thomas Monjalon To: Shreyansh Jain Cc: dev@dpdk.org, hemant.agrawal@nxp.com, fiona.trahe@intel.com, rosen.xu@intel.com Date: Sun, 14 Jan 2018 23:54:31 +0100 Message-ID: <3616426.fmUHyIAH1S@xps> In-Reply-To: <20180102125749.2379-4-shreyansh.jain@nxp.com> References: <20180102125749.2379-1-shreyansh.jain@nxp.com> <20180102125749.2379-4-shreyansh.jain@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1 3/5] drivers/raw: introduce skeleton rawdev driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Jan 2018 22:55:03 -0000 02/01/2018 13:57, Shreyansh Jain: > +struct skeleton_firmware { > + struct skeleton_firmware_version_info firmware_version; > + /**< Device firmware information */ > + enum skeleton_firmware_state firmware_state; > + /**< Device state */ > +}; > + > +#define SKELETON_MAX_ATTRIBUTES 10 > +#define SKELETON_ATTRIBUTE_NAME_MAX 20 > + > +struct skeleton_rawdev_attributes { > + char *name; > + /**< Name of the attribute */ > + uint64_t value; > + /**< Value or reference of value of attribute */ > +}; > + > +#define SKELETON_CAPA_FW_LOAD 0x0001 > +/**< Device supports firmware loading/unloading */ > +#define SKELETON_CAPA_FW_RESET 0x0002 > +/**< Device supports firmware reset */ > +#define SKELETON_CAPA_QUEUES 0x0004 > +/**< Device support queue based communication */ Comment about the style. The style is important :) You are always writing comments after the item. When comments are on a separate line, I think it is preferred to write them *before* the item they describe.