From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 6195137B0 for ; Wed, 27 Apr 2016 11:39:40 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id a17so8079052wme.0 for ; Wed, 27 Apr 2016 02:39:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=NoA6dSClVghx5fkk4sF1C0UQs2K8CPgzjezbZ6g1rt4=; b=qIizZsImxad/oOTyGmxk0zNq1ZLJfypS2p/LGtavZx0teqy2QzJXbZV12QbgksHBz+ AZP2gNIOBbEpHcPZIyz+I5ekBL7oK+4wCP2V8tCoJXmsQZ6hjwqt5WngwfKg2Evn/l2V 2iUEG1Cxn2brBN/Y8hlP+o4dN2r790UDv0dedgZnxfdmlwAwXLM/ory16En0r7gQ8tSH BXNeAT3Ju/7Fl4/5R98bDZB2XBg6dsuz0R2Ap8R7KstQZFmFGsbwMGci73gG+neNnvat qmNfgDE4uAm901kJn7b4AKzHbopGuFXrKp8QizcibAjfrXIuGyQjxbyekQcf7x7/aMjh uQNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=NoA6dSClVghx5fkk4sF1C0UQs2K8CPgzjezbZ6g1rt4=; b=mdGRFq3KIfuJdg0FyDkixVG22NnlliVgWTDFQE+i9kMj2zDE95QNpPenjKyRfzih98 CigipmMkLUjbj6BLKzUvh4N9uamsgPIdBKDNUECP9nG3xeHkEjLBhfE2wVFnpsrgtTN6 PxvgNDXLVBVHMH5wCa8kQyaw8wy6DUU0KBwQSzZWRMbWFRhd6TzcM62Nb5v1uBhKyHUr gosBEXg1yaw6KXAycCkElOTYFY6irN7CxoByvAmnhPmIYs3aIGlXYHef8bKJSUUi6g+f KarzlUc6glNQhf+i9f8RYJZ0TB9UJxJPPYNVzf8GcQT1YyYYTDzdzaUDP8pC32EGEkiG +zKg== X-Gm-Message-State: AOPr4FURF03iWlNfk7I1us4l7PE8Y3KHWVyoSY2Wb0RxAj3we1RRr8gLa2cEbg0kA+ITNQxy X-Received: by 10.28.127.80 with SMTP id a77mr8875956wmd.66.1461749980193; Wed, 27 Apr 2016 02:39:40 -0700 (PDT) Received: from xps13.localnet (51.111.75.86.rev.sfr.net. [86.75.111.51]) by smtp.gmail.com with ESMTPSA id b124sm28293643wmb.1.2016.04.27.02.39.38 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 27 Apr 2016 02:39:39 -0700 (PDT) From: Thomas Monjalon To: martin_curran-gray@keysight.com Cc: users@dpdk.org, stephen@networkplumber.org, dev@dpdk.org Date: Wed, 27 Apr 2016 11:39:37 +0200 Message-ID: <3616976.ag6djbJWME@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <22C95CA62CBADB498D32A348F0F073BC116CC81F@wcosexch02k.cos.is.keysight.com> References: <22C95CA62CBADB498D32A348F0F073BC116CC81F@wcosexch02k.cos.is.keysight.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-users] Link Status and Interrupts in 2.2.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Apr 2016 09:39:40 -0000 2016-04-25 11:49, martin_curran-gray@keysight.com: > But if the link was "active" when dpdk and my app starts up, > then no interrupt is generated, which then means that global > structure is not filled in You are describing the case of interrupts enabled but never called. It has been fixed in DPDK 2.0: http://dpdk.org/commit/99610782 But a race condition has been seen if interrupt fires during rte_eth_dev_start() call. The decision was to remove link update if interrupt is enabled (DPDK 2.2): http://dpdk.org/commit/d5790b03 This "fix" was a bit strange: - Is it possible to fix the race condition with link_update in the drivers? - Is it possible to update the link status in dev_start of each driver without race condition with the interrupt? - Why calling link_update() from rte_eth_dev_start() in the polling case? > I saw a submission to the patchwork 7160, dated Sep 24 2015 > but it was marked as not applicable , archived..... It has been re-submitted and applied (hence the problem): http://dpdk.org/patch/8112