From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Dariusz Sosnowski <dsosnowski@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Bing Zhao <bingz@nvidia.com>, Ori Kam <orika@nvidia.com>,
Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] net/mlx5: fix MAC address initialization
Date: Mon, 11 Nov 2024 01:47:02 +0000 [thread overview]
Message-ID: <361b4c1a-cb64-40d4-ad64-0d225c691a99@amd.com> (raw)
In-Reply-To: <20241108160724.730989-1-dsosnowski@nvidia.com>
On 11/8/2024 4:07 PM, Dariusz Sosnowski wrote:
> Offending patch added code which broke compilation on GCC 15,
> where MAC address was initialized with a string, causing the following
> errors:
>
> ../drivers/net/mlx5/mlx5_flow.c:
> In function ‘mlx5_legacy_dmac_flow_create’:
> ../drivers/net/mlx5/mlx5_flow.c:8568:44:
> error: initializer-string for array of ‘unsigned char’ is too long
> [-Werror=unterminated-string-initialization]
> 8568 | .hdr.dst_addr.addr_bytes =
> "\xff\xff\xff\xff\xff\xff",
> |
> ^~~~~~~~~~~~~~~~~~~~~~~~~~
>
> ../drivers/net/mlx5/mlx5_flow.c: In function
> ‘mlx5_legacy_dmac_vlan_flow_create’:
> ../drivers/net/mlx5/mlx5_flow.c:8583:44:
> error: initializer-string for array of ‘unsigned char’ is too long
> [-Werror=unterminated-string-initialization]
> 8583 | .hdr.dst_addr.addr_bytes =
> "\xff\xff\xff\xff\xff\xff",
> |
> ^~~~~~~~~~~~~~~~~~~~~~~~~~
>
> This patch fixes this issue by converting it to array initialization.
>
> Fixes: cf99567fe566 ("net/mlx5: add legacy unicast flow rules management")
>
> Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
>
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2024-11-11 1:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 16:07 Dariusz Sosnowski
2024-11-11 1:47 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=361b4c1a-cb64-40d4-ad64-0d225c691a99@amd.com \
--to=ferruh.yigit@amd.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).