From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D94B445CE0; Mon, 11 Nov 2024 02:47:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA95240270; Mon, 11 Nov 2024 02:47:16 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2050.outbound.protection.outlook.com [40.107.94.50]) by mails.dpdk.org (Postfix) with ESMTP id 5F4D640151 for ; Mon, 11 Nov 2024 02:47:15 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dpjsWXf1fBP8LziR8Syp+1CJ2+SrvWBQZf7CPy5EpZib86a9wtE0ierUuNLdqLP41zyv5iVkr3rlvB6oNoSaTwg2Ga1QqGemo4ipbYLILqWyPCA0yVR+9NGFhZmSxiaEv5+5JWsybJVcVDWOiJZp9hTEnUNCip5fVh1isNIKcdnEyu6LdqTEdEBFLAwkNiXS49yiG9ujorlYTEc52Gl7gZ5t6tTSACzHCtxriOvJbYdywm7h51p7wcjbOQ7ohA6/nI/tJTLzxdBLtW3S6ecl92rNMfhDv09o6apBfozwiOJ7ahytrY+n7b4gzOIVwsXfqWTvFXVGeeysBONZja+mzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uaG1EntV5RxaPL561HsIdCg+IlRWOrfOF7el9l7j+Lc=; b=v6e6PhY2IAl6Hpr0dZhyCpAPpOUrQ+rXz8Z8txUkJdktvSOKsiGooeL0/uIyZY8fMOQ3vsMdV+ky/wXcB80+/JD72TmpFbwG/2s0baJNAFWeWoU5I2fs+3NB6m0rfPdqsAfjf5tDiAGGGJrhdwkG2fvrqjaULVB0f5FT+m6Rqp2THw/3s60bxUO7j/o2P+mrg5+Jcm3exy/WdfbHziHRl+LZ01d+mYELHR2wIG5pvvOuFS/Fp0qQTs4u0CZHtIrtm7jM/g/3YMKJG4URX2VRl+YjA46b1olUKTC/5btUyo0sok1oMhf8GR+7/nE5QVYykYDYkKsAB3wxOwaNup9qKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uaG1EntV5RxaPL561HsIdCg+IlRWOrfOF7el9l7j+Lc=; b=DAqVWCLDlowW626F7vSsbII41WUzWHDf423hVlUETOQGRL/DRpKccc13wqs3PW2JxnkU4f+GsaQYyORUHWGSLndvB4Y/2bcaRIrOG5Ly1q0YcLtiZ4tQ2q2B2Y9k0gRt2Kr0H4qJzySFIwK4XYAbJJh8zM1myPIieYCjCYQdGMg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by DS7PR12MB5934.namprd12.prod.outlook.com (2603:10b6:8:7d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.28; Mon, 11 Nov 2024 01:47:08 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%3]) with mapi id 15.20.8137.027; Mon, 11 Nov 2024 01:47:07 +0000 Message-ID: <361b4c1a-cb64-40d4-ad64-0d225c691a99@amd.com> Date: Mon, 11 Nov 2024 01:47:02 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/mlx5: fix MAC address initialization To: Dariusz Sosnowski , Viacheslav Ovsiienko , Bing Zhao , Ori Kam , Suanming Mou , Matan Azrad Cc: dev@dpdk.org References: <20241108160724.730989-1-dsosnowski@nvidia.com> Content-Language: en-US From: Ferruh Yigit In-Reply-To: <20241108160724.730989-1-dsosnowski@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0171.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:312::17) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|DS7PR12MB5934:EE_ X-MS-Office365-Filtering-Correlation-Id: 7b5c2213-d9e8-41e5-2511-08dd01f2c010 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?YlRlYy9RaUR0ZTU3d2oway95eGlXUStHM28rcWxLT3RkSmZDcXR0a1AyNTB2?= =?utf-8?B?Wm8zd2NKZGFNMElLN0xwMjBYaVVSQkVrNitUWG9XZlJ5S2w1ZUN2ZStOa09m?= =?utf-8?B?MTZMUUV1Uy9nRGgyT2NPckM5ZWhwT1pISm16OHB2eDA0cllVSXVZc3MrVmx3?= =?utf-8?B?aU5IbHlQWjFOcy95QXJyTEJuY3U4dmFuTGxTTjQ4UndRdEpsbGY2STAzR2Z4?= =?utf-8?B?Nms5dTVDU0ZkR1pCSHpBczFyV3pwZytSUno2WHMrZmFlSE9FMVdFTkJoWmZB?= =?utf-8?B?dEJQK1NNeGl6VlE4N2thTnNNTC9RVC9qQncrRXBFaC9xS1VPTUFDOWZ1QVB5?= =?utf-8?B?S2Z1RzIwb1NwQ21XZUxUTmhxd2ovKzl0LzhJL0lYcmRxUkpwWHpCSHRzTFNT?= =?utf-8?B?dGd1N3NPYWhHd0syOWw4aEw3ZkN3UWNIOXZDa0xNVjhtYndVM1NBdGg0NnZK?= =?utf-8?B?T3lIejJVNkdmS0svRGRXNkNMM1QxdE9jL0V4Rldla3lwOHJldmFEQmpNbWNh?= =?utf-8?B?OG1iZGp0YS9VVEF2ZURYTjQ5NHpOamtFTmJvWVFqcXNJbjh4Y2pSeW03STRa?= =?utf-8?B?dk9KakxPY09Nc1ovaVp1YUpEb1JoVEFyTmtNYkllQy9RVXVEUTRxNC9Kckda?= =?utf-8?B?eHdJK1IxNFVDS0N5ZXdXWnUrU0JNczRFVUFBcXB1bTJRMVNIZWNnZUZ0d3NT?= =?utf-8?B?a0p0NXR0WGg1WlczcmpFdEd5SHk5cjNZclZKTTNYMGZ3a0J4SlRmZ0t5cE9s?= =?utf-8?B?NzZ1RmN3VmNrNit6a0hKZ2p0NFlRcWFkd1RSMWVFTUxEdHY4K1hZeEs4N0dG?= =?utf-8?B?a2tqbGxsVGJmMkhIMDBhNzgzbnRKUThTU2JYUVJaQ1p4bjF4ZkdRNmFNMW5U?= =?utf-8?B?eXUyZEEzSHFldlV1TzAvWk5XUVNLSCthQVpQN2dielNibDdFaSs2bGNEbzV0?= =?utf-8?B?bFhxbTZFWDJPY1BjT2FMMkJWcFp5MUxYMGhORjE5TDV6VzNOQS9UWWlWUVJw?= =?utf-8?B?aXg1cEhtZmNycVIzWVBHb0V0NkJVU09WUUZ4RUdTNmcyUDVEZ0ZQSWkvaTQ5?= =?utf-8?B?MVY1VlNGNXRZUHQ5cllQQ3NiQ2t1RFZhc0hEM3hsZ1E1RThaS0grMmM0L00v?= =?utf-8?B?ODQwUWUrM1d1WXJXTk0vS0ZqaC9nbmlNUzZTVVJ5U0xRSm83ZG8yRk9rY1Ar?= =?utf-8?B?UU1Sb3lna0l0aUhBUHBpc2F4V3BqKzVPMy9ZQ3dGQW5Gbis3TlI0Y1MvUTBt?= =?utf-8?B?YnFUYWpIQmEyd2c0RlBCUldyM2JRNFdzMzh1MktWWkphdVZvaTloSWVScXdW?= =?utf-8?B?RWFiRzIvNzVKNjBKMnNIYyt6QlNDaXora0JsUDYvVzBXMnVHOXV6R0o3ZlVh?= =?utf-8?B?MWt4QWo2ZDUrdTk4NlVDdDh2b1BoWWpxWW9xVCs4N2R6K0ZuRzlUUG5NbDhJ?= =?utf-8?B?NkJqcnFIbGQ3TElpdXBhb0xQQklIK0ZhNGJyUmV5N3JTc1pWOWV5ejJyOFhO?= =?utf-8?B?QjVXNUhxcVJnU1F6N0dSMzJhSU1CRlVENTRJSnd2UWtuN2dyMkRUUWRFQ2pu?= =?utf-8?B?cXZGenFJNEJGbnQ5UkV2UEo0bllCN21yTEV5NW1tbDdvZlNldVNRaGhWWXlB?= =?utf-8?B?aWZ1UnFmWEhpSHgvN3NqTUpHcVhGY0hUejJPNzMzMm5rRGNPQXVRcU81UlBk?= =?utf-8?B?cnZ4ZU84dTBjNS9pUTdydXdJWU1QWUwxZVBGcU5INGorRnlUa0V4bnVtNVd3?= =?utf-8?Q?Svo8gFBioeEO/8uhokPdfSwMoiwzETGoTAO7zRl?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SWhkQ01nWEhna2lqQnZCSFFnNlhOSWN5dnJZb0RYdXNSdlNwWlRMUTdtai8z?= =?utf-8?B?bDZTTndvWENab1lhVEcxaUl6U0xOQWZKMzRlZ1JWajRnSTVEeTczTERZZGgx?= =?utf-8?B?cElRV09paWJib1JPMTBCbFVnTkpDa2l1YzBHS0g5M0krUWxlb0JUbEp1M29X?= =?utf-8?B?djZudjE2R2xtdTB3cTZzUVAyTS9PSEwrWWltcGVaY003S2hwcGlsSnFWTEwx?= =?utf-8?B?azAxY1dtbVZ4NzYvNDBrSGEvSmNUVS9jRXloRGVYQ1V5TUxBalVraWtwYWJh?= =?utf-8?B?MmR4SDFTajRwSGNHa2pISjMyMnVxTmhpS2Vhd1ArVVBRVEIrbk9KcVRCaEtI?= =?utf-8?B?ZjdhcjVobjloelZ4U3QvekQ2cXE3NnZ3V2JoM3VsQUpVVDZ2d1dvL1Ayb3RL?= =?utf-8?B?SEJrSXphZzFJaTkvYW9mdjdrRkQ5aVk0Z3gvRnpkbFN4bWlVOG9YbWdHTXZv?= =?utf-8?B?aUc1bmtXeUJzYS8yTTJ1aTVDbXFzZTdmcXhEbDgvWkZxQ0lsblFqemhhS0VE?= =?utf-8?B?c0UxL3o4di80bmhHRHFEdEZyTVhtNG9LUUdQWEU2Um8vU2NMWDBJMzhJQnpI?= =?utf-8?B?YWFGam44UWVDMytFLzJPbTUwU3JCT3ZGRlZJQzBXbjZLWFRFQTlIeHB4QWN0?= =?utf-8?B?NDlOV25YRERQb1JmUTNzTzAyVEpMWHJ3TEtsaytHdnhDYWc3NDI1MFhJL3JU?= =?utf-8?B?bkdWaHc0dm9lTGhFNzNxd1Q3OTV3dHpQcWpleXZzQ1EzZnlPTmE2am1lVGxR?= =?utf-8?B?MW04UytFelp2NmZPS2xFUnZWMVpUblphQjdIa2NqVzArbzkwdTJmcnVzUm9S?= =?utf-8?B?dWdveDNxdytnY0JjT1h1RHZNdUR3WUp4UUlEWVVYcWV3Y25HRUw2L3pEODBj?= =?utf-8?B?MU5ONndtdW1tbjFuZnAxQTV5SEVnSVBnMUtjbEpHTmpBRlhnNmo5bDR5ekhR?= =?utf-8?B?ckhwd2ZnbERFa2IvUTVGYVNlZFNwc3pVNUFSMVdjaVk4ZmRzQ1A3dDl5Vlpy?= =?utf-8?B?Z1lBRTIzZ015aE9lZXRqem8wU3ZhTWI4dk5qWi83bW15bVRPeXZXRGJha0FN?= =?utf-8?B?dmdMUnNHL0NGRzAvNUJlZWhDbHQyZ0laUGwzdEh0bWlLUkFYYUtIaE5mTitz?= =?utf-8?B?aEFKOVQ0OG9ucU5LUXlGSmJTRmZpRDJBSGV0MkZYUjBZdWVvcHFGa0trYlNP?= =?utf-8?B?UVV4V1gzWlRCTHZUYnJMUzVlT0ZYVmxRTlhuNEg0QjEwVURzWFdnSWtWaDlm?= =?utf-8?B?dVhnZHFxRFVmZm9KaGo0bVE3enFwNnFraEFtUkU2ZFZWUTRpOFgrUkFFTXFP?= =?utf-8?B?c0k4anJwdlN2VEwwRGF3NnNLdVNlUlhMSWpiSzlUN3BOL2tNY0kzNGtGb3Q5?= =?utf-8?B?OTR1VktEWW5rSDNZTGgzVlFGT0Vob3gwbEFIVmRDZ0MxT0Z4R0wzc0I0WHd2?= =?utf-8?B?QnhHSUZOSkxUQjlJWERYcVQ4QVNBVlExOVRuaXREU3FrYkE0MWMzNEs0SVhw?= =?utf-8?B?ZkgwU2p0bnliYVB6R2FESy9VblhGNUgwaDZxQlVIUnNJdjRza1FKRjBVMWlm?= =?utf-8?B?V1czeGVxay9RSUt6bko0dHFacEExRXRNTjhlNFIxenIrSTJOUU5EbmFQbm1s?= =?utf-8?B?MnpsUjFDN1YxU2xZYlp4UTlURnNtMHpYRUlWU1pISXF4UEhoTWJXcjI3alhr?= =?utf-8?B?MWZKQmNHUXZEa3BHaGpTeG1UUW4vT0ZpK1ZQWkJDY2FZRjduY25qVHhxc2xk?= =?utf-8?B?YnVyd0NQRG4yeTB0NVZ6eE9YQytvc2x1WHVxT2VJMGhwT1QwS3lYT0pzSEJm?= =?utf-8?B?aVRhZkc2dWRBU2VMeTFRZlR3amQ2S3ZVbGI0b3hDbkFwU1ZMaEdBTVEwZ0NW?= =?utf-8?B?b3FGeEY1ZndpVlRTa01rT09lYkxMUUxodlN4N2h0cmhxTTRmZUJuWGlYc1A4?= =?utf-8?B?WkpkeFVuTVRKaTYwVk5uSFlOUnlvS2RyVStlMlVmcjVLSjJWREhGbFJkcGdm?= =?utf-8?B?ZHlZK2d2VkVGK2Erdk0zVVlDTTdmOGs3VGFub3NRSXZBTER6MlhBMlVycEp6?= =?utf-8?B?dE9Ybms3RnU4UHVvOFBxZTJWSXRJYVRnalp1dzF0R0tsSFpEZ1MzTHQ5aHVt?= =?utf-8?Q?WUzWS/vRE00bcXkG1UUqrzeME?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b5c2213-d9e8-41e5-2511-08dd01f2c010 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2024 01:47:07.5067 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jEdmAzRNFUC6Hu1f+oHBjsAeQB9NnwWoQJ9aKhWt02Z/4q9ZyxgmZj8ianPEbViL X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5934 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/8/2024 4:07 PM, Dariusz Sosnowski wrote: > Offending patch added code which broke compilation on GCC 15, > where MAC address was initialized with a string, causing the following > errors: > > ../drivers/net/mlx5/mlx5_flow.c: > In function ‘mlx5_legacy_dmac_flow_create’: > ../drivers/net/mlx5/mlx5_flow.c:8568:44: > error: initializer-string for array of ‘unsigned char’ is too long > [-Werror=unterminated-string-initialization] > 8568 | .hdr.dst_addr.addr_bytes = > "\xff\xff\xff\xff\xff\xff", > | > ^~~~~~~~~~~~~~~~~~~~~~~~~~ > > ../drivers/net/mlx5/mlx5_flow.c: In function > ‘mlx5_legacy_dmac_vlan_flow_create’: > ../drivers/net/mlx5/mlx5_flow.c:8583:44: > error: initializer-string for array of ‘unsigned char’ is too long > [-Werror=unterminated-string-initialization] > 8583 | .hdr.dst_addr.addr_bytes = > "\xff\xff\xff\xff\xff\xff", > | > ^~~~~~~~~~~~~~~~~~~~~~~~~~ > > This patch fixes this issue by converting it to array initialization. > > Fixes: cf99567fe566 ("net/mlx5: add legacy unicast flow rules management") > > Signed-off-by: Dariusz Sosnowski > Acked-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.