* [dpdk-dev] [PATCH] net/mlx5: fix limit on direct rules tables number
@ 2019-07-31 14:37 Dekel Peled
2019-08-01 13:22 ` [dpdk-dev] [PATCH v2] " Dekel Peled
0 siblings, 1 reply; 4+ messages in thread
From: Dekel Peled @ 2019-07-31 14:37 UTC (permalink / raw)
To: yskoh, viacheslavo, shahafs; +Cc: orika, dev, stable
MLX5 PMD limits the number of SW steering tables to 32.
This patch updates the limit to 65535, to allow wide range of values.
Fixes: e2b4925ef7c1 ("net/mlx5: support Direct Rules E-Switch")
Cc: stable@dpdk.org
Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
drivers/net/mlx5/mlx5.h | 4 ++--
drivers/net/mlx5/mlx5_flow_dv.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
index caf2491..f559f83 100644
--- a/drivers/net/mlx5/mlx5.h
+++ b/drivers/net/mlx5/mlx5.h
@@ -513,8 +513,8 @@ struct mlx5_flow_tbl_resource {
rte_atomic32_t refcnt; /**< Reference counter. */
};
-#define MLX5_MAX_TABLES 1024
-#define MLX5_MAX_TABLES_FDB 32
+#define MLX5_MAX_TABLES 0xffff
+#define MLX5_MAX_TABLES_FDB 0xffff
#define MLX5_GROUP_FACTOR 1
#define MLX5_DBR_PAGE_SIZE 4096 /* Must be >= 512. */
diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
index 9c0a261..14e70ed 100644
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c
@@ -2817,7 +2817,7 @@ struct field_modify_info modify_tcp[] = {
(error, EINVAL,
RTE_FLOW_ERROR_TYPE_ATTR_TRANSFER,
NULL, "group must be smaller than "
- RTE_STR(MLX5_MAX_FDB_TABLES));
+ RTE_STR(MLX5_MAX_TABLES_FDB));
}
if (!(attributes->egress ^ attributes->ingress))
return rte_flow_error_set(error, ENOTSUP,
--
1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH v2] net/mlx5: fix limit on direct rules tables number
2019-07-31 14:37 [dpdk-dev] [PATCH] net/mlx5: fix limit on direct rules tables number Dekel Peled
@ 2019-08-01 13:22 ` Dekel Peled
2019-08-04 5:43 ` Slava Ovsiienko
2019-08-04 10:29 ` Raslan Darawsheh
0 siblings, 2 replies; 4+ messages in thread
From: Dekel Peled @ 2019-08-01 13:22 UTC (permalink / raw)
To: yskoh, viacheslavo, shahafs; +Cc: orika, dev
MLX5 PMD limits the number of SW steering tables to 32.
This patch updates the limit to 65535, to allow wide range of values.
Fixes: e2b4925ef7c1 ("net/mlx5: support Direct Rules E-Switch")
v2: remove Cc to stable release, not relevant for this fix.
Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
drivers/net/mlx5/mlx5.h | 4 ++--
drivers/net/mlx5/mlx5_flow_dv.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
index caf2491..f559f83 100644
--- a/drivers/net/mlx5/mlx5.h
+++ b/drivers/net/mlx5/mlx5.h
@@ -513,8 +513,8 @@ struct mlx5_flow_tbl_resource {
rte_atomic32_t refcnt; /**< Reference counter. */
};
-#define MLX5_MAX_TABLES 1024
-#define MLX5_MAX_TABLES_FDB 32
+#define MLX5_MAX_TABLES 0xffff
+#define MLX5_MAX_TABLES_FDB 0xffff
#define MLX5_GROUP_FACTOR 1
#define MLX5_DBR_PAGE_SIZE 4096 /* Must be >= 512. */
diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
index 9c0a261..14e70ed 100644
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c
@@ -2817,7 +2817,7 @@ struct field_modify_info modify_tcp[] = {
(error, EINVAL,
RTE_FLOW_ERROR_TYPE_ATTR_TRANSFER,
NULL, "group must be smaller than "
- RTE_STR(MLX5_MAX_FDB_TABLES));
+ RTE_STR(MLX5_MAX_TABLES_FDB));
}
if (!(attributes->egress ^ attributes->ingress))
return rte_flow_error_set(error, ENOTSUP,
--
1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/mlx5: fix limit on direct rules tables number
2019-08-01 13:22 ` [dpdk-dev] [PATCH v2] " Dekel Peled
@ 2019-08-04 5:43 ` Slava Ovsiienko
2019-08-04 10:29 ` Raslan Darawsheh
1 sibling, 0 replies; 4+ messages in thread
From: Slava Ovsiienko @ 2019-08-04 5:43 UTC (permalink / raw)
To: Dekel Peled, Yongseok Koh, Shahaf Shuler; +Cc: Ori Kam, dev
> -----Original Message-----
> From: Dekel Peled <dekelp@mellanox.com>
> Sent: Thursday, August 1, 2019 16:23
> To: Yongseok Koh <yskoh@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>; Shahaf Shuler <shahafs@mellanox.com>
> Cc: Ori Kam <orika@mellanox.com>; dev@dpdk.org
> Subject: [PATCH v2] net/mlx5: fix limit on direct rules tables number
>
> MLX5 PMD limits the number of SW steering tables to 32.
> This patch updates the limit to 65535, to allow wide range of values.
>
> Fixes: e2b4925ef7c1 ("net/mlx5: support Direct Rules E-Switch")
>
> v2: remove Cc to stable release, not relevant for this fix.
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
> drivers/net/mlx5/mlx5.h | 4 ++--
> drivers/net/mlx5/mlx5_flow_dv.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index
> caf2491..f559f83 100644
> --- a/drivers/net/mlx5/mlx5.h
> +++ b/drivers/net/mlx5/mlx5.h
> @@ -513,8 +513,8 @@ struct mlx5_flow_tbl_resource {
> rte_atomic32_t refcnt; /**< Reference counter. */ };
>
> -#define MLX5_MAX_TABLES 1024
> -#define MLX5_MAX_TABLES_FDB 32
> +#define MLX5_MAX_TABLES 0xffff
> +#define MLX5_MAX_TABLES_FDB 0xffff
> #define MLX5_GROUP_FACTOR 1
>
> #define MLX5_DBR_PAGE_SIZE 4096 /* Must be >= 512. */ diff --git
> a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
> index 9c0a261..14e70ed 100644
> --- a/drivers/net/mlx5/mlx5_flow_dv.c
> +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> @@ -2817,7 +2817,7 @@ struct field_modify_info modify_tcp[] = {
> (error, EINVAL,
> RTE_FLOW_ERROR_TYPE_ATTR_TRANSFER,
> NULL, "group must be smaller than "
> - RTE_STR(MLX5_MAX_FDB_TABLES));
> + RTE_STR(MLX5_MAX_TABLES_FDB));
> }
> if (!(attributes->egress ^ attributes->ingress))
> return rte_flow_error_set(error, ENOTSUP,
> --
> 1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/mlx5: fix limit on direct rules tables number
2019-08-01 13:22 ` [dpdk-dev] [PATCH v2] " Dekel Peled
2019-08-04 5:43 ` Slava Ovsiienko
@ 2019-08-04 10:29 ` Raslan Darawsheh
1 sibling, 0 replies; 4+ messages in thread
From: Raslan Darawsheh @ 2019-08-04 10:29 UTC (permalink / raw)
To: Dekel Peled, Yongseok Koh, Slava Ovsiienko, Shahaf Shuler; +Cc: Ori Kam, dev
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled
> Sent: Thursday, August 1, 2019 4:23 PM
> To: Yongseok Koh <yskoh@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>; Shahaf Shuler <shahafs@mellanox.com>
> Cc: Ori Kam <orika@mellanox.com>; dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] net/mlx5: fix limit on direct rules tables
> number
>
> MLX5 PMD limits the number of SW steering tables to 32.
> This patch updates the limit to 65535, to allow wide range of values.
>
> Fixes: e2b4925ef7c1 ("net/mlx5: support Direct Rules E-Switch")
>
> v2: remove Cc to stable release, not relevant for this fix.
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> ---
> drivers/net/mlx5/mlx5.h | 4 ++--
> drivers/net/mlx5/mlx5_flow_dv.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
> index caf2491..f559f83 100644
> --- a/drivers/net/mlx5/mlx5.h
> +++ b/drivers/net/mlx5/mlx5.h
> @@ -513,8 +513,8 @@ struct mlx5_flow_tbl_resource {
> rte_atomic32_t refcnt; /**< Reference counter. */
> };
>
> -#define MLX5_MAX_TABLES 1024
> -#define MLX5_MAX_TABLES_FDB 32
> +#define MLX5_MAX_TABLES 0xffff
> +#define MLX5_MAX_TABLES_FDB 0xffff
> #define MLX5_GROUP_FACTOR 1
>
> #define MLX5_DBR_PAGE_SIZE 4096 /* Must be >= 512. */
> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> b/drivers/net/mlx5/mlx5_flow_dv.c
> index 9c0a261..14e70ed 100644
> --- a/drivers/net/mlx5/mlx5_flow_dv.c
> +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> @@ -2817,7 +2817,7 @@ struct field_modify_info modify_tcp[] = {
> (error, EINVAL,
> RTE_FLOW_ERROR_TYPE_ATTR_TRANSFER,
> NULL, "group must be smaller than "
> - RTE_STR(MLX5_MAX_FDB_TABLES));
> + RTE_STR(MLX5_MAX_TABLES_FDB));
> }
> if (!(attributes->egress ^ attributes->ingress))
> return rte_flow_error_set(error, ENOTSUP,
> --
> 1.8.3.1
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-04 10:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-31 14:37 [dpdk-dev] [PATCH] net/mlx5: fix limit on direct rules tables number Dekel Peled
2019-08-01 13:22 ` [dpdk-dev] [PATCH v2] " Dekel Peled
2019-08-04 5:43 ` Slava Ovsiienko
2019-08-04 10:29 ` Raslan Darawsheh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).