From: Thomas Monjalon <thomas@monjalon.net>
To: "Fu, Patrick" <patrick.fu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"Wang, Zhihong" <zhihong.wang@intel.com>,
"Wang, Liang-min" <liang-min.wang@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"Miskell, Timothy" <timothy.miskell@intel.com>,
"Liang, Cunming" <cunming.liang@intel.com>,
"arybchenko@solarflare.com" <arybchenko@solarflare.com>,
Jiawei Wang <jiaweiw@mellanox.com>,
"orika@mellanox.com" <orika@mellanox.com>
Subject: Re: [dpdk-dev] [RFC] lib: introduce traffic mirroring API
Date: Fri, 31 Jul 2020 11:31:56 +0200 [thread overview]
Message-ID: <3630698.8D1TQZSjJl@thomas> (raw)
In-Reply-To: <DM5PR1101MB21690760D500E3DE55192AD0844E0@DM5PR1101MB2169.namprd11.prod.outlook.com>
31/07/2020 04:34, Fu, Patrick:
> Hi Thomas,
>
> From: Thomas Monjalon <thomas@monjalon.net>
> >
> > I assume you consider deprecating rte_eth_mirror_rule_set()
> > http://doc.dpdk.org/api/rte__ethdev_8h.html#a1c88c5e86f0358981443600f
> > 05069091
> >
> Not exactly.
> The rte_eth_mirror_rule_set() is vendor-dependent API which allows admin to configure two components (traffic source and traffic destination) of the same NIC so packets can be copied from traffic source to traffic destination through hardware. The API allows vendor to implement this function via hardware-dependent offloading capability. In contrast, this RFC is proposing two high-level APIs (vendor independent) to allow admin configuring mirror traffic from device A to device B where device A and B may come from different vendors. In particular, our initial target is on software virtual devices such as virtio/vhost where there is no mirror hw support.
>
> > Please consider reviewing this implementation in rte_flow:
> > https://patches.dpdk.org/patch/73279/
> >
> For the same reason explained, this patch is also targeting at different use cases with our RFC.
We should not have different API depending on the device.
Please look how to unify in a single API.
next prev parent reply other threads:[~2020-07-31 9:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 3:23 Patrick Fu
2020-07-30 6:32 ` Thomas Monjalon
2020-07-31 2:34 ` Fu, Patrick
2020-07-31 9:31 ` Thomas Monjalon [this message]
2020-07-31 11:41 ` Fu, Patrick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3630698.8D1TQZSjJl@thomas \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=bruce.richardson@intel.com \
--cc=cunming.liang@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jiaweiw@mellanox.com \
--cc=konstantin.ananyev@intel.com \
--cc=liang-min.wang@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=orika@mellanox.com \
--cc=patrick.fu@intel.com \
--cc=timothy.miskell@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).