From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7962FA052B; Fri, 31 Jul 2020 11:32:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4F1DA11A2; Fri, 31 Jul 2020 11:32:02 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id A0644A69 for ; Fri, 31 Jul 2020 11:32:00 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id DC0C95802B4; Fri, 31 Jul 2020 05:31:59 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Fri, 31 Jul 2020 05:31:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= i8KvKsQ1qrbusm0v4ooNU2gQYZNwW/JcXIgewSGvCNE=; b=t6btBmvGztDORSD4 h7tXJ1V83FkSvydRqGBq0vQZS1R51y80K868Vd059NtelRAY7altw76WifztxAUP hOc0iIIAXz8jSoM0hivknCU60pcRKlGI9OTlKPuhaE4Uv7NicUlDFci+WZ0487q2 4t0Gok4wsyrv4azY1CLD3ls4CjE6hlAv57wprZp6ZsCMaf8Mw1Gn3wDmjxR3w+jU UFAh9juNfpmeX//sYygRAzFPa/RvwMEPrSHC+x7E++9QSuEgHvExY2+8dfGAdI6R 9Sbvj1A0SpU8kS/sLwBRjH28EkOjt7Vz4mo6yeClyvplTLRXQmhX3M/LApGQn0fp 80aIjA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=i8KvKsQ1qrbusm0v4ooNU2gQYZNwW/JcXIgewSGvC NE=; b=e7ki7aXWoMjhMxZTNTB+VSId1NDXrTLAG/R7su1YD+3Q0yEfN6VioF5PG UFG1C23DeqyKz5wFNxWzNtzMqG8wP1gHL6i8OgBvn+AlxyR/bZetW5LUCK7xmqR5 FALVdFTuo4TFB3UxujTv3aVvy/vzg2GwwtAx+GXh9dTN6bgjeR0tPOgVd3JwbgSL BNxiYeCN5gOORHiJpbitzw60CiNhU4jkQVOq942gov7NBPwHUHVsNQPsKcDvJxkD 2AvsHK+QUfwpjGTCHONYZGD3n8jjZqKgWEwZqc4CQ4z9ZyQmDF8Cu6rdGuN+/bcz pRdpQbbVyaguC/v4FwOC9iIZkVxsA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrieekgddukecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeffvdffjeeuteelfeeileduudeugfetjeelveefkeejfeeigeehteff vdekfeegudenucffohhmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvd dtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 391253280066; Fri, 31 Jul 2020 05:31:58 -0400 (EDT) From: Thomas Monjalon To: "Fu, Patrick" Cc: "dev@dpdk.org" , "Yigit, Ferruh" , "maxime.coquelin@redhat.com" , "Richardson, Bruce" , "Wang, Zhihong" , "Wang, Liang-min" , "Ananyev, Konstantin" , "Miskell, Timothy" , "Liang, Cunming" , "arybchenko@solarflare.com" , Jiawei Wang , "orika@mellanox.com" Date: Fri, 31 Jul 2020 11:31:56 +0200 Message-ID: <3630698.8D1TQZSjJl@thomas> In-Reply-To: References: <20200730032332.3742259-1-patrick.fu@intel.com> <9050775.XvCxKblxuy@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [RFC] lib: introduce traffic mirroring API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 31/07/2020 04:34, Fu, Patrick: > Hi Thomas, > > From: Thomas Monjalon > > > > I assume you consider deprecating rte_eth_mirror_rule_set() > > http://doc.dpdk.org/api/rte__ethdev_8h.html#a1c88c5e86f0358981443600f > > 05069091 > > > Not exactly. > The rte_eth_mirror_rule_set() is vendor-dependent API which allows admin to configure two components (traffic source and traffic destination) of the same NIC so packets can be copied from traffic source to traffic destination through hardware. The API allows vendor to implement this function via hardware-dependent offloading capability. In contrast, this RFC is proposing two high-level APIs (vendor independent) to allow admin configuring mirror traffic from device A to device B where device A and B may come from different vendors. In particular, our initial target is on software virtual devices such as virtio/vhost where there is no mirror hw support. > > > Please consider reviewing this implementation in rte_flow: > > https://patches.dpdk.org/patch/73279/ > > > For the same reason explained, this patch is also targeting at different use cases with our RFC. We should not have different API depending on the device. Please look how to unify in a single API.