From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44])
 by dpdk.org (Postfix) with ESMTP id DA46538EB
 for <dev@dpdk.org>; Thu, 29 Sep 2016 16:30:08 +0200 (CEST)
Received: by mail-wm0-f44.google.com with SMTP id w84so301817055wmg.1
 for <dev@dpdk.org>; Thu, 29 Sep 2016 07:30:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=ywPhmPL7Yv0f+KcobIcyPXioYlCsXaPJW4hq4k9TcoY=;
 b=1bHOMl+G5j806peC+svz+WJQxEuWIcdzNDycmG4gHvFeJJnr2/Fpc9Ko2F39MVxs+C
 bIcm/YHngLZ1ZhEv4hBMGF6XeBF7SgrxPi5w00MpTQ3O7K2V6U/G7D3L0w/Dh42jZust
 ne7yYP/CqQzcsY3NuJmWhcIS7VnxjCOw1UU9lIDQ1tdO2PWmBronRMMSEQsF9AjQCqnK
 ZQaOSmUnv1LzYaX1mBn3DwZyMdKovdmzKiLjUE0DqLObCjpvh+F+ppAtppjedHrflxQP
 lCaIawnAQ+qWky6jk9o6VqXtxN/rHvQu8aGOJUAAcLw6q6Q5005cX2aWaYxPcEl96SqI
 Q8kA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=ywPhmPL7Yv0f+KcobIcyPXioYlCsXaPJW4hq4k9TcoY=;
 b=CSql1Snqueax3RE9DWqLUO6IXxCY67vXHwTbslw6pna+EGOX/UObczPj7h6n0x6OvQ
 rALrrD4m+JGec+dDMePgW4vT1sSAResskBsCOmd9HTxmwMdrQ0qER+SxfoeYGLHvQKUP
 rxFL3w4C/nzGU6cLbPTWwC69p/MqrSwj4UTLnUy6tmDS7u/pu7rUI8XmJYm6HUUzbstN
 AnrG14HshFB/POmRuWSrrF6vW3oP+/FP+uLvaWF0lMI6yOngxhQfklFDCZYInVWqe5Bj
 kNAyJ21wHZGrADgGtfSs9LTXXniFPNyBxX0zfstawswqES2M0J600A90EWeWKQL9rX3F
 n01w==
X-Gm-Message-State: AA6/9RnPNAUya5pxBurDqbeCnk609qm0FKVGgiwHni79FLh1g7+DqpF9q8CHmLTNDe12WkgW
X-Received: by 10.28.1.85 with SMTP id 82mr3367962wmb.11.1475159407277;
 Thu, 29 Sep 2016 07:30:07 -0700 (PDT)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id w203sm28449801wmw.7.2016.09.29.07.30.06
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 29 Sep 2016 07:30:06 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Bernard Iremonger <bernard.iremonger@intel.com>
Cc: dev@dpdk.org, rahul.r.shah@intel.com, wenzhuo.lu@intel.com, az5157@att.com,
 azelezniak <alexz@att.com>
Date: Thu, 29 Sep 2016 16:30:05 +0200
Message-ID: <3631809.sFy4WKcCTS@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1475158591-2243-2-git-send-email-bernard.iremonger@intel.com>
References: <1474453204-31516-1-git-send-email-bernard.iremonger@intel.com>
 <1475158591-2243-2-git-send-email-bernard.iremonger@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v5 1/3] librte_ether: add API for VF
	management
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Sep 2016 14:30:09 -0000

2016-09-29 15:16, Bernard Iremonger:
> Add new API function to configure and manage VF's on a NIC.
> 
> add rte_eth_dev_set_vf_vlan_stripq function.
> 
> Signed-off-by: azelezniak <alexz@att.com>

We need the full name of azelezniak.

> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
[...]
> +int
> +rte_eth_dev_set_vf_vlan_stripq(uint8_t port, uint16_t vf, int on);

Why keeping this function in ethdev?

I think it would be more consistent to have also existing VF functions
moving from ethdev to rte_pmd_ixgbe.h.
You cannot remove them, but you can create their ixgbe-specific version
and announce that the ethdev ones are deprecated.