[dpdk-dev] [PATCH] i40e: support xen domain0

[dpdk-dev] [PATCH] i40e: support xen domain0

[Helin Zhang]

i40e was failing to run in XEN domain0, as the physical
memory for adminq DMA should be allocated and translated
in a different way for XEN domain0. So
rte_memzone_reserve_bounded() should be used for DMA
memory allocation, and rte_mem_phy2mch() should be used
for DMA memory address translation to support running
i40e PMD in XEN domain0.

Signed-off-by: Helin Zhang <helin.zhang@intel.com>
---
 lib/librte_pmd_i40e/i40e_ethdev.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c
index 9ed31b5..7a823a0 100644
--- a/lib/librte_pmd_i40e/i40e_ethdev.c
+++ b/lib/librte_pmd_i40e/i40e_ethdev.c
@@ -1515,14 +1515,23 @@ i40e_allocate_dma_mem_d(__attribute__((unused)) struct i40e_hw *hw,
 
 	id++;
 	snprintf(z_name, sizeof(z_name), "i40e_dma_%"PRIu64, id);
+#ifdef RTE_LIBRTE_XEN_DOM0
+	mz = rte_memzone_reserve_bounded(z_name, size, 0, 0, alignment,
+							RTE_PGSIZE_2M);
+#else
 	mz = rte_memzone_reserve_aligned(z_name, size, 0, 0, alignment);
+#endif
 	if (!mz)
 		return I40E_ERR_NO_MEMORY;
 
 	mem->id = id;
 	mem->size = size;
 	mem->va = mz->addr;
+#ifdef RTE_LIBRTE_XEN_DOM0
+	mem->pa = rte_mem_phy2mch(mz->memseg_id, mz->phys_addr);
+#else
 	mem->pa = mz->phys_addr;
+#endif
 
 	return I40E_SUCCESS;
 }
-- 
1.8.1.4

Re: [dpdk-dev] [PATCH] i40e: support xen domain0

[Zhan, Zhaochen]

> i40e was failing to run in XEN domain0, as the physical
> memory for adminq DMA should be allocated and translated
> in a different way for XEN domain0. So
> rte_memzone_reserve_bounded() should be used for DMA
> memory allocation, and rte_mem_phy2mch() should be used
> for DMA memory address translation to support running
> i40e PMD in XEN domain0.
> 
> Signed-off-by: Helin Zhang <helin.zhang@intel.com>

Tested-by: Zhaochen Zhan <zhaochen.zhan@intel.com>

This patch updates i40e to support xen domain0, testpmd can works OK with it.
It is ready to be integrated to dpdk.org.

Re: [dpdk-dev] [PATCH] i40e: support xen domain0

[Liu, Jijiang]

Acked-by:  Jijiang Liu <jijiang.liu@intel.com>

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Helin Zhang
> Sent: Thursday, August 14, 2014 2:13 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] i40e: support xen domain0
> 
> i40e was failing to run in XEN domain0, as the physical memory for adminq
> DMA should be allocated and translated in a different way for XEN domain0.
> So
> rte_memzone_reserve_bounded() should be used for DMA memory allocation,
> and rte_mem_phy2mch() should be used for DMA memory address translation
> to support running i40e PMD in XEN domain0.
> 
> Signed-off-by: Helin Zhang <helin.zhang@intel.com>
> ---
>  lib/librte_pmd_i40e/i40e_ethdev.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c
> b/lib/librte_pmd_i40e/i40e_ethdev.c
> index 9ed31b5..7a823a0 100644
> --- a/lib/librte_pmd_i40e/i40e_ethdev.c
> +++ b/lib/librte_pmd_i40e/i40e_ethdev.c
> @@ -1515,14 +1515,23 @@
> i40e_allocate_dma_mem_d(__attribute__((unused)) struct i40e_hw *hw,
> 
>  	id++;
>  	snprintf(z_name, sizeof(z_name), "i40e_dma_%"PRIu64, id);
> +#ifdef RTE_LIBRTE_XEN_DOM0
> +	mz = rte_memzone_reserve_bounded(z_name, size, 0, 0, alignment,
> +							RTE_PGSIZE_2M);
> +#else
>  	mz = rte_memzone_reserve_aligned(z_name, size, 0, 0, alignment);
> +#endif
>  	if (!mz)
>  		return I40E_ERR_NO_MEMORY;
> 
>  	mem->id = id;
>  	mem->size = size;
>  	mem->va = mz->addr;
> +#ifdef RTE_LIBRTE_XEN_DOM0
> +	mem->pa = rte_mem_phy2mch(mz->memseg_id, mz->phys_addr); #else
>  	mem->pa = mz->phys_addr;
> +#endif
> 
>  	return I40E_SUCCESS;
>  }
> --
> 1.8.1.4

Re: [dpdk-dev] [PATCH] i40e: support xen domain0

[Thomas Monjalon]

> > i40e was failing to run in XEN domain0, as the physical memory for adminq
> > DMA should be allocated and translated in a different way for XEN domain0.
> > So
> > rte_memzone_reserve_bounded() should be used for DMA memory allocation,
> > and rte_mem_phy2mch() should be used for DMA memory address translation
> > to support running i40e PMD in XEN domain0.
> > 
> > Signed-off-by: Helin Zhang <helin.zhang@intel.com>
> 
> Acked-by:  Jijiang Liu <jijiang.liu@intel.com>

Applied for version 1.7.1.

Thanks
-- 
Thomas