From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id E8CD32BDA for ; Tue, 8 Mar 2016 15:33:40 +0100 (CET) Received: by mail-wm0-f42.google.com with SMTP id n186so134484017wmn.1 for ; Tue, 08 Mar 2016 06:33:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=7ui92MT7o9LTcXBwhgBSvUyRaX4BzYbxiZQ6NoxwMwE=; b=o8h8bD4SAz7lwC+rprXZrv6//gAjI51jU2e5e/0M+6hqT5feVvJX8JdchcvgdKiBOi aq1V2grDzfZQxnGsWiv1lktuM9ywRoFI431y/0VVU0Mn78p0sIr3McJ42MRpjsUkl9E+ hF2jYywmSuVOPRLt43PTVnhx+bDugd+MdDUsmxrsEGXzDded+o6yyIlPg2Ez0qBJ2PD7 Q03Qyx9LTOH66CSLs65fBmcohw5QAIN76QELYRYrhD1SyMX8ubmZzIZe84utFiPjlhX5 WSW8FlxWmHGnGDm0o+8BO4x4W3yfm9BEpL3aAUqUZJ/aw63DR0a69n95novBoIyHUkf8 dtLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=7ui92MT7o9LTcXBwhgBSvUyRaX4BzYbxiZQ6NoxwMwE=; b=I3oaM1ZpVJtqiZ5h7QdGjYr9lUpBPn7ZSFOuhv4YFmAAWlCioHBwn/hW9E6tFQWWwE 47pQ6obBy7SrcwXwz0o76hiBdXVi598z3OW8nqRwxF00YXejtFMJS6msoFpHNc9ORrXc 4dqKHxBtl4xNyqs2/TtZUVq0C3GNFj2vCy/fQf/cHko4HygU8+JE33lNNtBPFA4kccSQ j8JS0yS1wD2qsI7l98upf1NplU3/H/6GKpMwzdKeiP1iOe8Wvu/19OMYaPjTPOs53LSV Kyis/IXeQhccphzXOxry39kFybWyw59O2i6lDNBjKI65uQ0ebzkR2vwUkxx2z3SR0qTw 194g== X-Gm-Message-State: AD7BkJIRK1Xfz+l6oBD5jbzNl4nAkCQPE7Xf9CsQ0R0wgxBXCBPkv1Dr9qiTinNTlH1Xs+V6 X-Received: by 10.28.126.4 with SMTP id z4mr14417625wmc.29.1457447620798; Tue, 08 Mar 2016 06:33:40 -0800 (PST) Received: from xps13.localnet (171.36.101.84.rev.sfr.net. [84.101.36.171]) by smtp.gmail.com with ESMTPSA id g126sm19089596wmf.16.2016.03.08.06.33.39 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 08 Mar 2016 06:33:39 -0800 (PST) From: Thomas Monjalon To: Fiona Trahe Date: Tue, 08 Mar 2016 15:32:02 +0100 Message-ID: <3632610.NvqD1GaQY3@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1457351422-7617-3-git-send-email-fiona.trahe@intel.com> References: <1457116189-10226-1-git-send-email-fiona.trahe@intel.com> <1457351422-7617-3-git-send-email-fiona.trahe@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v7 2/2] cryptodev: change burst API to be crypto op oriented X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Mar 2016 14:33:41 -0000 2016-03-07 11:50, Fiona Trahe: > This patch modifies the crypto burst enqueue/dequeue APIs to operate on bursts > rte_crypto_op's rather than the current implementation which operates on > rte_mbuf bursts, this simplifies the burst processing in the crypto PMDs and the > use of crypto operations in general. > > The changes also continues the separatation of the symmetric operation parameters > from the more general operation parameters, this will simplify the integration of > asymmetric crypto operations in the future. > > As well as the changes to the crypto APIs this patch adds functions for managing > rte_crypto_op pools to the cryptodev API. It modifies the existing PMDs, unit > tests and sample application to work with the modified APIs and finally > removes the now unused rte_mbuf_offload library. Why not doing several patches? > -Packet buffer offload - EXPERIMENTAL > -M: Declan Doherty > -F: lib/librte_mbuf_offload/ Removing a library is important. It is not mentioned in the message. It deserves a separate commit, please. > @@ -62,8 +61,7 @@ struct crypto_unittest_params { > > struct rte_cryptodev_sym_session *sess; > > - struct rte_mbuf_offload *ol; > - struct rte_crypto_sym_op *op; > + struct rte_crypto_op *op; Isn't it something which was just renamed in the previous patch? > -#if HEX_DUMP > +#ifdef HEX_DUMP > static void > hexdump_mbuf_data(FILE *f, const char *title, struct rte_mbuf *m) A better clean-up would be to remove this ifdef. If you need a debug function which is not already in EAL, you can consider adding it.