From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id E949B16E for ; Fri, 12 Jan 2018 19:05:00 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7FCE8211D3; Fri, 12 Jan 2018 13:05:00 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 12 Jan 2018 13:05:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=4z/6YnggYO2TWkDxCsiKzIGwYg 9jU+XTrgg1sutTJ8U=; b=FrFO+L5UbQrjvMgSDbdxJxvcFY3pMUmTp1KZf+ST0B pk/IFc7BEeE80bP8/wMQDpluHnJAPY4jg3PCgeux0PkfGCBLMFeH4u77NZaZbMCX EDdn2NYf9VcyrP2iZR1j4ukKrdWPCmjD+PRcagD22n6O7rFPMJ7fUhCtd/KRxVY/ 4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=4z/6Yn ggYO2TWkDxCsiKzIGwYg9jU+XTrgg1sutTJ8U=; b=W1Xsz+vpZVnh5jFNEiy32p BgP58yc7rcqqlVfHVL2L5HhKVUyDhQBaDAvFpy+1PZzu+axE0evO10hmTD8T3J5R ROVRp3ICH6NYuAGNKNAd8ZoUHSFwUFucr7c3TGv3Pz48WrXLI0ChDiWBXMQmLeZU +UCSk7ciGGICjU3e5GqDiHVyTpQQMBPzeHzevXjxNACDuysH9guXHA09veo/ohGA 2bFXmqlmh/eN1jWmHxrrZpHU8Oq4jTb9DP7EmJmc/BKIIE1fHmbRN6DedrSB4a5k b9T/bCuMOa7Md9Fg9hfLCyZzbVbnv+fpR1a6v25I6hz8xQjLmhbDPAqg1doFL+xw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3573F7E353; Fri, 12 Jan 2018 13:05:00 -0500 (EST) From: Thomas Monjalon To: "Carrillo, Erik G" Cc: dev@dpdk.org, Aaron Conole , pbhagavatula@caviumnetworks.com Date: Fri, 12 Jan 2018 19:04:31 +0100 Message-ID: <3633241.u0AhPmFv0D@xps> In-Reply-To: References: <1515005015-31990-1-git-send-email-erik.g.carrillo@intel.com> <1713856.qAfyk3hvam@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/1] eal: return true or false from lcore role check function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jan 2018 18:05:01 -0000 12/01/2018 19:01, Carrillo, Erik G: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 12/01/2018 00:09, Carrillo, Erik G: > > > Hi Aaron, > > > > > > From: Aaron Conole [mailto:aconole@redhat.com] > > > > > > > > Hi Erik, > > > > > > > > Erik Gabriel Carrillo writes: > > > > > > > > > Update rte_lcore_has_role() so that it returns true/false instead > > > > > of success/failure. > > > > > > > > > > Fixes: 78666372fa2b ("eal: add function to check lcore role") > > > > > > > > > > Signed-off-by: Erik Gabriel Carrillo > > > > > --- > > > > > > > > I believe this breaks the published abi - Success is now 'true', and > > > > failure is 'false'; previously success would be 0 == false. You'll > > > > need to invert the test, or note that the abi is breaking (since > > > > semantically any caller will need to invert the test). > > > > > > Good point. Though it seems like an API change rather than an ABI change > > to me, would it still be handled the same way in terms of notice? Also, the > > ABI policy states, "ABI breakage due to changes such as reorganizing public > > structure fields for aesthetic or readability purposes should be avoided." > > Perhaps I should go with an alternate patch that fixes the caller. > > > > Most of the times, an API change is an ABI change. > > Please make a deprecation notice. > > Ok, thanks Thomas - will do. Should I mark the above patch as "deferred" for the time being? Yes, thanks All deferred patches are set to New when starting a new release cycle. So it should not be lost :)