* [dpdk-dev] [PATCH] test/crypto: fix test status when PMD isn't loaded
@ 2021-05-18 14:19 Ciara Power
2021-05-18 14:37 ` Zhang, Roy Fan
0 siblings, 1 reply; 3+ messages in thread
From: Ciara Power @ 2021-05-18 14:19 UTC (permalink / raw)
To: dev; +Cc: roy.fan.zhang, declan.doherty, aconole, gakhil, Ciara Power
The return value for a test when the required PMD is not loaded should
be TEST_SKIPPED, rather than TEST_FAILED.
Fixes: 8bfdd8a7f0f1 ("test/crypto: refactor to use sub test suites")
Signed-off-by: Ciara Power <ciara.power@intel.com>
---
app/test/test_cryptodev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 736952a9e6..c68684b80b 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -14504,7 +14504,7 @@ run_cryptodev_testsuite(const char *pmd_name)
if (gbl_driver_id == -1) {
RTE_LOG(ERR, USER1, "%s PMD must be loaded.\n", pmd_name);
- return TEST_FAILED;
+ return TEST_SKIPPED;
}
ts.unit_test_suites = malloc(sizeof(struct unit_test_suite *) *
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] test/crypto: fix test status when PMD isn't loaded
2021-05-18 14:19 [dpdk-dev] [PATCH] test/crypto: fix test status when PMD isn't loaded Ciara Power
@ 2021-05-18 14:37 ` Zhang, Roy Fan
2021-05-19 8:32 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Zhang, Roy Fan @ 2021-05-18 14:37 UTC (permalink / raw)
To: Power, Ciara, dev; +Cc: Doherty, Declan, aconole, gakhil
> -----Original Message-----
> From: Power, Ciara <ciara.power@intel.com>
> Sent: Tuesday, May 18, 2021 3:20 PM
> To: dev@dpdk.org
> Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>; aconole@redhat.com; gakhil@marvell.com;
> Power, Ciara <ciara.power@intel.com>
> Subject: [PATCH] test/crypto: fix test status when PMD isn't loaded
>
> The return value for a test when the required PMD is not loaded should
> be TEST_SKIPPED, rather than TEST_FAILED.
>
> Fixes: 8bfdd8a7f0f1 ("test/crypto: refactor to use sub test suites")
>
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> ---
> 2.25.1
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] test/crypto: fix test status when PMD isn't loaded
2021-05-18 14:37 ` Zhang, Roy Fan
@ 2021-05-19 8:32 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2021-05-19 8:32 UTC (permalink / raw)
To: Power, Ciara; +Cc: dev, Doherty, Declan, aconole, gakhil, Zhang, Roy Fan
> > The return value for a test when the required PMD is not loaded should
> > be TEST_SKIPPED, rather than TEST_FAILED.
> >
> > Fixes: 8bfdd8a7f0f1 ("test/crypto: refactor to use sub test suites")
> >
> > Signed-off-by: Ciara Power <ciara.power@intel.com>
>
> Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-19 8:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-18 14:19 [dpdk-dev] [PATCH] test/crypto: fix test status when PMD isn't loaded Ciara Power
2021-05-18 14:37 ` Zhang, Roy Fan
2021-05-19 8:32 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).