From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 8224B2BE5 for ; Wed, 28 Mar 2018 11:34:03 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 036E1813F73E; Wed, 28 Mar 2018 09:34:03 +0000 (UTC) Received: from [10.36.112.44] (ovpn-112-44.ams2.redhat.com [10.36.112.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 29CAD215CDC6; Wed, 28 Mar 2018 09:34:00 +0000 (UTC) To: "Wodkowski, PawelX" , "Kulasek, TomaszX" , "yliu@fridaylinux.org" Cc: "Verkamp, Daniel" , "Harris, James R" , "dev@dpdk.org" , "Liu, Changpeng" , "Tan, Jianfeng" References: <20180327151737.6640-1-tomaszx.kulasek@intel.com> <20180327153500.10464-1-tomaszx.kulasek@intel.com> <6c556086-bccc-1e55-d490-c21bcc8a6c4b@redhat.com> From: Maxime Coquelin Message-ID: <3637fba9-b6a9-2771-995b-6f1a9c5ff927@redhat.com> Date: Wed, 28 Mar 2018 11:33:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Wed, 28 Mar 2018 09:34:03 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Wed, 28 Mar 2018 09:34:03 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v2] vhost: add virtio configuration space messages X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2018 09:34:03 -0000 On 03/28/2018 11:19 AM, Wodkowski, PawelX wrote: >> -----Original Message----- >> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com] >> Sent: Wednesday, March 28, 2018 11:12 AM >> To: Kulasek, TomaszX ; yliu@fridaylinux.org >> Cc: Verkamp, Daniel ; Harris, James R >> ; Wodkowski, PawelX >> ; dev@dpdk.org; Liu, Changpeng >> ; Tan, Jianfeng >> Subject: Re: [dpdk-dev] [PATCH v2] vhost: add virtio configuration space >> messages >> >> >> >> On 03/27/2018 05:35 PM, Tomasz Kulasek wrote: >>> This patch adds new vhost user messages GET_CONFIG and SET_CONFIG used >>> for get/set virtio device's configuration space. >>> >>> Signed-off-by: Changpeng Liu >>> Signed-off-by: Tomasz Kulasek >>> --- >>> Changes in v2: >>> - code cleanup >>> >>> lib/librte_vhost/rte_vhost.h | 4 ++++ >>> lib/librte_vhost/vhost_user.c | 22 ++++++++++++++++++++++ >>> lib/librte_vhost/vhost_user.h | 16 ++++++++++++++++ >>> 3 files changed, 42 insertions(+) >>> >>> diff --git a/lib/librte_vhost/rte_vhost.h b/lib/librte_vhost/rte_vhost.h >>> index d332069..fe30518 100644 >>> --- a/lib/librte_vhost/rte_vhost.h >>> +++ b/lib/librte_vhost/rte_vhost.h >>> @@ -84,6 +84,10 @@ struct vhost_device_ops { >>> int (*new_connection)(int vid); >>> void (*destroy_connection)(int vid); >>> >>> + int (*get_config)(int vid, uint8_t *config, uint32_t config_len); >>> + int (*set_config)(int vid, uint8_t *config, uint32_t offset, >>> + uint32_t len, uint32_t flags); >>> + >>> void *reserved[2]; /**< Reserved for future extension */ >> >> You are breaking the ABI, as you grow the size of the ops struct. >> >> Also, I'm wondering if we shouldn't have a different ops for external >> backends. Here these ops are more intended to the application, we could >> have a specific ops struct for external backends IMHO. > > What do mean by "external backends" ? Libs like SPDK or Crypto that implements their own ring processing, comparing to an application like DPDK that doesn't care of rings details.