From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 4FC1D1B274 for ; Thu, 1 Nov 2018 23:53:04 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BD0DC22180; Thu, 1 Nov 2018 18:53:03 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 01 Nov 2018 18:53:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=ZH17x5DGLePAT4d07ooP9MWnzKsCrnSovvyNsZD3H9A=; b=FFXaoOJE4f5H 3Wx1gssQoQpSouv93PQam3cZvFWYFFXrTf3EIVOr1o8xFfR7tLpdnzh6w7WOfVGn lUG/z81gUSTodYGd0CdBhjuPDVW/2oc/Dbee6NQ+dDL2QKtCyTAD/p/ojAbi0i8d H0pgQPkiGwAURp7nYUOSoSGA2JgrRQI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=ZH17x5DGLePAT4d07ooP9MWnzKsCrnSovvyNsZD3H 9A=; b=FqoLpxPKZyOVSyFKlBMoHDT33GK732DPmFmb4KQXQ0dUrMu76KFRyCWp4 OXmAupVvfH58BkR5jPOV8BU6vOun6tDeZNOA4WiTIlFjN4jg2gL64zpO0GiHhibY A+1tmeDtYXWso7oyn2AXlv4YuM63a7Zk7QS1+3B/1w/RNPn5ZFwBkxiPFyu+y4+E FM66i5Qcoey/p2zZCksNtmUemvA+T0CTWkIpzwtIjMiA9A+K1YOzvH+tsOB7phEO C6mJNyDzvbwivhRMd0yCeljJk6eL/Wk965kGbpzDWDQTM0X5pKhH5UHq868VcGvo NrALHoanqd9x1JjJddm0PB7yoYnSg== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0D8CAE427A; Thu, 1 Nov 2018 18:53:01 -0400 (EDT) From: Thomas Monjalon To: Neil Horman Cc: dev@dpdk.org, doucette@bu.edu Date: Thu, 01 Nov 2018 23:53:00 +0100 Message-ID: <3649242.bmXl2ZTEod@xps> In-Reply-To: <20181101135410.15945-1-nhorman@tuxdriver.com> References: <20181101135410.15945-1-nhorman@tuxdriver.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] check-symbol-change: fix regex to match on end of map file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Nov 2018 22:53:04 -0000 01/11/2018 14:54, Neil Horman: > the regex to determine the end of the map file chunk in a patch seems to > be wrong, It was using perl regex syntax, which awk doesn't appear to > support (I'm still not sure how it was working previously). Regardless, > it wasn't triggering and as a result symbols were getting added to the > mapdb that shouldn't be there. > > Fix it by converting the regex to use traditional posix syntax, matching > only on the negation of the character class [^map] > > Tested and shown to be working on the ip_frag patch set provided by > doucette@bu.edu > > Signed-off-by: Neil Horman > CC: thomas@monjalon.net > CC: doucette@bu.edu > Reported-by: doucette@bu.edu You could use these lines: Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") Reported-by: Cody Doucette > --- a/devtools/check-symbol-change.sh > +++ b/devtools/check-symbol-change.sh > - /[-+] a\/.*\.^(map)/ {in_map=0} > + /[-+] a\/.*\.[^map]/ {in_map=0} Not sure this is what you intend: [^map] means any character except "m", "a" and "p". I don't know whether awk supports this syntax: (?!foo)