From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 993AAA0352; Tue, 8 Feb 2022 18:41:25 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8B7E241140; Tue, 8 Feb 2022 18:41:25 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 96F084111B for ; Tue, 8 Feb 2022 18:41:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644342083; x=1675878083; h=message-id:date:to:references:from:subject:in-reply-to: content-transfer-encoding:mime-version; bh=QTJecgaYDmk/ACXPqFRvwFdLE5vemcxDxMDe5olV53g=; b=ADTHk+UfiN/4VDgaWWH95BDxAU1fP2zE2FDqw3dtfHf8H1W25NcihSps 7RDTyCp8X6P79ez4v+EubmuM/JBFmPzzawXTYla9J4SIDnDLMuTjakmiP XQd1UziQVfvXkO2xx9yWTU9OSLjMUEruYBluIdqzXKOexREWXJejeOaNu 8w8rVI7BY1p/monNvEJ8b7bU6wRRH5btm+VGjt+xcMtCi+lJQH4gaI1QF Po2OBmQLEE8S4PeYIIxlG91zOBdNv71hEf/VjKLzEj+Ao1VKN/XA2PJMV GFrlerzpsrKhZEJZhsRHz4FYR8AqkJ/rDJofxm2jOLQhbEYXohxWlyPMY Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10252"; a="248954504" X-IronPort-AV: E=Sophos;i="5.88,353,1635231600"; d="scan'208";a="248954504" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2022 09:41:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,353,1635231600"; d="scan'208";a="601316783" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga004.fm.intel.com with ESMTP; 08 Feb 2022 09:41:14 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 8 Feb 2022 09:41:13 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 8 Feb 2022 09:41:13 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 8 Feb 2022 09:41:12 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TqDYiYRruUtkAIlCet7uSyjqIEM0UqTTfYLQF8N2eharZE7oRB0IDY6DE4RGME2FPo3Ld38oUsgC++7+GYT/e8wZ8WUcV8AIz1AERoIi/6Mq5VrLh9RF+Kaezks3TGXl8IkzIRbSBh+wYUiUUnVk/ZoUNfhUnB0n1qZ8/tPvNXOWxw5bSEPNBFf2uwbo0RH3u3ZcC7OMPmxUVCuBG46Lak8YEhQ/JxQyTI9uyhvg0STWyYbUh37SZTsP0csz2CVgNgr1rtG6R1fyuiu25bQ3I+XGbgyliZZrdXS/Q1rh6PdnPD3yuxBx/GkSxw8o7Yc6eL9i8hcS0jn0O5xndyC7Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5akZxFcJQX5d8eU79YV3oynADWLW0Fas2/27fl+qMXI=; b=mvWWLpS2nGnjp2pNOWHzZYPGzY9EstCDE6bu9PTaWjKKALxEVNoJ6djLhyVKRnwiA0VVLJpE5y0uIvMxj9mKn5YAPJ1B+elW0CErWhfqfuStc9y4674O79Z8MYbu+G/T28rKGLQ2XHpu0HTVz8VCcLXGBm5ATzPyv6nvIe5dUlPclPsfxwBgG8GgHv+54gJXivjNUOI/MEDgByc+VUutJDTHw/D53zEfauvGchn0rYOYuPiDfY8UXzpIeZEmSbXG1gkKwmB4GRLAAKkhqncCcDWs7agQ0U7O/+SN+zpTi41VeE6jMJLljEah6uAxp0NnQlKcK7Cwu6tskyMMeOeWCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by DM6PR11MB4217.namprd11.prod.outlook.com (2603:10b6:5:1de::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Tue, 8 Feb 2022 17:41:10 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022 17:41:09 +0000 Message-ID: <364cf5b8-d20e-8825-52c1-f8efca740826@intel.com> Date: Tue, 8 Feb 2022 17:41:04 +0000 Content-Language: en-US To: Jiawen Wu , References: <20220208101129.69173-1-jiawenwu@trustnetic.com> <20220208101129.69173-7-jiawenwu@trustnetic.com> From: Ferruh Yigit Subject: Re: [PATCH 6/9] net/ngbe: add support to custom PHY interfaces X-User: ferruhy In-Reply-To: <20220208101129.69173-7-jiawenwu@trustnetic.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0436.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::16) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9a5d3720-3472-40cb-ba5e-08d9eb2a3131 X-MS-TrafficTypeDiagnostic: DM6PR11MB4217:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3631; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /sg68nNOBKvCYPVghifOZZzHiM+/AR4DU9R8HJcyyJ7bYDAG1bnIWMj/waV9DUGnKXxyoNjJDTJSH6g2HV7g2nrbydwDOq8oI7Qy8np7ovGwMZNGNSvnKaDVhue//rV1ZMLyostjnxGRnMVC1T1w7VMzpO5Ch4lw9YHsh/FqOJCe+dDnfyNlageHxXvUYXXsWTTqa/8mJE5TfWuGl0A7/7CCDohh2+GiCBi52N79cYNRKOOBqX9hEwO4KAbZ/qsNmumTbIpu/4oDhV/Nf4KAaqNCfTGvqDNo6MFs9Dgu6OTTHR1CEQywk5tnOMn7UJBxtYBa9r5CUKfJyxL0gnbm0Wtuw/P5zx+dowC1ljYBOnAvqQxPe2h5w1wg2bFtX0xS2lwlJPN9oTHqPHKodCgEy9+WeAVliVEQEZ5tOk3eBKYrg1/WSrpmA+p9sDjHxugWtUxjxjAUq0LMo31i06srekkIXavIAt8tPWxg6txnI+zVyqcHiTEpIknCrRgiWOedvaVbKJ6L8FJ4t2G/mtcHEEo6WDdZ+26Pizq6LYXjCtaVv+T5NqzrDpiq+pJh2D7Xt6zp9lmxfoySoGWVyWz9gCKVPAu7IAW+FTEsNwS81OAA5DD4nh/2rHeaS+bOYQhvknfpLl6xz3+jmv7W9z9ZOi8h4Z2lSc7/MMua9Clj7fPrPiGo3HL94KmNZ522agCTieyZ3CvOG1SM3nvg1tdGXd4bIt3ofrlNEDGjtwiOIm1OQbjHPLpmMYSN//K1uYO7FWQH7fDM6igFTDpqa3Myp5CgDjruyWMxlpwriIDC/y8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(44832011)(5660300002)(26005)(86362001)(6506007)(316002)(66476007)(36756003)(31696002)(2906002)(6666004)(55236004)(53546011)(6512007)(966005)(6486002)(2616005)(66946007)(8676002)(8936002)(82960400001)(508600001)(31686004)(66556008)(38100700002)(83380400001)(186003)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VzBuMnNTKzk5TTFwYXV4WnpKNDlYSHhYMTgvRThZMnZhNGh0VlBFR0RXUXYr?= =?utf-8?B?NHhUYnpyaFhKVzFPSFNXMDc1QkFXb2kwZ0JEdEo0ZHV3dmNNSi9mdENvd0dK?= =?utf-8?B?R2duVW1XaXhlNEM1OE9ZTW94cWtkSm8rakJwcmRFa0U1M2pnNVluU0tEMUdl?= =?utf-8?B?WkRUeVZwNHpzWkVMYnpXRkpIV1drN1dQVnpaVGVRaHp0c2FsOTA1SEMvbEEv?= =?utf-8?B?WjErelpIa0ZabFN4dmpGcE1kWnBlR0FGZ3VvdjlXTHRqaldWaHZhRnRiZ2Rt?= =?utf-8?B?Y01UMHFSdlpBa1ZsYmdJeVd5SnJoa0kxdWE4V25RRUQ4WUY3NzQwbzVkaTVF?= =?utf-8?B?N0NOckhpRW56UHlacGZ2b3RJb0JFcnFBTWRqdDFJQm1pRit3OUU0ek94Ukg3?= =?utf-8?B?MmM3UFhmVHpiSFlxUGJhclZ0SWtuSVB6b0dvRi9wektzSGZaRWtrT0crU011?= =?utf-8?B?Mzd5SnM2ekNtWHplQ3Rna09BSmdBN0xMYmZUWGw4ZHBwdTZoWG4wdldlRjdH?= =?utf-8?B?cVUrL21wMzI4Rmo5cFgvSkVDUEd5cllyR1BEZUxqSHRYN2l4a1VhS2FWZnZl?= =?utf-8?B?eVI1c3cyRjFmcDFBYjZ0SThxMTBWOVdEK0xZT3ZFRzEwaHQ2TU9OemkvSFln?= =?utf-8?B?VVNjWVhzMkZVTVIrOW9IQ0ZDODM4cCtLNWJOclZDbTljUFlqVGk3WVlURVkz?= =?utf-8?B?aEFsZnlIeHJtbXRrWmZRTVRmSVlRZy95NnYwYWh3V2s1YXl5amtYNzNBTmRh?= =?utf-8?B?YVl3UFl1ZDFXK3lTWm9XTU5ONnRoMURpVEc5YUJPVjdlK1gxY1R3eGhxS3VL?= =?utf-8?B?ZWc4VEtPOE1EMFYrK1hod1p4RGo0VjBpSnl5U0pBbnNiaTNkZzJ4VFlTRWYx?= =?utf-8?B?OGVkQkJldWdRVnlyK0k5SDc5aDZqejFXOTVLeHJTVjJQTFphK0IxMk5BMStN?= =?utf-8?B?anVsQ3dxRXY1bVRPS3lhRWtXS0pNeitUWmpMa3VoTnJaWWdGTEhBa2FrWFpL?= =?utf-8?B?RTNpMDVxS2RrdFRJbmVuOWNoaUE3OFU5VEI3UTM5Q1lhS0szNFllRms0ZUpF?= =?utf-8?B?QTVxZk41QVNNZklJNmRBeWlOdUZDREZXQndsR1R0Q2RPeTNQazFOODRaalc4?= =?utf-8?B?dGN2aldibFZxcnBSZWJZaDQrNitSV0ZQT2RJUzZsOXZlclFhYURkWTQvMVFC?= =?utf-8?B?NC9Zdm1rUlA5SU5HUUpSR2NVaGI1Rm1wV1Z4aHZ3NG1FK1JHUjJwRVdGMTR4?= =?utf-8?B?ZHBncS9GYk9MOVIxcnlKa0dxUElQMTZUUy9rY3ZLRGRzK3ZxUDhwZFluTWs1?= =?utf-8?B?SVBVbUtMQ29UTXVRWGlBVjlURjF2S3FCSGU5VmpiRHB0Q1ZDK0pQOXZ6RTln?= =?utf-8?B?V1JVQTNaaUY3ek41U1FZN1JOWlZxclIxTU95UXFkN085Y3J1SVl4V2Fmc1Js?= =?utf-8?B?VGt2L2s3R1liS0JQRWpncVFtYTlwbXpaSis4MXdIVU1SS0V6NXpoUmdxVytV?= =?utf-8?B?c0ozVWlQMDNkRDgvYXNzK2dJYjlQSEwzS1lWODdmS0I3Rkh3MkdQRCtmOFMz?= =?utf-8?B?SWRHSjVja01ZOVRVeFVYQU5IeUlFNi9HTjJSbnFzRTZNblY1Lzg2emUzVEZE?= =?utf-8?B?VHZ2TUlpN2k5YmhvUTBQZXdvaW1sOGFEc0t0UTY1MXNnaHRLYjIrc1BKYlpp?= =?utf-8?B?N3ZQSXAzcS9WUEZmRHhLRDVSWDhiSnk5ZDBVcitjZk8zNFpSTXVUWWFPa3h6?= =?utf-8?B?RCtRd0xybXJwRVVqZ0JDSXU2S25EMXVnaE1kVWNIVW5SNnNNVzZwMllFNHRn?= =?utf-8?B?aVEvbnIvZWtGYkloZHcyek9hYi9QTWRTMVgxcUVJd3JkcXppWWpiTnc0QVpW?= =?utf-8?B?bElZTXdpa29jait5eW1tWkZjUzBoU29KRW5vUXhCbTk0a0lsMkNrNHQ0WUZ2?= =?utf-8?B?U2dBSHpxS2oyYzFna0dxSG5XUXNLVlJHeXBUZS9xTzI4cjBxdWxsS0hqRXBr?= =?utf-8?B?NXg3WldUSW5NR1JiZkRYT05LY1pDZ0c4NzZRUm5pTzBwdGtLQjJGV29YWEdr?= =?utf-8?B?SXlKb2dHUmdlQm1WLzhlTlNNajJYVm5neE1uTHMyNE9UK21xcFBLVEUyRHYz?= =?utf-8?B?MGpYZmx0RlZoS2trbUZVQ3JGQW1wWk5aOGwzb05oUFBPQmJhVEZONVZSZGY3?= =?utf-8?Q?8UN8w8ux2Cr0iMg3HnBcVAA=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9a5d3720-3472-40cb-ba5e-08d9eb2a3131 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 17:41:09.8318 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IbPba5fKLVKIarTwKiFeq9aH5fVia8zY3nwAuGrUutFpAVE4qXLJubPoIjSi5fHVDH5h3CwbedIFsVsQoUuKZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4217 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/8/2022 10:11 AM, Jiawen Wu wrote: > Support sub_device ID 61/62/64 for YT8521S SFP, and 51/52 for M88E1512 > PHY. > > Signed-off-by: Jiawen Wu <...> > @@ -69,6 +69,10 @@ New Features > * Added AES-XCBC support in lookaside protocol (IPsec) for CN9K & CN10K. > * Added AES-CMAC support in CN9K & CN10K. > > +* **Updated Wangxun ngbe driver.** > + > + * Added support for devices of custom PHY interfaces. > + "Custom PHY" is vague, should we provide more details on added PHY interfaces, like code names etc.... <...> > @@ -1815,11 +1816,23 @@ s32 ngbe_set_mac_type(struct ngbe_hw *hw) > case NGBE_SUB_DEV_ID_EM_MVL_RGMII: > hw->phy.media_type = ngbe_media_type_copper; > hw->mac.type = ngbe_mac_em; > + hw->mac.link_type = ngbe_link_copper; > + break; > + case NGBE_SUB_DEV_ID_EM_RTL_YT8521S_SFP: > + hw->phy.media_type = ngbe_media_type_copper; > + hw->mac.type = ngbe_mac_em; > + hw->mac.link_type = ngbe_link_fiber; > break; > case NGBE_SUB_DEV_ID_EM_MVL_SFP: > case NGBE_SUB_DEV_ID_EM_YT8521S_SFP: > hw->phy.media_type = ngbe_media_type_fiber; > hw->mac.type = ngbe_mac_em; > + hw->mac.link_type = ngbe_link_fiber; > + break; > + case NGBE_SUB_DEV_ID_EM_MVL_MIX: > + hw->phy.media_type = ngbe_media_type_unknown; > + hw->mac.type = ngbe_mac_em; > + hw->mac.link_type = ngbe_media_type_unknown; This gives build error [1] because assigned enum type is wrong, is this copy/paste error? ../drivers/net/ngbe/base/ngbe_hw.c: In function ‘ngbe_set_mac_type’: ../drivers/net/ngbe/base/ngbe_hw.c:1835:35: error: implicit conversion from ‘enum ngbe_media_type’ to ‘enum ngbe_link_type’ [-Werror=enum-conversion] 1835 | hw->mac.link_type = ngbe_media_type_unknown; | [1] http://mails.dpdk.org/archives/test-report/2022-February/257750.html <...> > +s32 ngbe_check_phy_mode_mvl(struct ngbe_hw *hw) > +{ > + u16 value = 0; > + > + /* select page 18 reg 20 */ > + ngbe_write_phy_reg_mdi(hw, MVL_PAGE_SEL, 0, 18); > + ngbe_read_phy_reg_mdi(hw, MVL_GEN_CTL, 0, &value); > + if (MVL_GEN_CTL_MODE(value) == MVL_GEN_CTL_MODE_COPPER) { > + /* mode select to RGMII-to-copper */ > + hw->phy.type = ngbe_phy_mvl; > + hw->phy.media_type = ngbe_media_type_copper; > + hw->mac.link_type = ngbe_link_copper; > + } else if (MVL_GEN_CTL_MODE(value) == MVL_GEN_CTL_MODE_FIBER) { > + /* mode select to RGMII-to-sfi */ > + hw->phy.type = ngbe_phy_mvl_sfi; > + hw->phy.media_type = ngbe_media_type_fiber; > + hw->mac.link_type = ngbe_link_fiber; > + } else { > + DEBUGOUT("marvell 88E1512 mode %x is not supported.\n", value); 'DEBUGOUT' already adds '\n' as far as I can see, it log add double line. There are multiple usages in this patch.