Hi David:

Thanks for your notifications. I will check them in the future work.

Trevor Tao




At 2023-10-13 15:07:03, "David Marchand" <david.marchand@redhat.com> wrote: >Hello, > >On Fri, Oct 13, 2023 at 6:28 AM Trevor Tao <taozj888@163.com> wrote: >> >> This series tries to relax l3fwd rx RSS/Offload mode requirement if they >> are not supported by underlying hw or virtual devices, there is an >> option named relax_rx_mode added to enable this option. >> >> Trevor Tao (3): >> examples/l3fwd: relax RSS requirement with option >> examples/l3fwd: relax the Offload requirement >> doc: add a relax rx mode requirement option >> >> doc/guides/rel_notes/release_23_11.rst | 251 +++++++++++++++++++++--- >> doc/guides/sample_app_ug/l3_forward.rst | 4 +- >> examples/l3fwd/l3fwd.h | 12 +- >> examples/l3fwd/l3fwd_em.h | 2 +- >> examples/l3fwd/l3fwd_lpm.h | 2 +- >> examples/l3fwd/main.c | 30 +++ >> 6 files changed, 272 insertions(+), 29 deletions(-) > >Thanks for the patches. >One comment on the form though. > >I see 4 batches of "v2 patches" in patchwork. >https://patchwork.dpdk.org/project/dpdk/list/?submitter=3044&state=* >I marked all but the last batch as superseded. >If there is something wrong with this, please register to patchwork >with your mail address, you will then be able to update the states >yourself. > > >It is hard to follow what work has been done between those different >iterations of patches. >For future submissions, don't forget to version your patches with a >new revision (iirc, we should be at version 7 if I count the initial >standalone v1 patch). > >In the cover letter, please provide a changelog of the differences >between revisions. >If you think it is better, you may put a more detailed changelog in >each patch commitlog (as annotations, after ---). > > >Thanks. > >-- >David Marchand