From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 2EE3B1BE9B for ; Wed, 4 Jul 2018 05:48:32 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jul 2018 20:48:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,306,1526367600"; d="scan'208";a="237690444" Received: from jguo15x-mobl3.ccr.corp.intel.com (HELO [10.67.68.88]) ([10.67.68.88]) by orsmga005.jf.intel.com with ESMTP; 03 Jul 2018 20:48:26 -0700 To: Thomas Monjalon References: <1498711073-42917-1-git-send-email-jia.guo@intel.com> <07fb8f04-adee-fd0e-05b5-8d1bcca1338d@intel.com> <2612071.aGzFhBPpOt@xps> Cc: dev@dpdk.org, Matan Azrad , "stephen@networkplumber.org" , "bruce.richardson@intel.com" , "ferruh.yigit@intel.com" , "konstantin.ananyev@intel.com" , "gaetan.rivet@6wind.com" , "jingjing.wu@intel.com" , Mordechay Haimovsky , "harry.van.haaren@intel.com" , "qi.z.zhang@intel.com" , "shaopeng.he@intel.com" , "bernard.iremonger@intel.com" , "shreyansh.jain@nxp.com" , "helin.zhang@intel.com" From: "Guo, Jia" Message-ID: <365be70b-3896-6f5c-51cf-f1a5ce279063@intel.com> Date: Wed, 4 Jul 2018 11:48:19 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <2612071.aGzFhBPpOt@xps> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH V4 8/9] app/testpmd: show example to handle hot unplug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jul 2018 03:48:33 -0000 hi, thomas On 7/4/2018 6:44 AM, Thomas Monjalon wrote: > 03/07/2018 11:35, Guo, Jia: >> On 7/1/2018 3:46 PM, Matan Azrad wrote: >>> From: Jeff Guo >>>> --- a/app/test-pmd/testpmd.c >>>> +++ b/app/test-pmd/testpmd.c >>>> @@ -2206,9 +2209,12 @@ eth_dev_event_callback(char *device_name, enum >>>> rte_dev_event_type type, >>>> case RTE_DEV_EVENT_REMOVE: >>>> RTE_LOG(ERR, EAL, "The device: %s has been removed!\n", >>>> device_name); >>>> - /* TODO: After finish failure handle, begin to stop >>>> - * packet forward, stop port, close port, detach port. >>>> - */ >>>> + ret = rte_eth_dev_get_port_by_name(device_name, &port_id); >>> As you probably know, 1 rte_device may be associated to more than one ethdev ports, so the ethdev port name can be different from rte_device name. >>> Looks like we need a new ethdev API to get all the ports associated to one rte_device. >> agree, seems that the the old ethdev API have some issue when got all >> port by device name. we could check with ethdev maintainer and fix it by >> specific ethdev patch later. > This ethdev function could return an error if several ports match. > > Ideally, we should not use this function at all. > If you want to manage an ethdev port, why are you using an EAL event? > There is an ethdev callback mechanism for port removal. > > i think the problem is that how to manage all ethdev port associated with one rte_device. So the easy way is let device event callback to check these ports. I will modify it in next version.