From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 0AB2F5F1B for ; Thu, 11 Apr 2019 10:43:32 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id C0C1E940054; Thu, 11 Apr 2019 08:43:30 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 11 Apr 2019 09:43:20 +0100 To: Thomas Monjalon , CC: , Chas Williams , Hemant Agrawal , Shreyansh Jain , Wenzhuo Lu , Matan Azrad , Shahaf Shuler , Rasesh Mody , Shahed Shaikh , Tomasz Duszynski , Liron Himi , Alan Winkowski , Jasvinder Singh , Cristian Dumitrescu References: <8025349.HGM0LRMdJy@xps> From: Andrew Rybchenko Message-ID: <366feb0e-cb95-5520-7daf-665818085d8c@solarflare.com> Date: Thu, 11 Apr 2019 11:43:17 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <8025349.HGM0LRMdJy@xps> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24544.003 X-TM-AS-Result: No-15.305700-8.000000-10 X-TMASE-MatchedRID: UuaOI1zLN1gOwH4pD14DsPHkpkyUphL99p2lk/q5LLrb6Y+fnTZUL80J wDpl3OPvFrWw8IJlURsyy1N8n/3eDF+FEY5pP0i/vJsORwCzNhE4gG1vqBBN+JsfQQp16jP3NUI c8ma/DM/rUWEjTM9FINMRv+b57d0FZSU6HajahM4QDf0hTLXhcSmkZgwpl7M3gB9jdxVa+8mstL 0AohSuUA+I8OroL5/1uNs11xgvqklSc/4Nzhfn3IlD2T5imTkJ9ISHwCrIdS/7VllL9lCtVfNO7 flRFqXmIGSHKu90xKWSU848M/hs6Me4Woyb+kVFyDp+jSvEtWsl3afZehJEWedlU2K5Jm9bLMlY avN/+VI1Nxz4Ua0cvf++gjOGfzBm5UcZtwNsCro5f9Xw/xqKXVkMvWAuahr8+gD2vYtOFhi8mof WgmFAh1EuC/aAOchpW+WUwDLjAJQoK0cSTOR6nO3E3gjUP2XtgsyuhHhl+96me6+z4iaRR+qz/S kemIA2xlh3SuL105yA1peDapq1Aw== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--15.305700-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24544.003 X-MDID: 1554972212-uchtTUxrZAAJ Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] ethdev flow director/filtering/steering API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Apr 2019 08:43:33 -0000 On 4/11/19 10:49 AM, Thomas Monjalon wrote: > About the features called flow director, filtering or flow steering, > we have some overlap in our API that we should clean. > It is especially important when considering to freeze the API for stability. > > Please read this deprecation notice from December 2016: > > * ethdev: the legacy filter API, including > ``rte_eth_dev_filter_supported()``, ``rte_eth_dev_filter_ctrl()`` as well > as filter types MACVLAN, ETHERTYPE, FLEXIBLE, SYN, NTUPLE, TUNNEL, FDIR, > HASH and L2_TUNNEL, is superseded by the generic flow API (rte_flow) in > PMDs that implement the latter. > Target release for removal of the legacy API will be defined once most > PMDs have switched to rte_flow. > > We must mark the eth_dev_filter API as deprecated and decide about > a date to remove it. > > Which PMD is implementing this API and not rte_flow? In accordance with feature matrix is it i40e_vec, ixgbe_vec and qede, but I think it is just a mistake in documentation. Flow API support tick is missing for many PMDs which actually implement (as far as I can see): bonding, dppa2, e100, mlx4, qede, mvpp2, softnic. I've added maintainers to CC. > If there are still some, deadlines should help them to be converted :) > If some help is needed, please ask. > > Anyway, after more than 2 years of notice, I think it is fair to mark > the legacy API as deprecated in 19.05 release. I agree. I think it is a good idea. Andrew. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 7B4B0A0096 for ; Thu, 11 Apr 2019 10:43:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DF6C95F21; Thu, 11 Apr 2019 10:43:34 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 0AB2F5F1B for ; Thu, 11 Apr 2019 10:43:32 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id C0C1E940054; Thu, 11 Apr 2019 08:43:30 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 11 Apr 2019 09:43:20 +0100 To: Thomas Monjalon , CC: , Chas Williams , Hemant Agrawal , Shreyansh Jain , Wenzhuo Lu , Matan Azrad , Shahaf Shuler , Rasesh Mody , Shahed Shaikh , Tomasz Duszynski , Liron Himi , Alan Winkowski , Jasvinder Singh , Cristian Dumitrescu References: <8025349.HGM0LRMdJy@xps> From: Andrew Rybchenko Message-ID: <366feb0e-cb95-5520-7daf-665818085d8c@solarflare.com> Date: Thu, 11 Apr 2019 11:43:17 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <8025349.HGM0LRMdJy@xps> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24544.003 X-TM-AS-Result: No-15.305700-8.000000-10 X-TMASE-MatchedRID: UuaOI1zLN1gOwH4pD14DsPHkpkyUphL99p2lk/q5LLrb6Y+fnTZUL80J wDpl3OPvFrWw8IJlURsyy1N8n/3eDF+FEY5pP0i/vJsORwCzNhE4gG1vqBBN+JsfQQp16jP3NUI c8ma/DM/rUWEjTM9FINMRv+b57d0FZSU6HajahM4QDf0hTLXhcSmkZgwpl7M3gB9jdxVa+8mstL 0AohSuUA+I8OroL5/1uNs11xgvqklSc/4Nzhfn3IlD2T5imTkJ9ISHwCrIdS/7VllL9lCtVfNO7 flRFqXmIGSHKu90xKWSU848M/hs6Me4Woyb+kVFyDp+jSvEtWsl3afZehJEWedlU2K5Jm9bLMlY avN/+VI1Nxz4Ua0cvf++gjOGfzBm5UcZtwNsCro5f9Xw/xqKXVkMvWAuahr8+gD2vYtOFhi8mof WgmFAh1EuC/aAOchpW+WUwDLjAJQoK0cSTOR6nO3E3gjUP2XtgsyuhHhl+96me6+z4iaRR+qz/S kemIA2xlh3SuL105yA1peDapq1Aw== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--15.305700-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24544.003 X-MDID: 1554972212-uchtTUxrZAAJ Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] ethdev flow director/filtering/steering API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190411084317.e4Tui_yzZosuiBTZo2XuPrfMlqxC03AvR_R7iBPNjNs@z> On 4/11/19 10:49 AM, Thomas Monjalon wrote: > About the features called flow director, filtering or flow steering, > we have some overlap in our API that we should clean. > It is especially important when considering to freeze the API for stability. > > Please read this deprecation notice from December 2016: > > * ethdev: the legacy filter API, including > ``rte_eth_dev_filter_supported()``, ``rte_eth_dev_filter_ctrl()`` as well > as filter types MACVLAN, ETHERTYPE, FLEXIBLE, SYN, NTUPLE, TUNNEL, FDIR, > HASH and L2_TUNNEL, is superseded by the generic flow API (rte_flow) in > PMDs that implement the latter. > Target release for removal of the legacy API will be defined once most > PMDs have switched to rte_flow. > > We must mark the eth_dev_filter API as deprecated and decide about > a date to remove it. > > Which PMD is implementing this API and not rte_flow? In accordance with feature matrix is it i40e_vec, ixgbe_vec and qede, but I think it is just a mistake in documentation. Flow API support tick is missing for many PMDs which actually implement (as far as I can see): bonding, dppa2, e100, mlx4, qede, mvpp2, softnic. I've added maintainers to CC. > If there are still some, deadlines should help them to be converted :) > If some help is needed, please ask. > > Anyway, after more than 2 years of notice, I think it is fair to mark > the legacy API as deprecated in 19.05 release. I agree. I think it is a good idea. Andrew.