* [dpdk-dev] [PATCH] eal/ppc: fix rte_smp_mb for a compilation error with else clause
@ 2018-02-27 15:13 Gowrishankar
2018-02-27 17:12 ` [dpdk-dev] [dpdk-stable] " Luca Boccassi
2018-02-28 9:56 ` [dpdk-dev] " Chao Zhu
0 siblings, 2 replies; 4+ messages in thread
From: Gowrishankar @ 2018-02-27 15:13 UTC (permalink / raw)
To: dev; +Cc: Chao Zhu, stable, thomas, Gowrishankar Muthukrishnan
From: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
This patch fixes the compilation problem with rte_smp_mb,
when there is else clause following it, as in test_barrier.c.
Fixes: 05c3fd7110 ("eal/ppc: atomic operations for IBM Power")
Cc: stable@dpdk.org
Signed-off-by: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
---
lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h b/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h
index 39fce7b..1821774 100644
--- a/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h
+++ b/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h
@@ -55,7 +55,7 @@
* Guarantees that the LOAD and STORE operations generated before the
* barrier occur before the LOAD and STORE operations generated after.
*/
-#define rte_mb() {asm volatile("sync" : : : "memory"); }
+#define rte_mb() asm volatile("sync" : : : "memory")
/**
* Write memory barrier.
--
1.9.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] eal/ppc: fix rte_smp_mb for a compilation error with else clause
2018-02-27 15:13 [dpdk-dev] [PATCH] eal/ppc: fix rte_smp_mb for a compilation error with else clause Gowrishankar
@ 2018-02-27 17:12 ` Luca Boccassi
2018-02-28 9:56 ` [dpdk-dev] " Chao Zhu
1 sibling, 0 replies; 4+ messages in thread
From: Luca Boccassi @ 2018-02-27 17:12 UTC (permalink / raw)
To: Gowrishankar, dev; +Cc: Chao Zhu, stable, thomas
On Tue, 2018-02-27 at 20:43 +0530, Gowrishankar wrote:
> From: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
>
> This patch fixes the compilation problem with rte_smp_mb,
> when there is else clause following it, as in test_barrier.c.
>
> Fixes: 05c3fd7110 ("eal/ppc: atomic operations for IBM Power")
> Cc: stable@dpdk.org
>
> Signed-off-by: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.
> ibm.com>
> ---
> lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h
> b/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h
> index 39fce7b..1821774 100644
> --- a/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h
> +++ b/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h
> @@ -55,7 +55,7 @@
> * Guarantees that the LOAD and STORE operations generated before
> the
> * barrier occur before the LOAD and STORE operations generated
> after.
> */
> -#define rte_mb() {asm volatile("sync" : : : "memory"); }
> +#define rte_mb() asm volatile("sync" : : : "memory")
>
> /**
> * Write memory barrier.
Acked-by: Luca Boccassi <bluca@debian.org>
Maintainers and reviewers, 18.02 build on ppc64 is currently broken and
I'd like to backport this patch to Debian ASAP and then backport to
16.11, so a quick review would be much much appreciated. Thank you!
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] eal/ppc: fix rte_smp_mb for a compilation error with else clause
2018-02-27 15:13 [dpdk-dev] [PATCH] eal/ppc: fix rte_smp_mb for a compilation error with else clause Gowrishankar
2018-02-27 17:12 ` [dpdk-dev] [dpdk-stable] " Luca Boccassi
@ 2018-02-28 9:56 ` Chao Zhu
2018-03-13 23:08 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
1 sibling, 1 reply; 4+ messages in thread
From: Chao Zhu @ 2018-02-28 9:56 UTC (permalink / raw)
To: 'Gowrishankar', dev; +Cc: stable, thomas
> -----Original Message-----
> From: Gowrishankar [mailto:gowrishankar.m@linux.vnet.ibm.com]
> Sent: 2018年2月27日 23:14
> To: dev@dpdk.org
> Cc: Chao Zhu <chaozhu@linux.vnet.ibm.com>; stable@dpdk.org;
> thomas@monjalon.net; Gowrishankar Muthukrishnan
> <gowrishankar.m@linux.vnet.ibm.com>
> Subject: [PATCH] eal/ppc: fix rte_smp_mb for a compilation error with else
> clause
>
> From: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
>
> This patch fixes the compilation problem with rte_smp_mb, when there is
else
> clause following it, as in test_barrier.c.
>
> Fixes: 05c3fd7110 ("eal/ppc: atomic operations for IBM Power")
> Cc: stable@dpdk.org
>
> Signed-off-by: Gowrishankar Muthukrishnan
> <gowrishankar.m@linux.vnet.ibm.com>
> ---
> lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h
> b/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h
> index 39fce7b..1821774 100644
> --- a/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h
> +++ b/lib/librte_eal/common/include/arch/ppc_64/rte_atomic.h
> @@ -55,7 +55,7 @@
> * Guarantees that the LOAD and STORE operations generated before the
> * barrier occur before the LOAD and STORE operations generated after.
> */
> -#define rte_mb() {asm volatile("sync" : : : "memory"); }
> +#define rte_mb() asm volatile("sync" : : : "memory")
>
> /**
> * Write memory barrier.
> --
> 1.9.1
Acked-by: Chao Zhu <chaozhu@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] eal/ppc: fix rte_smp_mb for a compilation error with else clause
2018-02-28 9:56 ` [dpdk-dev] " Chao Zhu
@ 2018-03-13 23:08 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2018-03-13 23:08 UTC (permalink / raw)
To: 'Gowrishankar'; +Cc: stable, Chao Zhu, dev, bluca
> > This patch fixes the compilation problem with rte_smp_mb, when there is
> else
> > clause following it, as in test_barrier.c.
> >
> > Fixes: 05c3fd7110 ("eal/ppc: atomic operations for IBM Power")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Gowrishankar Muthukrishnan
> > <gowrishankar.m@linux.vnet.ibm.com>
> > ---
> Acked-by: Chao Zhu <chaozhu@linux.vnet.ibm.com>
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-03-13 23:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-27 15:13 [dpdk-dev] [PATCH] eal/ppc: fix rte_smp_mb for a compilation error with else clause Gowrishankar
2018-02-27 17:12 ` [dpdk-dev] [dpdk-stable] " Luca Boccassi
2018-02-28 9:56 ` [dpdk-dev] " Chao Zhu
2018-03-13 23:08 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).