From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22B99A2EDB for ; Tue, 1 Oct 2019 18:40:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4E6E51BE8B; Tue, 1 Oct 2019 18:40:06 +0200 (CEST) Received: from dispatchb-us1.ppe-hosted.com (dispatchb-us1.ppe-hosted.com [148.163.129.53]) by dpdk.org (Postfix) with ESMTP id F2A7C1BE89; Tue, 1 Oct 2019 18:40:04 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us2.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 41E51700090; Tue, 1 Oct 2019 16:40:03 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 1 Oct 2019 17:39:44 +0100 To: Kevin Traynor , Maxime Coquelin , Tiwei Bie , Zhihong Wang CC: , Dilshod Urazov , References: <1569944672-24754-1-git-send-email-arybchenko@solarflare.com> <4057f198-1faa-708e-bf60-075d53b92a97@redhat.com> From: Andrew Rybchenko Message-ID: <367532df-c496-5009-9bb9-03a7c8a98273@solarflare.com> Date: Tue, 1 Oct 2019 19:39:41 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <4057f198-1faa-708e-bf60-075d53b92a97@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24946.003 X-TM-AS-Result: No-3.401100-8.000000-10 X-TMASE-MatchedRID: O/y65JfDwwv4ECMHJTM/ufZvT2zYoYOwt3aeg7g/usDRLEyE6G4DROPd pDLFu49i4aBLis6ititQeza/snquaMx079ojRyOiuwdUMMznEA9LXPA26IG0hDdlsYL2g/87MH1 xx17eFtQcU3zG2Kw5DJTTUG6GazQ7b6wZx1ul0pyeAiCmPx4NwLTrdaH1ZWqC1B0Hk1Q1KyLUZx EAlFPo846HM5rqDwqtr6yaKvHF394SlcX77YLV8LmEXxuBc/iSuQgylVZIuVQyQYNwMhG2I2g2D NU3QL0E2soxF3gh/qBlJawu3vdi4BXia6r48vu/4vn0zMfSmjYrbLOj1GuP3A+hgLflG6KEo9Qj uF9BKnl4IFxQIbVomJRMZUCEHkRt X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--3.401100-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24946.003 X-MDID: 1569948004-NfRYHaqHogWb Subject: Re: [dpdk-dev] [PATCH 1/3] net/virtio: reject deferred start Rx queue setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Kevin, On 10/1/19 7:29 PM, Kevin Traynor wrote: > Hi, > > On 01/10/2019 16:44, Andrew Rybchenko wrote: >> From: Dilshod Urazov >> >> Deferred start Rx queue is not supported by the driver. >> >> Fixes: 0748be2cf9a2 ("ethdev: queue start and stop") >> Cc: stable@dpdk.org >> >> Signed-off-by: Dilshod Urazov >> Signed-off-by: Andrew Rybchenko >> --- >> drivers/net/virtio/virtio_rxtx.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c >> index 929aa4cbd..9c8c617f7 100644 >> --- a/drivers/net/virtio/virtio_rxtx.c >> +++ b/drivers/net/virtio/virtio_rxtx.c >> @@ -929,6 +929,11 @@ virtio_dev_rx_queue_setup(struct rte_eth_dev *dev, >> > const struct rte_eth_rxconf *rx_conf __rte_unused, > ^^^^^^^^^^^^ > The unused can be removed now Thanks, will fix in v2. >> PMD_INIT_FUNC_TRACE(); >> >> + if (rx_conf->rx_deferred_start) { >> + PMD_INIT_LOG(ERR, "Rx deferred start is not supported"); >> + return -EINVAL; >> + } >> + >> if (nb_desc == 0 || nb_desc > vq->vq_nentries) >> nb_desc = vq->vq_nentries; >> vq->vq_free_cnt = RTE_MIN(vq->vq_free_cnt, nb_desc); >>