* [dpdk-dev] [PATCH] i40e: fix the issue dcb cannot be configured when FW version is 5.x
@ 2015-11-16 8:56 Jingjing Wu
2015-11-19 6:16 ` Pei, Yulong
0 siblings, 1 reply; 3+ messages in thread
From: Jingjing Wu @ 2015-11-16 8:56 UTC (permalink / raw)
To: dev
When NVM version is updated to 5.x, DCB can not be configured. This
issue is because of the FW version validation is not correct.
This patch fixed this issue.
Fixes: c8b9a3e3fe1b (i40e: support DCB mode)
Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 2c51a0b..9003488 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -8316,7 +8316,8 @@ i40e_dcb_hw_configure(struct i40e_pf *pf,
uint32_t val;
/* Use the FW API if FW > v4.4*/
- if (!((hw->aq.fw_maj_ver == 4) && (hw->aq.fw_min_ver >= 4))) {
+ if (!(((hw->aq.fw_maj_ver == 4) && (hw->aq.fw_min_ver >= 4)) ||
+ (hw->aq.fw_maj_ver >= 5))) {
PMD_INIT_LOG(ERR, "FW < v4.4, can not use FW LLDP API"
" to configure DCB");
return I40E_ERR_FIRMWARE_API_VERSION;
--
2.4.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] i40e: fix the issue dcb cannot be configured when FW version is 5.x
2015-11-16 8:56 [dpdk-dev] [PATCH] i40e: fix the issue dcb cannot be configured when FW version is 5.x Jingjing Wu
@ 2015-11-19 6:16 ` Pei, Yulong
2015-11-23 22:20 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Pei, Yulong @ 2015-11-19 6:16 UTC (permalink / raw)
To: Wu, Jingjing, dev
Tested-by: Yulong Pei <Yulong.pei@intel.com>
-----Original Message-----
From: Wu, Jingjing
Sent: Monday, November 16, 2015 4:57 PM
To: dev@dpdk.org
Cc: Wu, Jingjing <jingjing.wu@intel.com>; Zhang, Helin <helin.zhang@intel.com>; Pei, Yulong <yulong.pei@intel.com>
Subject: [PATCH] i40e: fix the issue dcb cannot be configured when FW version is 5.x
When NVM version is updated to 5.x, DCB can not be configured. This issue is because of the FW version validation is not correct.
This patch fixed this issue.
Fixes: c8b9a3e3fe1b (i40e: support DCB mode)
Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 2c51a0b..9003488 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -8316,7 +8316,8 @@ i40e_dcb_hw_configure(struct i40e_pf *pf,
uint32_t val;
/* Use the FW API if FW > v4.4*/
- if (!((hw->aq.fw_maj_ver == 4) && (hw->aq.fw_min_ver >= 4))) {
+ if (!(((hw->aq.fw_maj_ver == 4) && (hw->aq.fw_min_ver >= 4)) ||
+ (hw->aq.fw_maj_ver >= 5))) {
PMD_INIT_LOG(ERR, "FW < v4.4, can not use FW LLDP API"
" to configure DCB");
return I40E_ERR_FIRMWARE_API_VERSION;
--
2.4.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] i40e: fix the issue dcb cannot be configured when FW version is 5.x
2015-11-19 6:16 ` Pei, Yulong
@ 2015-11-23 22:20 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2015-11-23 22:20 UTC (permalink / raw)
To: Wu, Jingjing; +Cc: dev
> When NVM version is updated to 5.x, DCB can not be configured. This issue is because of the FW version validation is not correct.
> This patch fixed this issue.
>
> Fixes: c8b9a3e3fe1b (i40e: support DCB mode)
>
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
Tested-by: Yulong Pei <yulong.pei@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-23 22:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-16 8:56 [dpdk-dev] [PATCH] i40e: fix the issue dcb cannot be configured when FW version is 5.x Jingjing Wu
2015-11-19 6:16 ` Pei, Yulong
2015-11-23 22:20 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).