From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 2E2E7201 for ; Tue, 18 Jul 2017 12:43:43 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jul 2017 03:43:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,377,1496127600"; d="scan'208";a="126410815" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.255.134.81]) ([10.255.134.81]) by orsmga005.jf.intel.com with ESMTP; 18 Jul 2017 03:43:39 -0700 To: Wei Zhao , dev@dpdk.org Cc: wenzhuo.lu@intel.com References: <1500272004-35941-1-git-send-email-wei.zhao1@intel.com> From: Ferruh Yigit Message-ID: <3677ba30-b6de-50eb-a85a-7b19e35c876c@intel.com> Date: Tue, 18 Jul 2017 11:43:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1500272004-35941-1-git-send-email-wei.zhao1@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: add queue index check in filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jul 2017 10:43:44 -0000 On 7/17/2017 7:13 AM, Wei Zhao wrote: > Add queue index check when create filter rule, or > filter with invalid queue id can be created successfully. > > Signed-off-by: Wei Zhao <...> > @@ -1177,6 +1178,9 @@ ixgbe_parse_l2_tn_filter(struct rte_eth_dev *dev, > return -rte_errno; > } > > + if (filter->queue >= dev->data->nb_rx_queues) > + return -rte_errno; > + This is giving following build error [1]. [1] .../drivers/net/ixgbe/ixgbe_flow.c:1180:6: error: use of undeclared identifier 'filter' if (filter->queue >= dev->data->nb_rx_queues) ^