From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id CB0FC916F; Tue, 1 Aug 2017 14:05:48 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D062044020; Tue, 1 Aug 2017 12:05:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D062044020 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=maxime.coquelin@redhat.com Received: from [10.36.112.18] (ovpn-112-18.ams2.redhat.com [10.36.112.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 402715D963; Tue, 1 Aug 2017 12:05:45 +0000 (UTC) To: Tiwei Bie , dev@dpdk.org Cc: yliu@fridaylinux.org, stable@dpdk.org References: <1501578081-191381-1-git-send-email-tiwei.bie@intel.com> From: Maxime Coquelin Message-ID: <367875c7-d9f8-03e2-f7af-07e98cd5f772@redhat.com> Date: Tue, 1 Aug 2017 14:05:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1501578081-191381-1-git-send-email-tiwei.bie@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 01 Aug 2017 12:05:48 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] vhost: make the page logging atomic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Aug 2017 12:05:49 -0000 On 08/01/2017 11:01 AM, Tiwei Bie wrote: > Each dirty page logging operation should be atomic. But it's not > atomic in current implementation. So it's possible that some dirty > pages can't be logged successfully when different threads try to > log different pages into the same byte of the log buffer concurrently. > This patch fixes this issue. > > Fixes: b171fad1ffa5 ("vhost: log used vring changes") > Cc:stable@dpdk.org > > Reported-by: Xiao Wang > Signed-off-by: Tiwei Bie > --- > lib/librte_vhost/vhost.h | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) Reviewed-by: Maxime Coquelin Thanks, Maxime