From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 461BCA04FD; Mon, 4 Jul 2022 10:31:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB4E2410E5; Mon, 4 Jul 2022 10:31:27 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4115840E09 for ; Mon, 4 Jul 2022 10:31:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656923486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tAKA+33VJcUbxvXuej+ClN9jrosjqouLelzSvDpxMgc=; b=eCabtrSWUgXp57E5N+a9hlE39aqtj2AqvPCy6O3o89Xzqp3f4FlHJR8LTbkswQoepdHSAk 1ga6QU1FvBLDzuQbk83p5CXGq7apxEnmbFodiZ8Zb/sh1vPD+YA8zJIMmdYYI1Dp6amx6f sxrNXMnK3t6UyZInlNB5Z+7HD//COD4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-553-9I00-oCkMgyQTi-0_pjU3Q-1; Mon, 04 Jul 2022 04:31:23 -0400 X-MC-Unique: 9I00-oCkMgyQTi-0_pjU3Q-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CFEFA81D9CA; Mon, 4 Jul 2022 08:31:22 +0000 (UTC) Received: from [10.39.208.35] (unknown [10.39.208.35]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 62B72492CA3; Mon, 4 Jul 2022 08:31:21 +0000 (UTC) Message-ID: <368278d1-ec80-2393-eac9-61618d98d2a8@redhat.com> Date: Mon, 4 Jul 2022 10:31:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] net/virtio-user: restore callfds index for Rx interrupts To: Yuan Wang , chenbo.xia@intel.com, dev@dpdk.org Cc: jiayu.hu@intel.com, xingguang.he@intel.com, cheng1.jiang@intel.com, hkalra@marvell.com, david.marchand@redhat.com, stable@dpdk.org References: <20220704070428.2051264-1-yuanx.wang@intel.com> From: Maxime Coquelin In-Reply-To: <20220704070428.2051264-1-yuanx.wang@intel.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/4/22 09:04, Yuan Wang wrote: > The callfds[] array stores eventfds sequentially for Rx and Tx vq. > > Fixes: d61138d4f0e2 ("drivers: remove direct access to interrupt handle") > Cc: stable@dpdk.org > > Signed-off-by: Yuan Wang > --- > drivers/net/virtio/virtio_user/virtio_user_dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c > index 35aa76b1ff..f9cada05e4 100644 > --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c > +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c > @@ -417,7 +417,7 @@ virtio_user_fill_intr_handle(struct virtio_user_dev *dev) > > for (i = 0; i < dev->max_queue_pairs; ++i) { > if (rte_intr_efds_index_set(eth_dev->intr_handle, i, > - dev->callfds[i])) > + dev->callfds[2 * i + VTNET_SQ_RQ_QUEUE_IDX])) > return -rte_errno; > } > Thanks Yuan, good catch! Applied to dpdk-next-virtio/main. Maxime